refactor: implement biome (#1467)

- add `biome.json`
- add `biome:check` and `biome:check:fix` commands to `package.json`
- add `biome:check:fix` command to run as part of `prepare-code` command
- install `@biomejs/biome` dependency
- add `@npmcli/move-file` v2.0.1 to `pnpm.allowedDeprecatedVersions`
- fix or comment out various reported lint issues

16 files changed, 28 insertions, 43 deletions

diff --git a/src/components/auth/SetupAssistant.tsx b/src/components/auth/SetupAssistant.tsx
index fdcbba45e..c25495471 100644
--- a/src/components/auth/SetupAssistant.tsx
+++ b/src/components/auth/SetupAssistant.tsx
@@ -39,10 +39,9 @@ const messages = defineMessages({
   },
 });
 
-const transition =
-  window && window.matchMedia('(prefers-reduced-motion: no-preference)')
-    ? 'all 0.25s'
-    : 'none';
+const transition = window?.matchMedia('(prefers-reduced-motion: no-preference)')
+  ? 'all 0.25s'
+  : 'none';
 
 const styles = theme => ({
   root: {
diff --git a/src/components/auth/Welcome.tsx b/src/components/auth/Welcome.tsx
index 259e3c335..c1a2db386 100644
--- a/src/components/auth/Welcome.tsx
+++ b/src/components/auth/Welcome.tsx
@@ -91,8 +91,8 @@ class Welcome extends Component<IProps> {
             className="settings__hr-sections"
             style={{ marginTop: 24, marginBottom: 24, borderStyle: 'solid' }}
           />
-          {/* eslint-disable-next-line react/button-has-type */}
           <button
+            type="button"
             className="button"
             onClick={this.useLocalServer.bind(this)}
             onKeyDown={noop}
diff --git a/src/components/layout/Sidebar.tsx b/src/components/layout/Sidebar.tsx
index 7904d7653..e423e408b 100644
--- a/src/components/layout/Sidebar.tsx
+++ b/src/components/layout/Sidebar.tsx
@@ -352,6 +352,7 @@ class Sidebar extends Component<IProps, IState> {
             type="button"
             onClick={() => openDownloads({ path: '/downloadmanager' })}
             className={
+              // biome-ignore lint/style/useTemplate: <explanation>
               'sidebar__button' +
               `${isDownloading ? ' sidebar__button--downloading' : ''}` +
               `${justFinishedDownloading ? ' sidebar__button--done' : ''}`
diff --git a/src/components/services/tabs/TabItem.tsx b/src/components/services/tabs/TabItem.tsx
index 287dedfcb..804efe8a5 100644
--- a/src/components/services/tabs/TabItem.tsx
+++ b/src/components/services/tabs/TabItem.tsx
@@ -80,7 +80,7 @@ let pollIndicatorTransition = 'none';
 let polledTransition = 'none';
 let pollAnsweredTransition = 'none';
 
-if (window && window.matchMedia('(prefers-reduced-motion: no-preference)')) {
+if (window?.matchMedia('(prefers-reduced-motion: no-preference)')) {
   pollIndicatorTransition = 'background 0.5s';
   polledTransition = 'background 0.1s';
   pollAnsweredTransition = 'background 0.1s';
diff --git a/src/components/settings/services/ServiceItem.tsx b/src/components/settings/services/ServiceItem.tsx
index babe06b5a..35b63b160 100644
--- a/src/components/settings/services/ServiceItem.tsx
+++ b/src/components/settings/services/ServiceItem.tsx
@@ -44,11 +44,7 @@ class ServiceItem extends Component<IProps> {
           'service-table__row--disabled': !service.isEnabled,
         })}
       >
-        <td
-          className="service-table__column-icon"
-          onClick={goToServiceForm}
-          role="gridcell"
-        >
+        <td className="service-table__column-icon" onClick={goToServiceForm}>
           <img
             src={service.icon}
             className={classnames({
@@ -58,18 +54,10 @@ class ServiceItem extends Component<IProps> {
             alt=""
           />
         </td>
-        <td
-          className="service-table__column-name"
-          onClick={goToServiceForm}
-          role="gridcell"
-        >
+        <td className="service-table__column-name" onClick={goToServiceForm}>
           {service.name === '' ? service.recipe.name : service.name}
         </td>
-        <td
-          className="service-table__column-info"
-          onClick={goToServiceForm}
-          role="gridcell"
-        >
+        <td className="service-table__column-info" onClick={goToServiceForm}>
           {service.isMuted && (
             <Icon
               icon={mdiBellOff}
@@ -78,11 +66,7 @@ class ServiceItem extends Component<IProps> {
             />
           )}
         </td>
-        <td
-          className="service-table__column-info"
-          onClick={goToServiceForm}
-          role="gridcell"
-        >
+        <td className="service-table__column-info" onClick={goToServiceForm}>
           {!service.isEnabled && (
             <Icon
               icon={mdiPower}
@@ -93,11 +77,7 @@ class ServiceItem extends Component<IProps> {
             />
           )}
         </td>
-        <td
-          className="service-table__column-info"
-          onClick={goToServiceForm}
-          role="gridcell"
-        >
+        <td className="service-table__column-info" onClick={goToServiceForm}>
           {!service.isNotificationEnabled && (
             <Icon
               icon={mdiMessageBulletedOff}
diff --git a/src/components/ui/Link.tsx b/src/components/ui/Link.tsx
index a9a429d3a..f9fdd57f9 100644
--- a/src/components/ui/Link.tsx
+++ b/src/components/ui/Link.tsx
@@ -54,6 +54,7 @@ class Link extends Component<IProps> {
     });
 
     return (
+      // biome-ignore lint/a11y/useValidAnchor: <explanation>
       <a
         href={router.history.createHref(to)}
         className={linkClasses}
diff --git a/src/components/ui/Radio.tsx b/src/components/ui/Radio.tsx
index 1f41deedc..901958c78 100644
--- a/src/components/ui/Radio.tsx
+++ b/src/components/ui/Radio.tsx
@@ -2,6 +2,7 @@ import { Component } from 'react';
 import { observer } from 'mobx-react';
 import classnames from 'classnames';
 import FieldInterface from 'mobx-react-form/lib/models/FieldInterface';
+// biome-ignore lint/suspicious/noShadowRestrictedNames: <explanation>
 import Error from './error';
 
 type Props = {
diff --git a/src/components/ui/button/index.tsx b/src/components/ui/button/index.tsx
index f8bcf76b2..a2194e34d 100644
--- a/src/components/ui/button/index.tsx
+++ b/src/components/ui/button/index.tsx
@@ -205,6 +205,7 @@ class ButtonComponent extends Component<IProps, IState> {
     );
 
     const wrapperComponent = href ? (
+      // biome-ignore lint/a11y/useValidAnchor: <explanation>
       <a
         href={href}
         target={target}
diff --git a/src/components/ui/input/index.tsx b/src/components/ui/input/index.tsx
index 064c1807f..68cc9ee22 100644
--- a/src/components/ui/input/index.tsx
+++ b/src/components/ui/input/index.tsx
@@ -14,6 +14,7 @@ import { observer } from 'mobx-react';
 import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
 import Icon from '../icon';
 import { IFormField } from '../typings/generic';
+// biome-ignore lint/suspicious/noShadowRestrictedNames: <explanation>
 import Error from '../error';
 import Label from '../label';
 import Wrapper from '../wrapper';
diff --git a/src/components/ui/select/index.tsx b/src/components/ui/select/index.tsx
index 650600fb3..c06ac59b0 100644
--- a/src/components/ui/select/index.tsx
+++ b/src/components/ui/select/index.tsx
@@ -10,6 +10,7 @@ import withStyles, { WithStylesProps } from 'react-jss';
 import { noop } from 'lodash';
 import { Theme } from '../../../themes';
 import { IFormField } from '../typings/generic';
+// biome-ignore lint/suspicious/noShadowRestrictedNames: <explanation>
 import Error from '../error';
 import Label from '../label';
 import Wrapper from '../wrapper';
diff --git a/src/components/ui/textarea/index.tsx b/src/components/ui/textarea/index.tsx
index fbdef7fc6..0967c4c25 100644
--- a/src/components/ui/textarea/index.tsx
+++ b/src/components/ui/textarea/index.tsx
@@ -5,6 +5,7 @@ import injectSheet, { WithStylesProps } from 'react-jss';
 import { noop } from 'lodash';
 import { IFormField } from '../typings/generic';
 
+// biome-ignore lint/suspicious/noShadowRestrictedNames: <explanation>
 import Error from '../error';
 import Label from '../label';
 import Wrapper from '../wrapper';
@@ -40,6 +41,7 @@ class TextareaComponent extends Component<IProps> {
 
     if (this.textareaRef?.current && data) {
       Object.keys(data).map(
+        // biome-ignore lint/suspicious/noAssignInExpressions: <explanation>
         key => (this.textareaRef.current!.dataset[key] = data[key]),
       );
     }
diff --git a/src/components/ui/toggle/index.tsx b/src/components/ui/toggle/index.tsx
index 275d28bf6..878ffecdc 100644
--- a/src/components/ui/toggle/index.tsx
+++ b/src/components/ui/toggle/index.tsx
@@ -4,6 +4,7 @@ import { noop } from 'lodash';
 import { Component, InputHTMLAttributes, ReactElement } from 'react';
 import withStyles, { WithStylesProps } from 'react-jss';
 import { Theme } from '../../../themes';
+// biome-ignore lint/suspicious/noShadowRestrictedNames: <explanation>
 import Error from '../error';
 import Label from '../label';
 import { IFormField } from '../typings/generic';
diff --git a/src/features/workspaces/components/WorkspaceDrawerItem.tsx b/src/features/workspaces/components/WorkspaceDrawerItem.tsx
index 4fd7662f5..85ed4c38c 100644
--- a/src/features/workspaces/components/WorkspaceDrawerItem.tsx
+++ b/src/features/workspaces/components/WorkspaceDrawerItem.tsx
@@ -72,8 +72,7 @@ interface IProps extends WithStylesProps<typeof styles>, WrappedComponentProps {
   name: string;
   onClick: MouseEventHandler<HTMLInputElement>;
   services: string[];
-  // eslint-disable-next-line @typescript-eslint/no-invalid-void-type
-  onContextMenuEditClick?: () => void | null;
+  onContextMenuEditClick?: (() => void) | null;
   shortcutIndex: number;
 }
 
diff --git a/src/internal-server/app/Controllers/Http/RecipeController.js b/src/internal-server/app/Controllers/Http/RecipeController.js
index 3e54ab65b..48d3ce7e5 100644
--- a/src/internal-server/app/Controllers/Http/RecipeController.js
+++ b/src/internal-server/app/Controllers/Http/RecipeController.js
@@ -59,8 +59,8 @@ class RecipeController {
       }));
     } else {
       let remoteResults = [];
-      // eslint-disable-next-line eqeqeq
-      if (Env.get('CONNECT_WITH_FRANZ') == 'true') {
+
+      if (Env.get('CONNECT_WITH_FRANZ') === 'true') {
         const recipesUrlFetch = await fetch(
           `${RECIPES_URL}/search?needle=${encodeURIComponent(needle)}`,
         );
@@ -123,8 +123,8 @@ class RecipeController {
     if (await Drive.exists(`${service}.tar.gz`)) {
       return response.send(await Drive.get(`${service}.tar.gz`));
     }
-    // eslint-disable-next-line eqeqeq
-    if (Env.get('CONNECT_WITH_FRANZ') == 'true') {
+
+    if (Env.get('CONNECT_WITH_FRANZ') === 'true') {
       return response.redirect(`${RECIPES_URL}/download/${service}`);
     }
     return response.status(400).send({
diff --git a/src/internal-server/app/Controllers/Http/ServiceController.js b/src/internal-server/app/Controllers/Http/ServiceController.js
index 940cac065..8e8aa97a8 100644
--- a/src/internal-server/app/Controllers/Http/ServiceController.js
+++ b/src/internal-server/app/Controllers/Http/ServiceController.js
@@ -126,10 +126,9 @@ class ServiceController {
       const newSettings = {
         ...settings,
         iconId,
-        customIconVersion:
-          settings && settings.customIconVersion
-            ? settings.customIconVersion + 1
-            : 1,
+        customIconVersion: settings?.customIconVersion
+          ? settings.customIconVersion + 1
+          : 1,
       };
 
       // Update data in database
diff --git a/src/internal-server/start/migrate.js b/src/internal-server/start/migrate.js
index 4cd502c3f..67533ed9e 100644
--- a/src/internal-server/start/migrate.js
+++ b/src/internal-server/start/migrate.js
@@ -35,8 +35,7 @@ module.exports = async () => {
     !settings.db_version ||
     settings.db_version !== ferdiumVersion
   ) {
-    const srcVersion =
-      settings && settings.db_version ? settings.db_version : '5.4.0-beta.2';
+    const srcVersion = settings?.db_version || '5.4.0-beta.2';
     migrateLog(`🔮  Migrating table from ${srcVersion} to ${ferdiumVersion}`);
 
     // Migrate database to current Ferdium version