refactor: various improvements (#1296)

* refactor: various improvements

- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme

* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency

1 files changed, 0 insertions, 11 deletions

diff --git a/src/themes/legacy/index.ts b/src/themes/legacy/index.ts
index ca3216e7f..9caefc698 100644
--- a/src/themes/legacy/index.ts
+++ b/src/themes/legacy/index.ts
@@ -1,10 +1,7 @@
 /* legacy config, injected into sass */
 export { DEFAULT_ACCENT_COLOR as themeBrandPrimary } from '../../config';
 
-export const themeBrandSuccess = '#5cb85c';
 export const themeBrandInfo = '#5bc0de';
-export const themeBrandWarning = '#FF9F00';
-export const themeBrandDanger = '#d9534f';
 
 export const themeGrayDark = '#373a3c';
 export const themeGray = '#55595c';
@@ -15,14 +12,6 @@ export const themeGrayLightest = '#f7f7f9';
 export const themeBorderRadius = '6px';
 export const themeBorderRadiusSmall = '3px';
 
-export const themeSidebarWidth = '68px';
-
-export const themeTextColor = themeGrayDark;
-
-export const themeTransitionTime = '.5s';
-
-export const themeInsetShadow = 'inset 0 2px 5px rgba(0, 0, 0, .03)';
-
 export const darkThemeBlack = '#1A1A1A';
 
 export const darkThemeGrayDarkest = '#1E1E1E';