chore: improve lint setup

- update eslint config
- merged eslint rules for JS and TS to avoid duplicates
- extended stricter lint ruleset from typescript-eslint
- corrected wrong setup for certain eslint rulesets
- opt in to reportUnusedDisableDirectives config option
- fix or disable a lot of lint issues throughout codebase
- remove trailingComma: all from prettier config which is default in prettier v3
- add volta configuration to package.json to autoload correct node and pnpm versions
- upgrade all eslint and prettier related dependencies to latest
- remove config options from settings.json which are default anyways
- remove config options from settings.json which are outdated/unknown
- set up prettier as default formatter in settings.json

7 files changed, 27 insertions, 17 deletions

diff --git a/src/stores/AppStore.ts b/src/stores/AppStore.ts
index 82591a2a4..412c52ecf 100644
--- a/src/stores/AppStore.ts
+++ b/src/stores/AppStore.ts
@@ -351,6 +351,7 @@ export default class AppStore extends TypedStore {
 
     // TODO: is there a simple way to use blobs for notifications without storing them on disk?
     if (options.icon?.startsWith('blob:')) {
+      // eslint-disable-next-line no-param-reassign
       delete options.icon;
     }
 
@@ -493,6 +494,7 @@ export default class AppStore extends TypedStore {
         allOrphanedServiceIds.map(id => removeServicePartitionDirectory(id)),
       );
     } catch (error) {
+      // eslint-disable-next-line no-console
       console.log('Error while deleting service partition directory -', error);
     }
     await Promise.all(
diff --git a/src/stores/GlobalErrorStore.ts b/src/stores/GlobalErrorStore.ts
index 8547fec72..74a43100b 100644
--- a/src/stores/GlobalErrorStore.ts
+++ b/src/stores/GlobalErrorStore.ts
@@ -27,34 +27,36 @@ export default class GlobalErrorStore extends TypedStore {
 
   @observable response: Response = {} as Response;
 
-  // TODO: Get rid of the @ts-ignores in this function.
+  // TODO: Get rid of the @ts-expect-errors in this function.
   constructor(stores: Stores, api: ApiInterface, actions: Actions) {
     super(stores, api, actions);
 
     makeObservable(this);
 
     window.addEventListener('error', (...errorArgs: any[]): void => {
-      // @ts-ignore ts-message: Expected 5 arguments, but got 2.
+      // @ts-expect-error ts-message: Expected 5 arguments, but got 2.
       this._handleConsoleError.call(this, ['error', ...errorArgs]);
     });
 
     const origConsoleError = console.error;
     window.console.error = (...errorArgs: any[]) => {
-      // @ts-ignore ts-message: Expected 5 arguments, but got 2.
+      // @ts-expect-error ts-message: Expected 5 arguments, but got 2.
       this._handleConsoleError.call(this, ['error', ...errorArgs]);
       origConsoleError.apply(this, errorArgs);
     };
 
+    // eslint-disable-next-line no-console
     const origConsoleLog = console.log;
     window.console.log = (...logArgs: any[]) => {
-      // @ts-ignore ts-message: Expected 5 arguments, but got 2.
+      // @ts-expect-error ts-message: Expected 5 arguments, but got 2.
       this._handleConsoleError.call(this, ['log', ...logArgs]);
       origConsoleLog.apply(this, logArgs);
     };
 
+    // eslint-disable-next-line no-console
     const origConsoleInfo = console.info;
     window.console.info = (...infoArgs: any[]) => {
-      // @ts-ignore ts-message: Expected 5 arguments, but got 2.
+      // @ts-expect-error ts-message: Expected 5 arguments, but got 2.
       this._handleConsoleError.call(this, ['info', ...infoArgs]);
       origConsoleInfo.apply(this, infoArgs);
     };
diff --git a/src/stores/RecipesStore.ts b/src/stores/RecipesStore.ts
index 07f1343f8..b645a5989 100644
--- a/src/stores/RecipesStore.ts
+++ b/src/stores/RecipesStore.ts
@@ -36,6 +36,7 @@ export default class RecipesStore extends TypedStore {
 
   async setup(): Promise<void> {
     // Initially load all recipes
+    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     this.all;
   }
 
diff --git a/src/stores/ServicesStore.ts b/src/stores/ServicesStore.ts
index 44f8b277c..7f4693cad 100644
--- a/src/stores/ServicesStore.ts
+++ b/src/stores/ServicesStore.ts
@@ -435,7 +435,7 @@ export default class ServicesStore extends TypedStore {
 
   // TODO: This can actually return undefined as well
   one(id: string): Service {
-    return this.all.find(service => service.id === id) as Service;
+    return this.all.find(service => service.id === id)!;
   }
 
   async _showAddServiceInterface({ recipeId }) {
diff --git a/src/stores/SettingsStore.ts b/src/stores/SettingsStore.ts
index 5ca499160..90cd82690 100644
--- a/src/stores/SettingsStore.ts
+++ b/src/stores/SettingsStore.ts
@@ -70,14 +70,17 @@ export default class SettingsStore extends TypedStore {
         this.all.app.lockingFeatureEnabled &&
         this.all.app.inactivityLock !== 0
       ) {
-        inactivityTimer = setTimeout(() => {
-          this.actions.settings.update({
-            type: 'app',
-            data: {
-              locked: true,
-            },
-          });
-        }, this.all.app.inactivityLock * 1000 * 60);
+        inactivityTimer = setTimeout(
+          () => {
+            this.actions.settings.update({
+              type: 'app',
+              data: {
+                locked: true,
+              },
+            });
+          },
+          this.all.app.inactivityLock * 1000 * 60,
+        );
       }
     });
     getCurrentWindow().on('focus', () => {
@@ -176,6 +179,7 @@ export default class SettingsStore extends TypedStore {
 
     const appSettings = this.all[type];
     if (Object.hasOwnProperty.call(appSettings, key)) {
+      // eslint-disable-next-line @typescript-eslint/no-dynamic-delete
       delete appSettings[key];
 
       this.actions.settings.update({
@@ -185,6 +189,7 @@ export default class SettingsStore extends TypedStore {
     }
   }
 
+  // eslint-disable-next-line @typescript-eslint/ban-types
   _ensureMigrationAndMarkDone(migrationName: string, callback: Function): void {
     if (!this.all.migration[migrationName]) {
       callback();
diff --git a/src/stores/UserStore.ts b/src/stores/UserStore.ts
index 7ba8f4222..0616acdad 100644
--- a/src/stores/UserStore.ts
+++ b/src/stores/UserStore.ts
@@ -210,7 +210,7 @@ export default class UserStore extends TypedStore {
     currency,
   }): Promise<void> {
     // TODO: [TS DEBT] Need to find a way proper to implement promise's then and catch in request class
-    // @ts-ignore
+    // @ts-expect-error Fix me
     const authToken = await this.signupRequest.execute({
       firstname,
       lastname,
@@ -400,7 +400,7 @@ export default class UserStore extends TypedStore {
     const params = new URLSearchParams(parsedUrl.search.slice(1));
 
     // TODO: Remove the neccesity for `as string`
-    params.append('authToken', this.authToken as string);
+    params.append('authToken', this.authToken!);
 
     return `${parsedUrl.origin}${parsedUrl.pathname}?${params.toString()}`;
   }
diff --git a/src/stores/lib/TypedStore.ts b/src/stores/lib/TypedStore.ts
index 0a669e669..8bae529ba 100644
--- a/src/stores/lib/TypedStore.ts
+++ b/src/stores/lib/TypedStore.ts
@@ -41,7 +41,7 @@ export default abstract class TypedStore {
     this.actions = actions;
   }
 
-  registerReactions(reactions: { (r: IReactionPublic): void }[]): void {
+  registerReactions(reactions: ((r: IReactionPublic) => void)[]): void {
     for (const reaction of reactions) {
       this._reactions.push(new Reaction(reaction));
     }