refactor: various improvements (#1296)

* refactor: various improvements

- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme

* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency

3 files changed, 11 insertions, 13 deletions

diff --git a/src/stores/ServicesStore.ts b/src/stores/ServicesStore.ts
index 7f4693cad..82f3b95ce 100644
--- a/src/stores/ServicesStore.ts
+++ b/src/stores/ServicesStore.ts
@@ -594,7 +594,7 @@ export default class ServicesStore extends TypedStore {
       this.stores.router.push(redirect);
     }
 
-    this.allServicesRequest.patch(result => {
+    this.allServicesRequest.patch((result: Service[]) => {
       remove(result, (c: Service) => c.id === serviceId);
     });
 
@@ -606,7 +606,7 @@ export default class ServicesStore extends TypedStore {
     // Get directory for recipe
     const normalDirectory = getRecipeDirectory(recipe);
     const devDirectory = getDevRecipeDirectory(recipe);
-    let directory;
+    let directory: string;
 
     if (pathExistsSync(normalDirectory)) {
       directory = normalDirectory;
@@ -1028,7 +1028,7 @@ export default class ServicesStore extends TypedStore {
     }
 
     this.reorderServicesRequest.execute(services);
-    this.allServicesRequest.patch(data => {
+    this.allServicesRequest.patch((data: Service[]) => {
       for (const s of data) {
         s.order = services[s.id];
       }
@@ -1172,7 +1172,7 @@ export default class ServicesStore extends TypedStore {
     );
 
     // eslint-disable-next-line unicorn/consistent-function-scoping
-    const resetTimer = service => {
+    const resetTimer = (service: Service) => {
       service.lastPollAnswer = Date.now();
       service.lastPoll = Date.now();
     };
@@ -1306,7 +1306,7 @@ export default class ServicesStore extends TypedStore {
     });
   }
 
-  _cleanUpTeamIdAndCustomUrl(recipeId, data): any {
+  _cleanUpTeamIdAndCustomUrl(recipeId: string, data: Service): any {
     const serviceData = data;
     const recipe = this.stores.recipes.one(recipeId);
 
@@ -1318,6 +1318,7 @@ export default class ServicesStore extends TypedStore {
       data.team &&
       data.customUrl
     ) {
+      // @ts-expect-error The operand of a 'delete' operator must be optional.
       delete serviceData.team;
     }
 
@@ -1343,7 +1344,7 @@ export default class ServicesStore extends TypedStore {
   }
 
   // Helper
-  _initializeServiceRecipeInWebview(serviceId) {
+  _initializeServiceRecipeInWebview(serviceId: string) {
     const service = this.one(serviceId);
 
     if (service.webview) {
@@ -1362,7 +1363,7 @@ export default class ServicesStore extends TypedStore {
     }
   }
 
-  _initRecipePolling(serviceId) {
+  _initRecipePolling(serviceId: string) {
     const service = this.one(serviceId);
 
     const delay = ms('2s');
@@ -1385,7 +1386,7 @@ export default class ServicesStore extends TypedStore {
     }
   }
 
-  _wrapIndex(index, delta, size) {
+  _wrapIndex(index: number, delta: number, size: number) {
     return (((index + delta) % size) + size) % size;
   }
 }
diff --git a/src/stores/lib/CachedRequest.ts b/src/stores/lib/CachedRequest.ts
index 25cc365e2..b24336fe6 100644
--- a/src/stores/lib/CachedRequest.ts
+++ b/src/stores/lib/CachedRequest.ts
@@ -1,5 +1,5 @@
 import { action } from 'mobx';
-import { isEqual, remove } from 'lodash';
+import { isEqual } from 'lodash';
 import Request from './Request';
 
 export default class CachedRequest extends Request {
@@ -110,10 +110,6 @@ export default class CachedRequest extends Request {
     });
   }
 
-  removeCacheForCallWith(...args: any): void {
-    remove(this._apiCalls, c => isEqual(c.args, args));
-  }
-
   _addApiCall(args: any) {
     const newCall = { args, result: null };
     this._apiCalls.push(newCall);
diff --git a/src/stores/lib/Request.ts b/src/stores/lib/Request.ts
index f9424ac99..911c5ccfb 100644
--- a/src/stores/lib/Request.ts
+++ b/src/stores/lib/Request.ts
@@ -1,6 +1,7 @@
 import { observable, action, computed, makeObservable } from 'mobx';
 import { isEqual } from 'lodash/fp';
 
+// eslint-disable-next-line no-use-before-define
 type Hook = (request: Request) => void;
 
 export default class Request {