feat: add eslint-plugin-unicorn (#1936)

1 files changed, 15 insertions, 17 deletions

diff --git a/src/stores/AppStore.js b/src/stores/AppStore.js
index 469e7519e..85f74a91e 100644
--- a/src/stores/AppStore.js
+++ b/src/stores/AppStore.js
@@ -251,16 +251,14 @@ export default class AppStore extends Store {
     // macOS catalina notifications hack
     // notifications got stuck after upgrade but forcing a notification
     // via `new Notification` triggered the permission request
-    if (isMac) {
-      if (!localStorage.getItem(CATALINA_NOTIFICATION_HACK_KEY)) {
-        debug('Triggering macOS Catalina notification permission trigger');
-        // eslint-disable-next-line no-new
-        new window.Notification('Welcome to Ferdi 5', {
-          body: 'Have a wonderful day & happy messaging.',
-        });
+    if (isMac && !localStorage.getItem(CATALINA_NOTIFICATION_HACK_KEY)) {
+      debug('Triggering macOS Catalina notification permission trigger');
+      // eslint-disable-next-line no-new
+      new window.Notification('Welcome to Ferdi 5', {
+        body: 'Have a wonderful day & happy messaging.',
+      });
 
-        localStorage.setItem(CATALINA_NOTIFICATION_HACK_KEY, true);
-      }
+      localStorage.setItem(CATALINA_NOTIFICATION_HACK_KEY, true);
     }
   }
 
@@ -325,7 +323,7 @@ export default class AppStore extends Store {
 
     debug('New notification', title, options);
 
-    notification.onclick = () => {
+    notification.addEventListener('click', () => {
       if (serviceId) {
         this.actions.service.sendIPCMessage({
           channel: `notification-onclick:${notificationId}`,
@@ -346,7 +344,7 @@ export default class AppStore extends Store {
 
         debug('Notification click handler');
       }
-    };
+    });
   }
 
   @action _setBadge({ unreadDirectMessageCount, unreadIndirectMessageCount }) {
@@ -360,7 +358,7 @@ export default class AppStore extends Store {
     ) {
       indicator = 0;
     } else {
-      indicator = parseInt(indicator, 10);
+      indicator = Number.parseInt(indicator, 10);
     }
 
     ipcRenderer.send('updateAppIndicator', {
@@ -379,8 +377,8 @@ export default class AppStore extends Store {
         debug('disabling launch on startup');
         autoLauncher.disable();
       }
-    } catch (err) {
-      console.warn(err);
+    } catch (error) {
+      console.warn(error);
     }
   }
 
@@ -438,7 +436,7 @@ export default class AppStore extends Store {
     const allServiceIds = await getServiceIdsFromPartitions();
     const allOrphanedServiceIds = allServiceIds.filter(
       id =>
-        !this.stores.services.all.find(
+        !this.stores.services.all.some(
           s => id.replace('service-', '') === s.id,
         ),
     );
@@ -447,8 +445,8 @@ export default class AppStore extends Store {
       await Promise.all(
         allOrphanedServiceIds.map(id => removeServicePartitionDirectory(id)),
       );
-    } catch (ex) {
-      console.log('Error while deleting service partition directory - ', ex);
+    } catch (error) {
+      console.log('Error while deleting service partition directory -', error);
     }
     await Promise.all(
       this.stores.services.all.map(s =>