diff options
author | MCMXC <16797721+mcmxcdev@users.noreply.github.com> | 2023-07-30 10:55:59 -0600 |
---|---|---|
committer | Vijay Aravamudhan <vraravam@users.noreply.github.com> | 2023-07-30 23:57:51 +0000 |
commit | 080d8b05297f3f5afcf33354a40a5201697b1df5 (patch) | |
tree | 35180bd3cb9fcd137feca3fe169032cbbb469463 /src/internal-server | |
parent | refactor: various improvements (#1296) (diff) | |
download | ferdium-app-080d8b05297f3f5afcf33354a40a5201697b1df5.tar.gz ferdium-app-080d8b05297f3f5afcf33354a40a5201697b1df5.tar.zst ferdium-app-080d8b05297f3f5afcf33354a40a5201697b1df5.zip |
refactor: more lint improvements
- set parserOptions.ecmaVersion to latest and env to es2024 in eslint config
- install missing types libraries
- install eslint-plugin-sonar
- enable eslint-plugin-sonar recommended rules and declare jsx-runtime for react in eslint config
- clean up disabled lint rules which don't inflict problems anymore
- disable various lint issues and fix others
Diffstat (limited to 'src/internal-server')
-rw-r--r-- | src/internal-server/app/Controllers/Http/ImageController.js | 2 | ||||
-rw-r--r-- | src/internal-server/app/Controllers/Http/UserController.js | 8 | ||||
-rw-r--r-- | src/internal-server/app/Controllers/Http/WorkspaceController.js | 7 | ||||
-rw-r--r-- | src/internal-server/app/ImageHelper.js | 2 | ||||
-rw-r--r-- | src/internal-server/database/factory.js | 1 | ||||
-rw-r--r-- | src/internal-server/start.ts | 2 | ||||
-rw-r--r-- | src/internal-server/start/routes.js | 2 | ||||
-rw-r--r-- | src/internal-server/test.ts | 2 |
8 files changed, 9 insertions, 17 deletions
diff --git a/src/internal-server/app/Controllers/Http/ImageController.js b/src/internal-server/app/Controllers/Http/ImageController.js index 5b8337c49..3ce6fb22d 100644 --- a/src/internal-server/app/Controllers/Http/ImageController.js +++ b/src/internal-server/app/Controllers/Http/ImageController.js | |||
@@ -1,6 +1,6 @@ | |||
1 | const Env = use('Env'); | 1 | const Env = use('Env'); |
2 | 2 | ||
3 | const path = require('path'); | 3 | const path = require('node:path'); |
4 | const fs = require('fs-extra'); | 4 | const fs = require('fs-extra'); |
5 | const sanitize = require('sanitize-filename'); | 5 | const sanitize = require('sanitize-filename'); |
6 | 6 | ||
diff --git a/src/internal-server/app/Controllers/Http/UserController.js b/src/internal-server/app/Controllers/Http/UserController.js index 43d925119..943d7705e 100644 --- a/src/internal-server/app/Controllers/Http/UserController.js +++ b/src/internal-server/app/Controllers/Http/UserController.js | |||
@@ -6,7 +6,7 @@ const { validateAll } = use('Validator'); | |||
6 | 6 | ||
7 | const fetch = require('node-fetch'); | 7 | const fetch = require('node-fetch'); |
8 | const { v4: uuid } = require('uuid'); | 8 | const { v4: uuid } = require('uuid'); |
9 | const crypto = require('crypto'); | 9 | const crypto = require('node:crypto'); |
10 | const { DEFAULT_APP_SETTINGS } = require('../../../../config'); | 10 | const { DEFAULT_APP_SETTINGS } = require('../../../../config'); |
11 | const { convertToJSON } = require('../../../../jsUtils'); | 11 | const { convertToJSON } = require('../../../../jsUtils'); |
12 | const { API_VERSION } = require('../../../../environment-remote'); | 12 | const { API_VERSION } = require('../../../../environment-remote'); |
@@ -224,11 +224,7 @@ class UserController { | |||
224 | } | 224 | } |
225 | 225 | ||
226 | // Account import/export | 226 | // Account import/export |
227 | async export({ | 227 | async export({ _auth, response }) { |
228 | // eslint-disable-next-line no-unused-vars | ||
229 | auth, | ||
230 | response, | ||
231 | }) { | ||
232 | const allServices = await Service.all(); | 228 | const allServices = await Service.all(); |
233 | const services = allServices.toJSON(); | 229 | const services = allServices.toJSON(); |
234 | const allWorkspaces = await Workspace.all(); | 230 | const allWorkspaces = await Workspace.all(); |
diff --git a/src/internal-server/app/Controllers/Http/WorkspaceController.js b/src/internal-server/app/Controllers/Http/WorkspaceController.js index 352589567..d271dac12 100644 --- a/src/internal-server/app/Controllers/Http/WorkspaceController.js +++ b/src/internal-server/app/Controllers/Http/WorkspaceController.js | |||
@@ -92,12 +92,7 @@ class WorkspaceController { | |||
92 | }); | 92 | }); |
93 | } | 93 | } |
94 | 94 | ||
95 | async delete({ | 95 | async delete({ response, params }) { |
96 | // eslint-disable-next-line no-unused-vars | ||
97 | request, | ||
98 | response, | ||
99 | params, | ||
100 | }) { | ||
101 | // Validate user input | 96 | // Validate user input |
102 | const validation = await validateAll(params, { | 97 | const validation = await validateAll(params, { |
103 | id: 'required', | 98 | id: 'required', |
diff --git a/src/internal-server/app/ImageHelper.js b/src/internal-server/app/ImageHelper.js index fba610069..b24a97836 100644 --- a/src/internal-server/app/ImageHelper.js +++ b/src/internal-server/app/ImageHelper.js | |||
@@ -2,7 +2,7 @@ const Env = use('Env'); | |||
2 | 2 | ||
3 | const { v4: uuid } = require('uuid'); | 3 | const { v4: uuid } = require('uuid'); |
4 | 4 | ||
5 | const path = require('path'); | 5 | const path = require('node:path'); |
6 | const fs = require('fs-extra'); | 6 | const fs = require('fs-extra'); |
7 | const { API_VERSION } = require('../../environment-remote'); | 7 | const { API_VERSION } = require('../../environment-remote'); |
8 | 8 | ||
diff --git a/src/internal-server/database/factory.js b/src/internal-server/database/factory.js index 8534fc20a..8cd45a80d 100644 --- a/src/internal-server/database/factory.js +++ b/src/internal-server/database/factory.js | |||
@@ -1,3 +1,4 @@ | |||
1 | /* eslint-disable unicorn/no-empty-file */ | ||
1 | /* | 2 | /* |
2 | |-------------------------------------------------------------------------- | 3 | |-------------------------------------------------------------------------- |
3 | | Factory | 4 | | Factory |
diff --git a/src/internal-server/start.ts b/src/internal-server/start.ts index f5e1953e7..b6ee65986 100644 --- a/src/internal-server/start.ts +++ b/src/internal-server/start.ts | |||
@@ -18,7 +18,7 @@ | |||
18 | import fold from '@adonisjs/fold'; | 18 | import fold from '@adonisjs/fold'; |
19 | import { Ignitor, hooks } from '@adonisjs/ignitor'; | 19 | import { Ignitor, hooks } from '@adonisjs/ignitor'; |
20 | import { readFile, stat, chmod, writeFile } from 'fs-extra'; | 20 | import { readFile, stat, chmod, writeFile } from 'fs-extra'; |
21 | import { join } from 'path'; | 21 | import { join } from 'node:path'; |
22 | import { LOCAL_HOSTNAME } from '../config'; | 22 | import { LOCAL_HOSTNAME } from '../config'; |
23 | import { isWindows } from '../environment'; | 23 | import { isWindows } from '../environment'; |
24 | 24 | ||
diff --git a/src/internal-server/start/routes.js b/src/internal-server/start/routes.js index 8aca39347..2dbd0713e 100644 --- a/src/internal-server/start/routes.js +++ b/src/internal-server/start/routes.js | |||
@@ -5,7 +5,7 @@ | |||
5 | | | 5 | | |
6 | */ | 6 | */ |
7 | 7 | ||
8 | const { timingSafeEqual } = require('crypto'); | 8 | const { timingSafeEqual } = require('node:crypto'); |
9 | 9 | ||
10 | /** @type {typeof import('@adonisjs/framework/src/Route/Manager')} */ | 10 | /** @type {typeof import('@adonisjs/framework/src/Route/Manager')} */ |
11 | const Route = use('Route'); | 11 | const Route = use('Route'); |
diff --git a/src/internal-server/test.ts b/src/internal-server/test.ts index 6949df79e..c163656fb 100644 --- a/src/internal-server/test.ts +++ b/src/internal-server/test.ts | |||
@@ -1,4 +1,4 @@ | |||
1 | import { join } from 'path'; | 1 | import { join } from 'node:path'; |
2 | import { ensureDirSync } from 'fs-extra'; | 2 | import { ensureDirSync } from 'fs-extra'; |
3 | import { server } from './start'; | 3 | import { server } from './start'; |
4 | 4 | ||