Initial plumbing and conversion of a simple javascript to typescript (#1790)

* initial conversion of a simple script
* Moved some of the 'gulp' and related npm modules from being runtime dependencies to development dependencies.

1 files changed, 4 insertions, 4 deletions

diff --git a/src/helpers/url-helpers.js b/src/helpers/url-helpers.ts
index b0dc9afbb..23e8fab29 100644
--- a/src/helpers/url-helpers.js
+++ b/src/helpers/url-helpers.ts
@@ -8,8 +8,8 @@ import { ALLOWED_PROTOCOLS } from '../config';
 
 const debug = require('debug')('Ferdi:Helpers:url');
 
-export function isValidExternalURL(url) {
-  let parsedUrl;
+export function isValidExternalURL(url: string) {
+  let parsedUrl: URL;
   try {
     parsedUrl = new URL(url);
   } catch (_) {
@@ -23,13 +23,13 @@ export function isValidExternalURL(url) {
   return isAllowed;
 }
 
-export async function openPath(folderName) {
+export async function openPath(folderName: string) {
   ensureDirSync(folderName);
   shell.openPath(folderName);
 }
 
 // TODO: Need to verify and fix/remove the skipping logic. Ideally, we should never skip this check
-export function openExternalUrl(url, skipValidityCheck = false) {
+export function openExternalUrl(url: string, skipValidityCheck: boolean = false) {
   if (skipValidityCheck || isValidExternalURL(url)) {
     shell.openExternal(url);
   }