aboutsummaryrefslogtreecommitdiffstats
path: root/src/features
diff options
context:
space:
mode:
authorLibravatar MCMXC <16797721+mcmxcdev@users.noreply.github.com>2023-07-23 20:08:52 -0600
committerLibravatar Vijay Aravamudhan <vraravam@users.noreply.github.com>2023-07-25 07:45:23 +0000
commit8c131073730ec684145c2cc8ee8d6b39bbe9278d (patch)
tree1129d432ae88475909f0e5d38960395b75364902 /src/features
parent6.4.1-nightly.11 [skip ci] (diff)
downloadferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.gz
ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.tar.zst
ferdium-app-8c131073730ec684145c2cc8ee8d6b39bbe9278d.zip
chore: improve lint setup
- update eslint config - merged eslint rules for JS and TS to avoid duplicates - extended stricter lint ruleset from typescript-eslint - corrected wrong setup for certain eslint rulesets - opt in to reportUnusedDisableDirectives config option - fix or disable a lot of lint issues throughout codebase - remove trailingComma: all from prettier config which is default in prettier v3 - add volta configuration to package.json to autoload correct node and pnpm versions - upgrade all eslint and prettier related dependencies to latest - remove config options from settings.json which are default anyways - remove config options from settings.json which are outdated/unknown - set up prettier as default formatter in settings.json
Diffstat (limited to 'src/features')
-rw-r--r--src/features/serviceProxy/index.ts6
-rw-r--r--src/features/workspaces/components/WorkspaceDrawer.tsx5
-rw-r--r--src/features/workspaces/components/WorkspaceDrawerItem.tsx1
-rw-r--r--src/features/workspaces/components/WorkspacesDashboard.tsx1
-rw-r--r--src/features/workspaces/store.ts1
5 files changed, 6 insertions, 8 deletions
diff --git a/src/features/serviceProxy/index.ts b/src/features/serviceProxy/index.ts
index eb3b89ece..c98ae00a7 100644
--- a/src/features/serviceProxy/index.ts
+++ b/src/features/serviceProxy/index.ts
@@ -33,11 +33,7 @@ export default function init(stores: {
33 if (config.isEnabled) { 33 if (config.isEnabled) {
34 const serviceProxyConfig = proxySettings[service.id]; 34 const serviceProxyConfig = proxySettings[service.id];
35 35
36 if ( 36 if (serviceProxyConfig?.isEnabled && serviceProxyConfig.host) {
37 serviceProxyConfig &&
38 serviceProxyConfig.isEnabled &&
39 serviceProxyConfig.host
40 ) {
41 const proxyHost = `${serviceProxyConfig.host}${ 37 const proxyHost = `${serviceProxyConfig.host}${
42 serviceProxyConfig.port ? `:${serviceProxyConfig.port}` : '' 38 serviceProxyConfig.port ? `:${serviceProxyConfig.port}` : ''
43 }`; 39 }`;
diff --git a/src/features/workspaces/components/WorkspaceDrawer.tsx b/src/features/workspaces/components/WorkspaceDrawer.tsx
index 1c827e9dd..3e05cb7de 100644
--- a/src/features/workspaces/components/WorkspaceDrawer.tsx
+++ b/src/features/workspaces/components/WorkspaceDrawer.tsx
@@ -98,6 +98,7 @@ class WorkspaceDrawer extends Component<IProps> {
98 try { 98 try {
99 getUserWorkspacesRequest.execute(); 99 getUserWorkspacesRequest.execute();
100 } catch (error) { 100 } catch (error) {
101 // eslint-disable-next-line no-console
101 console.log(error); 102 console.log(error);
102 } 103 }
103 } 104 }
@@ -121,9 +122,9 @@ class WorkspaceDrawer extends Component<IProps> {
121 workspaceActions.openWorkspaceSettings(); 122 workspaceActions.openWorkspaceSettings();
122 }} 123 }}
123 data-tooltip-id="tooltip-workspaces-drawer" 124 data-tooltip-id="tooltip-workspaces-drawer"
124 data-tooltip-content={`${intl.formatMessage( 125 data-tooltip-content={intl.formatMessage(
125 messages.workspacesSettingsTooltip, 126 messages.workspacesSettingsTooltip,
126 )}`} 127 )}
127 > 128 >
128 <Icon 129 <Icon
129 icon={mdiCog} 130 icon={mdiCog}
diff --git a/src/features/workspaces/components/WorkspaceDrawerItem.tsx b/src/features/workspaces/components/WorkspaceDrawerItem.tsx
index 172b4192c..4fd7662f5 100644
--- a/src/features/workspaces/components/WorkspaceDrawerItem.tsx
+++ b/src/features/workspaces/components/WorkspaceDrawerItem.tsx
@@ -72,6 +72,7 @@ interface IProps extends WithStylesProps<typeof styles>, WrappedComponentProps {
72 name: string; 72 name: string;
73 onClick: MouseEventHandler<HTMLInputElement>; 73 onClick: MouseEventHandler<HTMLInputElement>;
74 services: string[]; 74 services: string[];
75 // eslint-disable-next-line @typescript-eslint/no-invalid-void-type
75 onContextMenuEditClick?: () => void | null; 76 onContextMenuEditClick?: () => void | null;
76 shortcutIndex: number; 77 shortcutIndex: number;
77} 78}
diff --git a/src/features/workspaces/components/WorkspacesDashboard.tsx b/src/features/workspaces/components/WorkspacesDashboard.tsx
index c5f8909c1..a823132c5 100644
--- a/src/features/workspaces/components/WorkspacesDashboard.tsx
+++ b/src/features/workspaces/components/WorkspacesDashboard.tsx
@@ -1,4 +1,3 @@
1/* eslint-disable react/jsx-no-useless-fragment */
2import { Component, ReactElement } from 'react'; 1import { Component, ReactElement } from 'react';
3import { observer } from 'mobx-react'; 2import { observer } from 'mobx-react';
4import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl'; 3import { defineMessages, injectIntl, WrappedComponentProps } from 'react-intl';
diff --git a/src/features/workspaces/store.ts b/src/features/workspaces/store.ts
index 53e3b62ed..34a4126c8 100644
--- a/src/features/workspaces/store.ts
+++ b/src/features/workspaces/store.ts
@@ -64,6 +64,7 @@ export default class WorkspacesStore extends FeatureStore {
64 return getUserWorkspacesRequest.wasExecuted && this.workspaces.length > 0; 64 return getUserWorkspacesRequest.wasExecuted && this.workspaces.length > 0;
65 } 65 }
66 66
67 // eslint-disable-next-line @typescript-eslint/class-literal-property-style
67 @computed get isUserAllowedToUseFeature() { 68 @computed get isUserAllowedToUseFeature() {
68 return true; 69 return true;
69 } 70 }