diff options
author | Kristóf Marussy <kristof@marussy.com> | 2022-04-23 01:59:21 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-04-22 23:59:21 +0000 |
commit | d02644f7c41150709795e57bfd40351b4da35a7b (patch) | |
tree | 2403fb76bd5fae1703f8b55172ffce9e0a5d2bce /src/features/communityRecipes | |
parent | Complete tray icons redesign for all platforms (#28) (diff) | |
download | ferdium-app-d02644f7c41150709795e57bfd40351b4da35a7b.tar.gz ferdium-app-d02644f7c41150709795e57bfd40351b4da35a7b.tar.zst ferdium-app-d02644f7c41150709795e57bfd40351b4da35a7b.zip |
Preload safe debug shim (#29)
In https://github.com/ferdium/ferdium-app/pull/23 we removed usages of
the debug package due to an electron bug.
This patch aims to restore some debug functionality by introducing a
shim. The shim detect whether if it is being introduced in a preload
script where the electron but would be triggered, and falls back to a
simple replacement for debug. However, in the main and renderer
processes, where a preload script is not being used, we still get full
debug functionality.
In this way, a module can be used both in a preload script and outside
of it, while still preserving debug functionality whenever possible.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
Diffstat (limited to 'src/features/communityRecipes')
-rw-r--r-- | src/features/communityRecipes/store.ts | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/src/features/communityRecipes/store.ts b/src/features/communityRecipes/store.ts index afd7d0f01..73eaae8b4 100644 --- a/src/features/communityRecipes/store.ts +++ b/src/features/communityRecipes/store.ts | |||
@@ -1,8 +1,7 @@ | |||
1 | import { computed } from 'mobx'; | 1 | import { computed } from 'mobx'; |
2 | import { FeatureStore } from '../utils/FeatureStore'; | 2 | import { FeatureStore } from '../utils/FeatureStore'; |
3 | 3 | ||
4 | // TODO: Go back to 'debug' from 'console.log' when https://github.com/electron/electron/issues/31689 is fixed | 4 | const debug = require('../../preload-safe-debug')('Ferdium:feature:communityRecipes:store'); |
5 | // const debug = require('debug')('Ferdium:feature:communityRecipes:store'); | ||
6 | 5 | ||
7 | export class CommunityRecipesStore extends FeatureStore { | 6 | export class CommunityRecipesStore extends FeatureStore { |
8 | stores: any; | 7 | stores: any; |
@@ -10,13 +9,13 @@ export class CommunityRecipesStore extends FeatureStore { | |||
10 | actions: any; | 9 | actions: any; |
11 | 10 | ||
12 | start(stores: any, actions: any) { | 11 | start(stores: any, actions: any) { |
13 | console.log('start'); | 12 | debug('start'); |
14 | this.stores = stores; | 13 | this.stores = stores; |
15 | this.actions = actions; | 14 | this.actions = actions; |
16 | } | 15 | } |
17 | 16 | ||
18 | stop() { | 17 | stop() { |
19 | console.log('stop'); | 18 | debug('stop'); |
20 | super.stop(); | 19 | super.stop(); |
21 | } | 20 | } |
22 | 21 | ||