From d02644f7c41150709795e57bfd40351b4da35a7b Mon Sep 17 00:00:00 2001 From: Kristóf Marussy Date: Sat, 23 Apr 2022 01:59:21 +0200 Subject: Preload safe debug shim (#29) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In https://github.com/ferdium/ferdium-app/pull/23 we removed usages of the debug package due to an electron bug. This patch aims to restore some debug functionality by introducing a shim. The shim detect whether if it is being introduced in a preload script where the electron but would be triggered, and falls back to a simple replacement for debug. However, in the main and renderer processes, where a preload script is not being used, we still get full debug functionality. In this way, a module can be used both in a preload script and outside of it, while still preserving debug functionality whenever possible. Signed-off-by: Kristóf Marussy --- src/features/communityRecipes/store.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/features/communityRecipes') diff --git a/src/features/communityRecipes/store.ts b/src/features/communityRecipes/store.ts index afd7d0f01..73eaae8b4 100644 --- a/src/features/communityRecipes/store.ts +++ b/src/features/communityRecipes/store.ts @@ -1,8 +1,7 @@ import { computed } from 'mobx'; import { FeatureStore } from '../utils/FeatureStore'; -// TODO: Go back to 'debug' from 'console.log' when https://github.com/electron/electron/issues/31689 is fixed -// const debug = require('debug')('Ferdium:feature:communityRecipes:store'); +const debug = require('../../preload-safe-debug')('Ferdium:feature:communityRecipes:store'); export class CommunityRecipesStore extends FeatureStore { stores: any; @@ -10,13 +9,13 @@ export class CommunityRecipesStore extends FeatureStore { actions: any; start(stores: any, actions: any) { - console.log('start'); + debug('start'); this.stores = stores; this.actions = actions; } stop() { - console.log('stop'); + debug('stop'); super.stop(); } -- cgit v1.2.3-54-g00ecf