Fix active Todos service behaviour (#1481)

* Return false instead of null in isTodosServiceAdded

* Resolve from TODOS_RECIPES_ID instead of hardcoded TODOS_RECIPE_ID

* Fix TodosWebview width toggling when isTodosServiceActive

* Add more todo service recipe IDs

* Refactor todos state management

* Moved todos service URL and recipe ID computation logic to todos/store
* Simplified TodosWebview by delegating to the store for the URL and
  removing the (unused) payment logic
* Made the todos service computation logic in the Service model depend
  on the logic in todos/store
* Made ServicesStore depend on the todos service logic from the Service
  model

* Todos appearance fixes

* Hide double horizontal rules if todo settings are hidden due to an
  added todo service
* Hide todos panel border when the panel is hidden or expanded
* Make expanded todos panel obey sidebar width and vertical style
  settings

* Make todos/store use isValidExternalURL

* Harden isValidExternalURL against malformed URLs

* Reduce todo URL string duplication in config.js

Co-authored-by: Kristóf Marussy <kristof@marussy.com>

1 files changed, 9 insertions, 2 deletions

diff --git a/src/features/appearance/index.js b/src/features/appearance/index.js
index 82a0971eb..b5648250e 100644
--- a/src/features/appearance/index.js
+++ b/src/features/appearance/index.js
@@ -93,10 +93,10 @@ function generateServiceRibbonWidthStyle(widthStr, iconSizeStr, vertical) {
     }
   ` : `
     .sidebar {
-      width: ${width - 2}px !important;
+      width: ${width}px !important;
     }
     .tab-item {
-      width: ${width - 2}px !important;
+      width: ${width}px !important;
       height: ${width - 5 + iconSize}px !important;
     }
     .tab-item .tab-item__icon {
@@ -105,6 +105,9 @@ function generateServiceRibbonWidthStyle(widthStr, iconSizeStr, vertical) {
     .sidebar__button {
       font-size: ${width / 3}px !important;
     }
+    .todos__todos-panel--expanded {
+      width: calc(100% - ${300 + width}px) !important;
+    }
   `;
 }
 
@@ -156,6 +159,10 @@ function generateVerticalStyle(widthStr, alwaysShowWorkspaces) {
   .workspaces-drawer {
     maring-top: -${sidebarWidthStr} !important;
   }
+
+  .todos__todos-panel--expanded {
+    width: calc(100% - 300px) !important;
+  }
   `;
 }