diff options
author | Vijay A <vraravam@users.noreply.github.com> | 2023-05-28 13:48:21 +0530 |
---|---|---|
committer | Vijay A <vraravam@users.noreply.github.com> | 2023-05-28 13:48:21 +0530 |
commit | 99ca310c73024b51fed1f3077375eed7827f2c20 (patch) | |
tree | 2bd15986f448129a2291acba90ccc6bf68a233e0 /src/containers | |
parent | Disable in-app auto-updates for portable windows installation (fixes #1088) (... (diff) | |
download | ferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.tar.gz ferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.tar.zst ferdium-app-99ca310c73024b51fed1f3077375eed7827f2c20.zip |
Fix issues reported by sonarqube linter
Diffstat (limited to 'src/containers')
-rw-r--r-- | src/containers/auth/SetupAssistantScreen.tsx | 2 | ||||
-rw-r--r-- | src/containers/layout/AppLayoutContainer.tsx | 4 | ||||
-rw-r--r-- | src/containers/settings/EditServiceScreen.tsx | 6 | ||||
-rw-r--r-- | src/containers/settings/ServicesScreen.tsx | 8 |
4 files changed, 10 insertions, 10 deletions
diff --git a/src/containers/auth/SetupAssistantScreen.tsx b/src/containers/auth/SetupAssistantScreen.tsx index 0d4c3feec..1a20ab002 100644 --- a/src/containers/auth/SetupAssistantScreen.tsx +++ b/src/containers/auth/SetupAssistantScreen.tsx | |||
@@ -96,7 +96,7 @@ class SetupAssistantScreen extends Component<IProps, IState> { | |||
96 | <SetupAssistant | 96 | <SetupAssistant |
97 | onSubmit={config => this.setupServices(config)} | 97 | onSubmit={config => this.setupServices(config)} |
98 | services={this.services} | 98 | services={this.services} |
99 | // embed={false} // TODO - [TS DEBT][PROP NOT USED IN COMPONENT] check legacy services type | 99 | // embed={false} // TODO: [TS DEBT][PROP NOT USED IN COMPONENT] check legacy services type |
100 | isSettingUpServices={this.state.isSettingUpServices} | 100 | isSettingUpServices={this.state.isSettingUpServices} |
101 | /> | 101 | /> |
102 | ); | 102 | ); |
diff --git a/src/containers/layout/AppLayoutContainer.tsx b/src/containers/layout/AppLayoutContainer.tsx index 1cffc7ad1..1929492ff 100644 --- a/src/containers/layout/AppLayoutContainer.tsx +++ b/src/containers/layout/AppLayoutContainer.tsx | |||
@@ -120,10 +120,10 @@ class AppLayoutContainer extends Component<IProps> { | |||
120 | const servicesContainer = ( | 120 | const servicesContainer = ( |
121 | <Services | 121 | <Services |
122 | services={services.allDisplayedUnordered} | 122 | services={services.allDisplayedUnordered} |
123 | // handleIPCMessage={handleIPCMessage} // TODO - - [TECH DEBT] check it later | 123 | // handleIPCMessage={handleIPCMessage} // TODO: [TECH DEBT] check it later |
124 | setWebviewReference={setWebviewReference} | 124 | setWebviewReference={setWebviewReference} |
125 | detachService={detachService} | 125 | detachService={detachService} |
126 | // openWindow={openWindow} // TODO - - [TECH DEBT] check it later | 126 | // openWindow={openWindow} // TODO: [TECH DEBT] check it later |
127 | reload={reload} | 127 | reload={reload} |
128 | openSettings={openSettings} | 128 | openSettings={openSettings} |
129 | update={updateService} | 129 | update={updateService} |
diff --git a/src/containers/settings/EditServiceScreen.tsx b/src/containers/settings/EditServiceScreen.tsx index 3b9d3ee43..ff2076fed 100644 --- a/src/containers/settings/EditServiceScreen.tsx +++ b/src/containers/settings/EditServiceScreen.tsx | |||
@@ -391,7 +391,7 @@ class EditServiceScreen extends Component<IProps> { | |||
391 | if (proxy.isEnabled) { | 391 | if (proxy.isEnabled) { |
392 | const serviceProxyConfig: IProxyConfig = service | 392 | const serviceProxyConfig: IProxyConfig = service |
393 | ? /* | 393 | ? /* |
394 | TODO - [TS DEBT] find out why sometimes proxy[service.id] gives undefined | 394 | TODO: [TS DEBT] find out why sometimes proxy[service.id] gives undefined |
395 | Note in proxy service id exist as key but value is undefined rather that proxy empty object | 395 | Note in proxy service id exist as key but value is undefined rather that proxy empty object |
396 | 396 | ||
397 | Temp fix - or-ed {} (to stores.settings.proxy[service.id] ) to avoid undefined proxy in settingStore throw error | 397 | Temp fix - or-ed {} (to stores.settings.proxy[service.id] ) to avoid undefined proxy in settingStore throw error |
@@ -534,9 +534,9 @@ class EditServiceScreen extends Component<IProps> { | |||
534 | action={action} | 534 | action={action} |
535 | recipe={recipe} | 535 | recipe={recipe} |
536 | service={service} | 536 | service={service} |
537 | // user={user.data} // TODO - [TS DEBT] Need to check why its passed as its not used inside EditServiceForm | 537 | // user={user.data} // TODO: [TS DEBT] Need to check why its passed as its not used inside EditServiceForm |
538 | form={form} | 538 | form={form} |
539 | // status={services.actionStatus} // TODO - [TS DEBT] Need to check why its passed as its not used inside EditServiceForm | 539 | // status={services.actionStatus} // TODO: [TS DEBT] Need to check why its passed as its not used inside EditServiceForm |
540 | isSaving={ | 540 | isSaving={ |
541 | services.updateServiceRequest.isExecuting || | 541 | services.updateServiceRequest.isExecuting || |
542 | services.createServiceRequest.isExecuting | 542 | services.createServiceRequest.isExecuting |
diff --git a/src/containers/settings/ServicesScreen.tsx b/src/containers/settings/ServicesScreen.tsx index 70eeffed4..6b648f038 100644 --- a/src/containers/settings/ServicesScreen.tsx +++ b/src/containers/settings/ServicesScreen.tsx | |||
@@ -14,7 +14,7 @@ class ServicesScreen extends Component<IProps> { | |||
14 | this.props.actions.service.resetStatus(); | 14 | this.props.actions.service.resetStatus(); |
15 | } | 15 | } |
16 | 16 | ||
17 | // TODO - [TECH DEBT] need to check it | 17 | // TODO: [TECH DEBT] need to check it |
18 | // deleteService(): void { | 18 | // deleteService(): void { |
19 | // this.props.actions.service.deleteService(); | 19 | // this.props.actions.service.deleteService(); |
20 | // this.props.actions.service.resetFilter(); | 20 | // this.props.actions.service.resetFilter(); |
@@ -38,11 +38,11 @@ class ServicesScreen extends Component<IProps> { | |||
38 | return ( | 38 | return ( |
39 | <ErrorBoundary> | 39 | <ErrorBoundary> |
40 | <ServicesDashboard | 40 | <ServicesDashboard |
41 | // user={user.data} // TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it later | 41 | // user={user.data} // TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it later |
42 | services={allServices} | 42 | services={allServices} |
43 | status={services.actionStatus} | 43 | status={services.actionStatus} |
44 | // deleteService={() => this.deleteService()} // TODO - [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it later | 44 | // deleteService={() => this.deleteService()} // TODO: [TECH DEBT][PROPS NOT EXIST IN COMPONENT] check it later |
45 | // toggleService={toggleService} // TODO - [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later | 45 | // toggleService={toggleService} // TODO: [TECH DEBT][PROPS NOT USED IN COMPONENT] check it later |
46 | isLoading={isLoading} | 46 | isLoading={isLoading} |
47 | filterServices={filter} | 47 | filterServices={filter} |
48 | resetFilter={resetFilter} | 48 | resetFilter={resetFilter} |