refactor: various improvements (#1296)

* refactor: various improvements

- enable no-use-before-define eslint rule
- shuffle code to conform to no-use-before-define eslint rule
- remove btoa dependency which is deprecated and replace with Buffer.from(string).toString('base64')
- convert some any types into useful ones
- add type annotations where possible
- remove unused @types/expect.js
- install @types/semver and ts-node which were missing
- repair and rewrite add-crowdin-contributors script
- remove export keyword from variables which are never consumed in another file
- remove unity indicator hack where linked issue was closed
- remove module declaration for kebab-case which is unused
- add missing state interface for certain components
- remove default exports for files which already have a named export
- export IRecipePreview so it can be used throughout codebase
- remove unused removeCacheForCallWith method from CachedRequest.ts
- cleanup unused colors and styles inside legacy theme

* - improve ColorPickerInput
- fix invalid DOM nesting with div inside p in EditSettingsForm
- fix progressbarAccentColor color picker not updating input when using slider
- install missing @types/react-color dependency

3 files changed, 23 insertions, 12 deletions

diff --git a/src/containers/auth/AuthReleaseNotesScreen.tsx b/src/containers/auth/AuthReleaseNotesScreen.tsx
index c717529fa..c9d2286e1 100644
--- a/src/containers/auth/AuthReleaseNotesScreen.tsx
+++ b/src/containers/auth/AuthReleaseNotesScreen.tsx
@@ -1,7 +1,7 @@
 import { Component } from 'react';
 import { inject, observer } from 'mobx-react';
 
-import { defineMessages, injectIntl } from 'react-intl';
+import { IntlShape, defineMessages, injectIntl } from 'react-intl';
 import Markdown from 'markdown-to-jsx';
 import { mdiArrowLeftCircle } from '@mdi/js';
 import { openExternalUrl } from '../../helpers/url-helpers';
@@ -20,14 +20,14 @@ const messages = defineMessages({
 });
 
 interface IProps {
-  intl: any;
+  intl: IntlShape;
 }
 
-class AuthReleaseNotesScreen extends Component<IProps> {
-  state = {
-    data: '',
-  };
+interface IState {
+  data: string;
+}
 
+class AuthReleaseNotesScreen extends Component<IProps, IState> {
   constructor(props) {
     super(props);
 
diff --git a/src/containers/settings/EditSettingsScreen.tsx b/src/containers/settings/EditSettingsScreen.tsx
index 7cdff7fde..b9732ead0 100644
--- a/src/containers/settings/EditSettingsScreen.tsx
+++ b/src/containers/settings/EditSettingsScreen.tsx
@@ -319,12 +319,23 @@ const messages = defineMessages({
 
 interface EditSettingsScreenProps extends StoresProps, WrappedComponentProps {}
 
+interface EditSettingsScreenState {
+  lockedPassword: string;
+}
+
 @inject('stores', 'actions')
 @observer
-class EditSettingsScreen extends Component<EditSettingsScreenProps> {
-  state = {
-    lockedPassword: '',
-  };
+class EditSettingsScreen extends Component<
+  EditSettingsScreenProps,
+  EditSettingsScreenState
+> {
+  constructor(props) {
+    super(props);
+
+    this.state = {
+      lockedPassword: '',
+    };
+  }
 
   onSubmit(settingsData) {
     const { todos, workspaces } = this.props.stores;
diff --git a/src/containers/settings/EditUserScreen.tsx b/src/containers/settings/EditUserScreen.tsx
index 10c308524..62df170fc 100644
--- a/src/containers/settings/EditUserScreen.tsx
+++ b/src/containers/settings/EditUserScreen.tsx
@@ -1,6 +1,6 @@
 import { Component, ReactElement } from 'react';
 import { inject, observer } from 'mobx-react';
-import { defineMessages, injectIntl } from 'react-intl';
+import { IntlShape, defineMessages, injectIntl } from 'react-intl';
 
 import { StoresProps } from '../../@types/ferdium-components.types';
 import { FormFields } from '../../@types/mobx-form.types';
@@ -50,7 +50,7 @@ const messages = defineMessages({
 });
 
 interface EditUserScreenProps extends StoresProps {
-  intl: any;
+  intl: IntlShape;
 }
 
 class EditUserScreen extends Component<EditUserScreenProps> {