refactor: bring down eslint warnings to zero (#1714)

- install `@eslint-react/eslint-plugin` dependency
- configure `@eslint-react/eslint-plugin` in eslint config
- modernize `lint` command in `package.json`
- disable or fix various reported lint issues
- fix `div` being nested in `p` for settings
- replace deprecated `event.keyCode` with `event.key`
- update isEscKeyPress method and unit tests which used deprecated `event.keyCode`
- allow `eslint` v8 as peer dependency for `@eslint-react/eslint-plugin`

1 files changed, 4 insertions, 0 deletions

diff --git a/src/containers/settings/EditServiceScreen.tsx b/src/containers/settings/EditServiceScreen.tsx
index dde69ef2d..f3b9b0857 100644
--- a/src/containers/settings/EditServiceScreen.tsx
+++ b/src/containers/settings/EditServiceScreen.tsx
@@ -141,13 +141,17 @@ class EditServiceScreen extends Component<IProps> {
     const { action } = this.props.params;
     const { recipes, services } = this.props.stores;
     const { createService, updateService } = this.props.actions.service;
+    // eslint-disable-next-line no-param-reassign
     data.darkReaderSettings = {
       brightness: data.darkReaderBrightness,
       contrast: data.darkReaderContrast,
       sepia: data.darkReaderSepia,
     };
+    // eslint-disable-next-line no-param-reassign
     delete data.darkReaderContrast;
+    // eslint-disable-next-line no-param-reassign
     delete data.darkReaderBrightness;
+    // eslint-disable-next-line no-param-reassign
     delete data.darkReaderSepia;
 
     const serviceData = data;