feat: add eslint-plugin-unicorn (#1936)

4 files changed, 41 insertions, 48 deletions

diff --git a/packages/forms/src/button/index.tsx b/packages/forms/src/button/index.tsx
index 48fb61635..c9ae47d55 100644
--- a/packages/forms/src/button/index.tsx
+++ b/packages/forms/src/button/index.tsx
@@ -227,44 +227,38 @@ class ButtonComponent extends Component<IProps> {
       </>
     );
 
-    let wrapperComponent: JSX.Element;
-
-    if (!href) {
-      wrapperComponent = (
-        <button
-          id={id}
-          type={type}
-          onClick={onClick}
-          className={classnames({
-            [`${classes.button}`]: true,
-            [`${classes[buttonType as ButtonType]}`]: true,
-            [`${classes.disabled}`]: disabled,
-            [`${className}`]: className,
-          })}
-          disabled={disabled}
-          data-type="franz-button"
-        >
-          {content}
-        </button>
-      );
-    } else {
-      wrapperComponent = (
-        <a
-          href={href}
-          target={target}
-          onClick={onClick}
-          className={classnames({
-            [`${classes.button}`]: true,
-            [`${classes[buttonType as ButtonType]}`]: true,
-            [`${className}`]: className,
-          })}
-          rel={target === '_blank' ? 'noopener' : ''}
-          data-type="franz-button"
-        >
-          {content}
-        </a>
-      );
-    }
+    const wrapperComponent = !href ? (
+      <button
+        id={id}
+        type={type}
+        onClick={onClick}
+        className={classnames({
+          [`${classes.button}`]: true,
+          [`${classes[buttonType as ButtonType]}`]: true,
+          [`${classes.disabled}`]: disabled,
+          [`${className}`]: className,
+        })}
+        disabled={disabled}
+        data-type="franz-button"
+      >
+        {content}
+      </button>
+    ) : (
+      <a
+        href={href}
+        target={target}
+        onClick={onClick}
+        className={classnames({
+          [`${classes.button}`]: true,
+          [`${classes[buttonType as ButtonType]}`]: true,
+          [`${className}`]: className,
+        })}
+        rel={target === '_blank' ? 'noopener' : ''}
+        data-type="franz-button"
+      >
+        {content}
+      </a>
+    );
 
     return wrapperComponent;
   }
diff --git a/packages/forms/src/input/scorePassword.ts b/packages/forms/src/input/scorePassword.ts
index bc30de4b8..59502e2b0 100644
--- a/packages/forms/src/input/scorePassword.ts
+++ b/packages/forms/src/input/scorePassword.ts
@@ -18,9 +18,9 @@ export function scorePasswordFunc(password: string): number {
 
   // award every unique letter until 5 repetitions
   const letters: ILetters = {};
-  for (let i = 0; i < password.length; i += 1) {
-    letters[password[i]] = (letters[password[i]] || 0) + 1;
-    score += 5.0 / letters[password[i]];
+  for (const element of password) {
+    letters[element] = (letters[element] || 0) + 1;
+    score += 5 / letters[element];
   }
 
   // bonus points for mixing it up
@@ -32,9 +32,9 @@ export function scorePasswordFunc(password: string): number {
   };
 
   let variationCount = 0;
-  Object.keys(variations).forEach(key => {
+  for (const key of Object.keys(variations)) {
     variationCount += variations[key] === true ? 1 : 0;
-  });
+  }
 
   score += (variationCount - 1) * 10;
 
diff --git a/packages/forms/src/select/index.tsx b/packages/forms/src/select/index.tsx
index d7479f63e..7806baa2a 100644
--- a/packages/forms/src/select/index.tsx
+++ b/packages/forms/src/select/index.tsx
@@ -187,10 +187,8 @@ class SelectComponent extends Component<IProps> {
   componentDidUpdate() {
     const { open } = this.state;
 
-    if (this.searchInputRef && this.searchInputRef.current) {
-      if (open) {
-        this.searchInputRef.current.focus();
-      }
+    if (this.searchInputRef && this.searchInputRef.current && open) {
+      this.searchInputRef.current.focus();
     }
   }
 
@@ -228,6 +226,7 @@ class SelectComponent extends Component<IProps> {
   }
 
   componentWillUnmount() {
+    // eslint-disable-next-line unicorn/no-invalid-remove-event-listener
     window.removeEventListener('keydown', this.arrowKeysHandler.bind(this));
   }
 
diff --git a/packages/theme/src/themes/dark/index.ts b/packages/theme/src/themes/dark/index.ts
index 87a68cb5d..aa132c743 100644
--- a/packages/theme/src/themes/dark/index.ts
+++ b/packages/theme/src/themes/dark/index.ts
@@ -9,7 +9,7 @@ export default (brandPrimary: string) => {
   let brandPrimaryColor = color(legacyStyles.themeBrandPrimary);
   try {
     brandPrimaryColor = color(defaultStyles.brandPrimary);
-  } catch (e) {
+  } catch {
     // Ignore invalid color and fall back to default.
   }