refactor: bring down eslint warnings to zero (#1714)

- install `@eslint-react/eslint-plugin` dependency
- configure `@eslint-react/eslint-plugin` in eslint config
- modernize `lint` command in `package.json`
- disable or fix various reported lint issues
- fix `div` being nested in `p` for settings
- replace deprecated `event.keyCode` with `event.key`
- update isEscKeyPress method and unit tests which used deprecated `event.keyCode`
- allow `eslint` v8 as peer dependency for `@eslint-react/eslint-plugin`

1 files changed, 3 insertions, 1 deletions

diff --git a/package.json b/package.json
index 988791a98..f49c636ae 100644
--- a/package.json
+++ b/package.json
@@ -32,7 +32,7 @@
     "test": "jest",
     "test:watch": "jest --watch",
     "typecheck": "tsc --noEmit",
-    "lint": "eslint \"{src,test,scripts}/**/*.{js,jsx,mjs,ts,tsx}\" --quiet",
+    "lint": "eslint . --max-warnings 0",
     "lint:fix": "pnpm lint --cache --fix",
     "biome:check": "pnpm biome check .",
     "biome:check:fix": "pnpm biome:check --apply-unsafe",
@@ -136,6 +136,7 @@
     "@commitlint/cli": "19.2.1",
     "@commitlint/config-conventional": "19.1.0",
     "@electron/notarize": "2.3.0",
+    "@eslint-react/eslint-plugin": "1.5.8",
     "@formatjs/cli": "6.2.9",
     "@jest/types": "29.6.3",
     "@types/auto-launch": "5.0.5",
@@ -201,6 +202,7 @@
       "allowedVersions": {
         "@typescript-eslint/parser": "^7.0.0",
         "esbuild-sass-plugin>esbuild": "^0.16.7",
+        "eslint": "^8.0.0",
         "react-electron-web-view>react": "^18.0.0",
         "react-electron-web-view>react-dom": "^18.0.0",
         "react-sortable-hoc>react": "^18.0.0",