handle deleted services that are attached to workspaces

3 files changed, 27 insertions, 9 deletions

diff --git a/src/containers/layout/AppLayoutContainer.js b/src/containers/layout/AppLayoutContainer.js
index 52d4e0c27..2d855c78f 100644
--- a/src/containers/layout/AppLayoutContainer.js
+++ b/src/containers/layout/AppLayoutContainer.js
@@ -88,7 +88,7 @@ export default @inject('stores', 'actions') @observer class AppLayoutContainer e
     const workspacesDrawer = (
       <WorkspaceDrawer
         getServicesForWorkspace={workspace => (
-          workspace ? workspace.services.map(id => services.one(id).name) : services.all.map(s => s.name)
+          workspace ? workspaceStore.getWorkspaceServices(workspace).map(s => s.name) : services.all.map(s => s.name)
         )}
         onUpgradeAccountClick={() => openSettings({ path: 'user' })}
       />
diff --git a/src/features/workspaces/store.js b/src/features/workspaces/store.js
index ba48022c2..ea601700e 100644
--- a/src/features/workspaces/store.js
+++ b/src/features/workspaces/store.js
@@ -74,6 +74,7 @@ export default class WorkspacesStore extends FeatureStore {
       this._setIsPremiumFeatureReaction,
       this._activateLastUsedWorkspaceReaction,
       this._openDrawerWithSettingsReaction,
+      this._cleanupInvalidServiceReferences,
     ]);
 
     getUserWorkspacesRequest.execute();
@@ -92,16 +93,17 @@ export default class WorkspacesStore extends FeatureStore {
 
   filterServicesByActiveWorkspace = (services) => {
     const { activeWorkspace, isFeatureActive } = this;
-
-    if (!isFeatureActive) return services;
-    if (activeWorkspace) {
-      return services.filter(s => (
-        activeWorkspace.services.includes(s.id)
-      ));
+    if (isFeatureActive && activeWorkspace) {
+      return this.getWorkspaceServices(activeWorkspace);
     }
     return services;
   };
 
+  getWorkspaceServices(workspace) {
+    const { services } = this.stores;
+    return workspace.services.map(id => services.one(id)).filter(s => !!s);
+  }
+
   // ========== PRIVATE ========= //
 
   _wasDrawerOpenBeforeSettingsRoute = null;
@@ -218,7 +220,8 @@ export default class WorkspacesStore extends FeatureStore {
     if (this.activeWorkspace) {
       const services = this.stores.services.allDisplayed;
       const activeService = services.find(s => s.isActive);
-      const workspaceServices = this.filterServicesByActiveWorkspace(services);
+      const workspaceServices = this.getWorkspaceServices(this.activeWorkspace);
+      if (workspaceServices.length <= 0) return;
       const isActiveServiceInWorkspace = workspaceServices.includes(activeService);
       if (!isActiveServiceInWorkspace) {
         this.actions.service.setActive({ serviceId: workspaceServices[0].id });
@@ -255,4 +258,19 @@ export default class WorkspacesStore extends FeatureStore {
       }
     }
   };
+
+  _cleanupInvalidServiceReferences = () => {
+    const { services } = this.stores;
+    let invalidServiceReferencesExist = false;
+    this.workspaces.forEach((workspace) => {
+      workspace.services.forEach((serviceId) => {
+        if (!services.one(serviceId)) {
+          invalidServiceReferencesExist = true;
+        }
+      });
+    });
+    if (invalidServiceReferencesExist) {
+      getUserWorkspacesRequest.execute();
+    }
+  };
 }
diff --git a/src/i18n/locales/en-US.json b/src/i18n/locales/en-US.json
index da7649b90..84a71117a 100644
--- a/src/i18n/locales/en-US.json
+++ b/src/i18n/locales/en-US.json
@@ -317,4 +317,4 @@
   "workspaceDrawer.workspaceFeatureInfo": "<p>Franz Workspaces let you focus on what’s important right now. Set up different sets of services and easily switch between them at any time.</p><p>You decide which services you need when and where, so we can help you stay on top of your game - or easily switch off from work whenever you want.</p>",
   "workspaceDrawer.workspacesSettingsTooltip": "Edit workspaces settings",
   "workspaces.switchingIndicator.switchingTo": "Switching to"
-}
+}
\ No newline at end of file