diff options
| author |  Vijay A <avijayr@protonmail.com> | 2021-07-02 20:50:30 +0530 |
|---|---|---|
| committer | Vijay A <avijayr@protonmail.com> | 2021-07-02 20:50:30 +0530 |
| commit | 22a78968f75c7f65a62f3b05757fa900fcf856e9 (patch) | |
| tree | 04594e301f4e14825c9e7abdb5418ebd38361504 /.github | |
| parent | Minor code cleanup: Use constant that's already defined (instead of a string ... (diff) | |
| download | ferdium-app-22a78968f75c7f65a62f3b05757fa900fcf856e9.tar.gz ferdium-app-22a78968f75c7f65a62f3b05757fa900fcf856e9.tar.zst ferdium-app-22a78968f75c7f65a62f3b05757fa900fcf856e9.zip | |
Fixing github templates for PRs. [skip ci]
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 | ||||
| -rw-r--r-- | .github/workflows/dependency-updates.yml | 5 |
2 files changed, 6 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5a6f95002..5f5ca9743 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md | |||
| @@ -14,5 +14,5 @@ | |||
| 14 | ### Checklist: | 14 | ### Checklist: |
| 15 | <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> | 15 | <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> |
| 16 | - [ ] My pull request is properly named | 16 | - [ ] My pull request is properly named |
| 17 | - [ ] The changes respect the code style of the project (`$ npm run lint`) | 17 | - [ ] The changes respect the code style of the project (`$ npm run lint && npm run reformat-files && npm run manage-translations && npm run apply-branding`) |
| 18 | - [ ] I tested/previewed my changes locally \ No newline at end of file | 18 | - [ ] I tested/previewed my changes locally |
diff --git a/.github/workflows/dependency-updates.yml b/.github/workflows/dependency-updates.yml index 5d6d34d9f..450ddf8a1 100644 --- a/.github/workflows/dependency-updates.yml +++ b/.github/workflows/dependency-updates.yml | |||
| @@ -50,8 +50,11 @@ jobs: | |||
| 50 | echo "Updating browserslist db" | 50 | echo "Updating browserslist db" |
| 51 | npx browserslist@latest --update-db | 51 | npx browserslist@latest --update-db |
| 52 | 52 | ||
| 53 | echo "Running linter and tests" | 53 | echo "Running linter, reformatter, rebrander and tests" |
| 54 | npm run lint | 54 | npm run lint |
| 55 | npm run reformat-files | ||
| 56 | npm run manage-translations | ||
| 57 | npm run apply-branding | ||
| 55 | npm run test | 58 | npm run test |
| 56 | 59 | ||
| 57 | echo "Committing and pushing submodules, dependency-updates and linter changes" | 60 | echo "Committing and pushing submodules, dependency-updates and linter changes" |