From d7d29fe546ab0acb332013eb380f8193e1d5b9fc Mon Sep 17 00:00:00 2001 From: Brian Ashworth Date: Wed, 17 Apr 2019 01:57:34 -0400 Subject: swaymsg: add timeout and type checks This adds a 3 second timeout to the initial reply in swaymsg. This prevents swaymsg from hanging when `swaymsg -t get_{inputs,seats}` is used in i3. The timeout is removed when waiting for a subscribed event or monitoring for subscribed events. This also adds type checks to commands where i3 does not reply with all of the properties that sway does (such as `modes` in `get_outputs`). This is mostly just a behavioral adjustment since swaymsg should run on i3. When running under i3, some command reply's (such as the one for `get_outputs) may have more useful information in the raw json than the pretty printed version. --- swaymsg/main.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'swaymsg') diff --git a/swaymsg/main.c b/swaymsg/main.c index ccc847f5..518993af 100644 --- a/swaymsg/main.c +++ b/swaymsg/main.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -238,7 +239,8 @@ static void pretty_print_output(json_object *o) { ); } - size_t modes_len = json_object_array_length(modes); + size_t modes_len = json_object_is_type(modes, json_type_array) + ? json_object_array_length(modes) : 0; if (modes_len > 0) { printf(" Available modes:\n"); for (size_t i = 0; i < modes_len; ++i) { @@ -448,6 +450,8 @@ int main(int argc, char **argv) { int ret = 0; int socketfd = ipc_open_socket(socket_path); + struct timeval timeout = {.tv_sec = 3, .tv_usec = 0}; + ipc_set_recv_timeout(socketfd, timeout); uint32_t len = strlen(command); char *resp = ipc_single_command(socketfd, type, command, &len); if (!quiet) { @@ -478,6 +482,11 @@ int main(int argc, char **argv) { free(resp); if (type == IPC_SUBSCRIBE && ret == 0) { + // Remove the timeout for subscribed events + timeout.tv_sec = 0; + timeout.tv_usec = 0; + ipc_set_recv_timeout(socketfd, timeout); + do { struct ipc_response *reply = ipc_recv_response(socketfd); if (!reply) { -- cgit v1.2.3-54-g00ecf