From cdff693e2ec13954831e423008241ce28dee538f Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Thu, 2 Jul 2020 12:14:52 +0200 Subject: tree/view: fix segfault in view_update_title xdg-shell doesn't allow clients to set the title to NULL, so we shouldn't need to call wlr_foreign_toplevel_handle_v1_set_title with an empty string to reset the old one. Closes: https://github.com/swaywm/sway/issues/5488 (cherry picked from commit b5a35c484f651e25b226c9661669c8a40439f09b) --- sway/tree/view.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sway/tree/view.c b/sway/tree/view.c index 53c11a32..ac314795 100644 --- a/sway/tree/view.c +++ b/sway/tree/view.c @@ -1171,7 +1171,7 @@ void view_update_title(struct sway_view *view, bool force) { ipc_event_window(view->container, "title"); - if (view->foreign_toplevel) { + if (view->foreign_toplevel && title) { wlr_foreign_toplevel_handle_v1_set_title(view->foreign_toplevel, title); } } -- cgit v1.2.3