aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAge
...
| * cmd_assign: fix leak on errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * utf8_size: fix loop boundaryLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis
| * bar_cmd_modifier: fix use-after-free on errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * bar_cmd_font: fix leak of fontLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | join_args is a freshly allocated string and can be used as is. Found through static analysis.
| * get_parent_pid: fix memory leakLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * read_config: fix leak on errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * cmd_background: fix leak on errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * transaction_apply: use float for quotientLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | Pre-dividing 1000/60 would lose 2/3 due to round-up Found through static analysis
| * workspace_next_name: fix string length for ws_num >= 100Libravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | | | | | | | | | | | The check didn't include && ws_num < 100 so l would always be 1 or 2 Instead of fixing logic it's simpler to just call snprintf twice to get length and use that. Also change malloc failure check to sway_assert because both callers of this function do not do null check and would segfault... Found through static analysis.
| * find prev/next output/workspace: add NULL checkLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | These could be called with NULL if there is no focus Found through static analysis.
| * output commands: move !argc checks after argc gets decrementedLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * config_commands_command: make alloc failure check more permanentLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | policy is accessed again later Found through static analysis
| * input_config: free new_input_config on errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | Found through static analysis.
| * ipc-server: fix more use-after-frees on ipc_send_reply errorLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | | | Since ipc_send_reply frees the client on error, we need to check the return value properly as we access client later on Found through static analysis.
| * ipc-server: minor code cleanupLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | | | No logic change here, this one is mostly to please static analyzer: - client->fd can never be -1 (and if it could, close() a few lines below would have needed the same check) - we never send permission denied error (dead code)
| * ipc-server: fix double-free on send error in ipc_send_eventLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | | | | | | | ipc_send_reply already does client disconnect on error, so we shouldn't do it again. We also need to process current index again as disconnect removes client from the list we currently are processing (this is an indexed "list") Found through static analysis.
| * invoke_swaybar: fix message length header sizeLibravatar Dominique Martinet2018-07-02
| | | | | | | | | | | | | | | | size_t/ssize_t are 8 bytes on 64bit systems, so use the proper size to transmit that information. This could lead to ridiculously large alloc as len is not initialized to zero Found through static analysis
| * log_kernel: s/fclose/pclose/ (for popen'd FILE)Libravatar Dominique Martinet2018-07-02
|/ | | | | | | With recent glibc the functions are strictly identical, but this might not be true for all libc implementations Found through static analysis.
* Merge pull request #2190 from emersion/screencopyLibravatar emersion2018-07-01
|\ | | | | Init screencopy manager
| * Init screencopy managerLibravatar emersion2018-07-01
|/
* Merge pull request #2188 from martinetd/exec-always-cmdLibravatar Drew DeVault2018-07-01
|\ | | | | exec_always: fix leaks
| * exec_always: fix leaksLibravatar Dominique Martinet2018-07-02
|/ | | | | | | | | | | | - child would leak in the workspace_record_pid path - removing malloc lets us get rid of That Comment nobody seems to remember what it was about - we would leak pipe fds on first fork failling - we didn't return an error if second fork failed - the final executed process still had both pipe fds (would show up in /proc/23560/fd in launched programs) - we would write twice to the pipe if execl failed for some reason (e.g. if /bin/sh doesn't exist?!)
* Merge pull request #2180 from martinetd/xdg_fullscreenLibravatar Ryan Dwyer2018-06-30
|\ | | | | xdg_shell: listen to fullscreen request on map
| * xdg_shell: listen to fullscreen request on mapLibravatar Dominique Martinet2018-06-30
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | That event comes from the toplevel and not the surface, so would cause a use-after-free on destroy if the toplevel got destroyed first: ==5454==ERROR: AddressSanitizer: heap-use-after-free on address 0x6110001ed198 at pc 0x000000472d10 bp 0x7ffc19070a80 sp 0x7ffc19070a70 WRITE of size 8 at 0x6110001ed198 thread T0 #0 0x472d0f in wl_list_remove ../common/list.c:157 #1 0x42e159 in handle_destroy ../sway/desktop/xdg_shell_v6.c:243 #2 0x7fa9e5b28ce8 in wlr_signal_emit_safe ../util/signal.c:29 #3 0x7fa9e5afd6b1 in destroy_xdg_surface_v6 ../types/xdg_shell_v6/wlr_xdg_surface_v6.c:101 #4 0x7fa9e5d98025 in destroy_resource src/wayland-server.c:688 #5 0x7fa9e5d98091 in wl_resource_destroy src/wayland-server.c:705 #6 0x7fa9e27f103d in ffi_call_unix64 (/lib64/libffi.so.6+0x603d) #7 0x7fa9e27f09fe in ffi_call (/lib64/libffi.so.6+0x59fe) #8 0x7fa9e5d9bf2c (/lib64/libwayland-server.so.0+0xbf2c) #9 0x7fa9e5d983de in wl_client_connection_data src/wayland-server.c:420 #10 0x7fa9e5d99f01 in wl_event_loop_dispatch src/event-loop.c:641 #11 0x7fa9e5d98601 in wl_display_run src/wayland-server.c:1260 #12 0x40a2f4 in main ../sway/main.c:433 #13 0x7fa9e527318a in __libc_start_main ../csu/libc-start.c:308 #14 0x40b749 in _start (/opt/wayland/bin/sway+0x40b749) 0x6110001ed198 is located 152 bytes inside of 240-byte region [0x6110001ed100,0x6110001ed1f0) freed by thread T0 here: #0 0x7fa9e7c89880 in __interceptor_free (/lib64/libasan.so.5+0xee880) #1 0x7fa9e5affce9 in destroy_xdg_toplevel_v6 ../types/xdg_shell_v6/wlr_xdg_toplevel_v6.c:23 #2 0x7fa9e5d98025 in destroy_resource src/wayland-server.c:688 previously allocated by thread T0 here: #0 0x7fa9e7c89e50 in calloc (/lib64/libasan.so.5+0xeee50) #1 0x7fa9e5b00eea in create_xdg_toplevel_v6 ../types/xdg_shell_v6/wlr_xdg_toplevel_v6.c:427 #2 0x7fa9e27f103d in ffi_call_unix64 (/lib64/libffi.so.6+0x603d) The toplevel only notifies the compositor on destroy if it was mapped, so only listen to events at map time.
* Merge pull request #2174 from martinetd/view-from-surfaceLibravatar Drew DeVault2018-06-30
|\ | | | | sway views: add helpers to get view and layer from wlr_surface
| * sway views: add helpers to get view and layer from wlr_surfaceLibravatar Dominique Martinet2018-06-30
|/
* Merge pull request #2072 from RyanDwyer/atomicLibravatar Drew DeVault2018-06-30
|\ | | | | Atomic layout updates
| * Merge remote-tracking branch 'upstream/master' into atomicLibravatar Ryan Dwyer2018-06-30
| |\ | |/ |/|
* | Merge pull request #2179 from atomnuker/masterLibravatar emersion2018-06-30
|\ \ | | | | | | Fix crash with stacking layout after f42bf0ad4
| * | Fix crash with stacking layout after f42bf0ad4Libravatar Rostislav Pehlivanov2018-06-30
|/ / | | | | | | The "simple" rendering function only applies to tiled views.
* | Merge pull request #2175 from apreiml/fix-swaymsg-error-outputLibravatar emersion2018-06-30
|\ \ | | | | | | fix swaymsg: errors are displayed again
| * | refactor success_objectLibravatar Armin Preiml2018-06-30
| | |
| * | fix swaymsg: errors are displayed againLibravatar Armin Preiml2018-06-30
| | | | | | | | | | | | | | | Command errors didn't get displayed, because the success function didn't accept objects
* | | Merge pull request #2171 from atomnuker/masterLibravatar emersion2018-06-30
|\ \ \ | | | | | | | | Revert "Don't unmaximize floating views"
| * | | container_at_view: don't offset the view by the window geometryLibravatar Rostislav Pehlivanov2018-06-30
| | | | | | | | | | | | | | | | | | | | Fixes floating window input offsets. As discussed on IRC with emersion, this shouldn't have been done in the first place.
| * | | Revert "Don't unmaximize floating views"Libravatar Rostislav Pehlivanov2018-06-30
|/ / / | | | | | | | | | This reverts commit 97672295ed50d1d6272876c4a3b6b5607cab05c6.
* | | Merge pull request #2173 from emersion/fix-floating-no-frame-eventLibravatar Ryan Dwyer2018-06-30
|\ \ \ | |/ / |/| | Fix floating views not receiving frame events
| * | Fix floating views not receiving frame eventsLibravatar emersion2018-06-30
|/ / | | | | | | | | | | That happened when they were in tabbed or stacked containers. Fixes #2161
| * Fix compile errorLibravatar Ryan Dwyer2018-06-30
| |
| * Fix flash of background when xwayland views are mappedLibravatar Ryan Dwyer2018-06-30
| | | | | | | | | | | | | | | | | | | | | | A flash of background was happening for two reasons: 1) We were using the xsurface's dimensions to check if the surface is ready, but these are pending dimensions. 2) In my particular setup, the default geometry of the xsurface does not intersect any output, which prevented it from receiving a frame done event. This made the transaction time out and the client would only redraw once it's been rendered.
| * Render saved buffers with the surface's dimensionsLibravatar Ryan Dwyer2018-06-29
| |
| * Merge remote-tracking branch 'upstream/master' into atomicLibravatar Ryan Dwyer2018-06-29
| |\ | |/ |/|
* | Merge pull request #2172 from apreiml/fix-keybinding-modifier-handlingLibravatar Drew DeVault2018-06-28
|\ \ | | | | | | fix handling key modifiers if not pressed at first
| * | fix handling key modifiers if not pressed at firstLibravatar Armin Preiml2018-06-28
| | | | | | | | | | | | fixes #2169
* | | Merge pull request #2170 from apreiml/masterLibravatar emersion2018-06-27
|\| | | | | | | | fix accidently removing borders on XCB_CONFIGURE_REQUEST
| * | fix accidently removing borders on XCB_CONFIGURE_REQUESTLibravatar Armin Preiml2018-06-27
|/ / | | | | | | | | | | | | The view was configured with the container coordinates. Although they were right on the first configure, they changed after a XCB_CONFIGURE_REQUEST, when the border was already drawn.
* | Merge pull request #2168 from BlueGone/input-cmd-arg-nbLibravatar emersion2018-06-27
|\ \ | | | | | | Check if command input has at least 2 arguments
| * | Check if command input has at least 2 argumentsLibravatar Thomas Plaçais2018-06-27
|/ /
* | Merge pull request #2145 from emersion/xwayland-wants-floatLibravatar Drew DeVault2018-06-26
|\ \ | | | | | | Automatically float xwayland windows
| * \ Merge branch 'master' into xwayland-wants-floatLibravatar Ryan Dwyer2018-06-27
| |\ \ | |/ / |/| |
generated by cgit v1.2.3-54-g00ecf (git 2.45.2) at 2024-07-08 05:48:53 +0000