| Commit message (Collapse) | Author | Age |
|---|
| ... | |
| |
|
|
|
|
| |
- Remove struct definitions
- Remove struct members
- Remove initializations and frees
|
| | |
|
| |
|
|
| |
Refs #5268.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
For some reason my version of sway doesn't show workspace names:
$ swaymsg -t get_outputs
Output HDMI-A-1 '(null) (null) (null)' (inactive)
Output HDMI-A-2 '(null) (null) (null)' (inactive)
Which is weird, but it's no reason to crash swaybar. The field is
totally missing from the JSON, so it ends up doing strcmp(NULL, name)
which is undefined behavior.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keyboard group keyboards should not call sway_keyboard_configure. They
do not have an input config and they derive their state from the
keyboards within the group.
For some reason, I got sway_keyboard_configure and
seat_configure_keyboard mixed up and thought seat_reset_device called
the latter.
Calling sway_keyboard_configure with a keyboard group's keyboard is not
supported and can cause issues. If any clients are listening to the ipc
input event, a sigsegv will occur due to not every property - such as
identifier - being wired up for keyboard group keyboard's.
This also adds an assertion to sway_keyboard_configure to ensure that
this does not occur in the future and any instances are quickly caught.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the keyboard that triggers the reload binding is using the default
keymap, default repeat delay, and default repeat rate, the associated
keyboard group is never being destroyed on reload. This was causing the
keyboard group's keyboard not to get disarmed and result in a
use-after-free in handle_keyboard_repeat.
If the keyboard was not using the defaults for all three settings, then
it's associated keyboard would get destroyed during the reset - which
did disarm the keyboard group's keyboard. In this case, the
use-after-free would not occur.
This adds a block to input_manager_reset_all_inputs that resets the
keyboard for all keyboard groups in all seats, which will disarm them.
Since the inputs are all being reset anyway, which will reset all
individual keyboards, it is not necessary to be selective on which ones
get reset.
|
| |
|
|
| |
Remove the entries from meson.build as well.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a separate per-view shortcuts_inhibitor command that can be used
with criteria to override the per-seat defaults. This allows to e.g.
disable shortcuts inhibiting globally but enable it for specific,
known-good virtualization and remote desktop software or, alternatively,
to blacklist that one slightly broken piece of software that just
doesn't seem to get it right but insists on trying.
Add a flag to sway_view and handling logic in the input manager that
respects that flag if configured but falls back to per-seat config
otherwise. Add the actual command but with just enable and disable
subcommands since there's no value in duplicating the per-seat
activate/deactivate/toggle logic here. Split the inhibitor retrieval
helper in two so we can use the backend half in the command to retrieve
inhibitors for a specific surface and not just the currently focused
one. Extend the manual page with documentation of the command and
references to its per-seat sibling and usefulness with criteria.
Signed-off-by: Michael Weiser <michael.weiser@gmx.de>
|
| | |
|
| |
|
|
| |
Fixes: https://github.com/swaywm/sway/pull/5250
|
| |
|
|
| |
Closes #5268.
|
| |
|
|
|
|
|
| |
The current documentation for repaint scheduling is very technical and
somewhat confusing.
Closes: https://github.com/swaywm/sway/issues/4769
|
| | |
|
| |
|
|
|
|
| |
This is a small cleanup commit for removing `sway_tablet` parameters
from functions that already accept `sway_tablet_tool`, since the tablet
reference can be accessed through `tool->tablet`.
|
| |
|
|
|
| |
Added in swaywm/wlroots#2172, so that sway doesn't need to maintain
an independent copy of this function.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Make notifications a separate flag. Personally, I trigger grimshot
myself most of the time (via sway bindsym) rather than by some external
means, so I don't need to be notified of it happening.
However, keep a flag with this functionality there for those scenarios
there it's necessary to inform the user.
Also print the file location when saving the screenshot.
|
| |
|
|
| |
(with slurp)
|
| |
|
|
|
|
|
| |
Show the usage output when an invalid command is received. Otherwise
things like `grimshot --help` save a screenshot, which is really
unexpected and hurts users trying to remember the right commands /
arguments.
|
| |
|
|
|
|
|
|
|
|
| |
Due to the date format used, if several screenshots are taken in
succession, each one overwrote the other.
This change set makes each one have a different name to avoid this.
Also avoid using spaces, since many scripts and tools are unhappy with
file names with spaces.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
`$XDG_PICTURES_DIR` is a very loosely defined thing; it's a directory
where "pictures" are stored, which no clearer definition.
Some people use it for photographs they take, other use it for images
they save from the internet, and others use it for screenshots.
Having lots of tools save their output there (anything that's an image
goes there) can easily make it a kitchen sink.
To work around this, use `$XDG_SCREENSHOTS_DIR` as a target directory
for screenshots by default. If not-so-standard variable is unset, fall
back to the previous setting; `$XDG_PICTURES_DIR`.
This also drops an external dependency, which was (a) an overkill (b)
not flexible enough.
|
| |
|
|
|
| |
Touch events hide the cursor so unhiding it again only causes it to
flicker.
|
| |
|
|
|
| |
The type expected by wlroots is uint32_t, which `event->button`
already is.
|
| |
|
|
|
|
|
| |
This commit renames `motion` and `axis` handlers to `pointer_motion` and
`pointer_axis`, respectively, to disambiguate them from their tablet
(and future touch) handlers. `button` is left as-is, as it is generic
across input devices.
|
| |
|
|
|
|
|
| |
This commit moves tablet motion logic into a seatop handler.
As a side-effect of seatop implementations being able to receive
tablet motion events, fixes #5232.
|
| | |
|
| |
|
|
|
|
|
|
| |
This commit refactors `cursor_rebase` into `cursor_update_image`, and
moves sending pointer events to the two existing call sites. This will
enable this code to be reused for tablets.
Refs #5232
|
| |
|
|
| |
This allows the create_output command to work on DRM too.
|
| | |
|
| |
|
|
|
| |
If it doesn't load, it's a runtime error, so we shouldn't use an
assertion.
|
| | |
|
| |
|
|
|
|
|
| |
d88460f addressed sending v2 tool tip up when over a non-v2 surface.
This commit addresses the other direction.
Fixes #5230.
|
| |
|
|
|
|
|
|
|
| |
Currently, clients receive wl_data_device::leave events only when the
pointer enters another surface, which leads to issues, such as #5220.
This happens because wlr_seat_pointer_notify_enter() is called when
handling motion events only for non-NULL surfaces.
Fixes #5220
|
| |
|
|
|
|
|
| |
Use the Meson summary() built-in instead of manually formatting a
message.
wlroots already depends on Meson 0.54.0.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
It is common for user to attach a debug log from the Wayland backend
because they are running the command from inside of Sway. This just adds
a note that the debug logs should be obtained from a TTY. Anyone who is
actually using the Wayland or X11 backends and submitting an issue
related to them likely is already familiar with how to obtain a debug
log for the appropriate backend.
|
| |
|
|
|
| |
The issue tracker has already enough traffic with bug reports and
feature requests.
|
| | |
|
| |
|
|
|
|
|
| |
This is a criteria you can use to select windows since commit
484cc189e909 ("Add shell criteria token"), but there's no way to query
it for an existing window. This exposes its value in the output of
`swaymsg -t get_tree`.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
`handle_tablet_tool_set_cursor` was copied from input/cursor.c's
`handle_request_set_cursor`, but the focused surface check was not
adjusted appropriately.
Fixes #5257.
|
| |
|
|
|
|
|
|
|
|
| |
Previously in 3de1a39, it "worked by accident" in my testing since the
display being used in `map_to_output` was initialized first (the map
would not be applied because the display hadn't actually come online
yet), and was followed by a second display (at which point the map would
get applied for the first display).
Refs #5231
|
| |
|
|
|
|
|
|
|
| |
Fixes #4819.
This commit ensures that `seat_set_focus` is called to transfer focus
when a window is selected via a pen. Previously, it would race with
`node_at_coords`, and only properly transfer focus if its returned
`surface` was NULL.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Some input rules, like `map_to_output`, are dependent on a specific
screen being present. This currently does not work for hotplugged
outputs, or outputs that are processed after the input device is
initially probed.
This commit fixes both cases, by reconfiguring inputs on each output
addition.
Fixes #5231.
|
Érico Rolim
Martin Michlmayr
Tudor Brindus
Milkey Mouse
Brian Ashworth
Eric Engestrom
Michael Weiser
David96
Adam Kürthy
Kenny Levinsen
Paul Ouellette
Hugo Osvaldo Barrera
Simon Ser
skip-yell
Nick Diego Yamane
James Mills
jhalmen
Ejez
Martin Dørum
Thomas Hebb