aboutsummaryrefslogtreecommitdiffstats
path: root/sway/tree/view.c
diff options
context:
space:
mode:
authorLibravatar Hugo Osvaldo Barrera <hugo@barrera.io>2021-09-17 17:32:29 +0200
committerLibravatar Simon Ser <contact@emersion.fr>2021-09-20 09:25:47 +0200
commitc16b2a26ed2c2f718cb8a2084fa93636fabed95f (patch)
tree2a0ea215552cf497f2f6b4f25552975eb33781b0 /sway/tree/view.c
parentsway-ipc.7.scd: fix typo (diff)
downloadsway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.tar.gz
sway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.tar.zst
sway-c16b2a26ed2c2f718cb8a2084fa93636fabed95f.zip
Avoid unecessary font metric calculations
Prior to 62d90a8e, titlebar's font height (and other related values) would change any time any titlebar's content changed, so these values were recalculated each time any titlebar's content changed (or a new titlebar was created). However, since the above was merge, these values no longer change so often and we only need to recalculate them when the configured font changes (and stop calling `config_update_font_height` each time titlebars are rendered). This commit removes all the unecessary calls to this function and avoids all those unecessary calculations. Whenever the font strays from the default value, the `font` command is called, and it calls `config_update_font_height`, which is enough to keep the value always up to date. I've also added a default value to the `font_baseline` config, since otherwise that's zero for setups that don't explicitly specify a font.
Diffstat (limited to 'sway/tree/view.c')
-rw-r--r--sway/tree/view.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/sway/tree/view.c b/sway/tree/view.c
index ccb03088..b2f70d70 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -1280,7 +1280,6 @@ void view_update_title(struct sway_view *view, bool force) {
1280 view->container->title = NULL; 1280 view->container->title = NULL;
1281 view->container->formatted_title = NULL; 1281 view->container->formatted_title = NULL;
1282 } 1282 }
1283 config_update_font_height();
1284 1283
1285 // Update title after the global font height is updated 1284 // Update title after the global font height is updated
1286 container_update_title_textures(view->container); 1285 container_update_title_textures(view->container);