Introduce container_is_scratchpad_hidden

Just a convenience function that improves readability of the code.

Other things worth noting:

* container_get_siblings and container_sibling_index no longer use the
const keyword
* container_handle_fullscreen_reparent is only ever called after
attaching the container to a workspace, so its con->workspace check has
been changed to an assertion

1 files changed, 2 insertions, 3 deletions

diff --git a/sway/tree/view.c b/sway/tree/view.c
index 9ccb2a31..612cf96a 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -197,8 +197,7 @@ static bool gaps_to_edge(struct sway_view *view) {
 
 void view_autoconfigure(struct sway_view *view) {
         struct sway_container *con = view->container;
-        if (!con->workspace) {
-                // Hidden in the scratchpad
+        if (container_is_scratchpad_hidden(con)) {
                 return;
         }
         struct sway_output *output = con->workspace->output;
@@ -1054,7 +1053,7 @@ void view_set_urgent(struct sway_view *view, bool enable) {
 
         ipc_event_window(view->container, "urgent");
 
-        if (view->container->workspace) {
+        if (!container_is_scratchpad_hidden(view->container)) {
                 workspace_detect_urgent(view->container->workspace);
         }
 }