aboutsummaryrefslogtreecommitdiffstats
path: root/sway/tree/view.c
diff options
context:
space:
mode:
authorLibravatar Ryan Dwyer <ryandwyer1@gmail.com>2018-07-14 23:14:55 +1000
committerLibravatar Ryan Dwyer <ryandwyer1@gmail.com>2018-07-14 23:14:55 +1000
commit2032f85d94f2f222282b242116b3e827dd458f6c (patch)
treed6ad82f79521cdd948985be22630b803af58afea /sway/tree/view.c
parentMerge pull request #2244 from RyanDwyer/floating-resize (diff)
downloadsway-2032f85d94f2f222282b242116b3e827dd458f6c.tar.gz
sway-2032f85d94f2f222282b242116b3e827dd458f6c.tar.zst
sway-2032f85d94f2f222282b242116b3e827dd458f6c.zip
Simplify transactions by utilising a dirty flag on containers
This PR changes the way we handle transactions to a more simple method. The new method is to mark containers as dirty from low level code (eg. arranging, or container_destroy, and eventually seat_set_focus), then call transaction_commit_dirty which picks up those containers and runs them through a transaction. The old methods of using transactions (arrange_and_commit, or creating one manually) are now no longer possible. The highest-level code (execute_command and view implementation handlers) will call transaction_commit_dirty, so most other code just needs to set containers as dirty. This is done by arranging, but can also be done by calling container_set_dirty.
Diffstat (limited to 'sway/tree/view.c')
-rw-r--r--sway/tree/view.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/sway/tree/view.c b/sway/tree/view.c
index b356183c..bf380d98 100644
--- a/sway/tree/view.c
+++ b/sway/tree/view.c
@@ -594,11 +594,12 @@ void view_unmap(struct sway_view *view) {
594 ws->sway_workspace->fullscreen = NULL; 594 ws->sway_workspace->fullscreen = NULL;
595 container_destroy(view->swayc); 595 container_destroy(view->swayc);
596 596
597 arrange_and_commit(ws->parent); 597 arrange_windows(ws->parent);
598 } else { 598 } else {
599 struct sway_container *parent = container_destroy(view->swayc); 599 struct sway_container *parent = container_destroy(view->swayc);
600 arrange_and_commit(parent); 600 arrange_windows(parent);
601 } 601 }
602 transaction_commit_dirty();
602 view->surface = NULL; 603 view->surface = NULL;
603} 604}
604 605