diff options
author | Tudor Brindus <me@tbrindus.ca> | 2020-05-04 17:34:28 -0400 |
---|---|---|
committer | Simon Ser <contact@emersion.fr> | 2020-05-25 10:01:00 +0200 |
commit | 5d13f647f9384e59012c0f829651911564bb5365 (patch) | |
tree | b768fac3dac8328d1efc7c9b4e96aa461ab7c9a5 /sway/input/seat.c | |
parent | common/log: use bright black rather than black for SWAY_DEBUG (diff) | |
download | sway-5d13f647f9384e59012c0f829651911564bb5365.tar.gz sway-5d13f647f9384e59012c0f829651911564bb5365.tar.zst sway-5d13f647f9384e59012c0f829651911564bb5365.zip |
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
Diffstat (limited to 'sway/input/seat.c')
-rw-r--r-- | sway/input/seat.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/sway/input/seat.c b/sway/input/seat.c index 233267e0..e5f15613 100644 --- a/sway/input/seat.c +++ b/sway/input/seat.c | |||
@@ -1471,6 +1471,14 @@ void seatop_pointer_axis(struct sway_seat *seat, | |||
1471 | } | 1471 | } |
1472 | } | 1472 | } |
1473 | 1473 | ||
1474 | void seatop_tablet_tool_tip(struct sway_seat *seat, | ||
1475 | struct sway_tablet_tool *tool, uint32_t time_msec, | ||
1476 | enum wlr_tablet_tool_tip_state state) { | ||
1477 | if (seat->seatop_impl->tablet_tool_tip) { | ||
1478 | seat->seatop_impl->tablet_tool_tip(seat, tool, time_msec, state); | ||
1479 | } | ||
1480 | } | ||
1481 | |||
1474 | void seatop_tablet_tool_motion(struct sway_seat *seat, | 1482 | void seatop_tablet_tool_motion(struct sway_seat *seat, |
1475 | struct sway_tablet_tool *tool, uint32_t time_msec, double dx, double dy) { | 1483 | struct sway_tablet_tool *tool, uint32_t time_msec, double dx, double dy) { |
1476 | if (seat->seatop_impl->tablet_tool_motion) { | 1484 | if (seat->seatop_impl->tablet_tool_motion) { |