diff options
author | Brian Ashworth <bosrsf04@gmail.com> | 2018-12-20 13:02:45 -0500 |
---|---|---|
committer | emersion <contact@emersion.fr> | 2018-12-20 19:55:29 +0100 |
commit | 88d96bc41ff638bdc767e30bf6ccbbd530258420 (patch) | |
tree | 5d822da99812aab4e849e566c53d3a6ba87ba496 /sway/commands | |
parent | Terminate swaybg in output_disable (diff) | |
download | sway-88d96bc41ff638bdc767e30bf6ccbbd530258420.tar.gz sway-88d96bc41ff638bdc767e30bf6ccbbd530258420.tar.zst sway-88d96bc41ff638bdc767e30bf6ccbbd530258420.zip |
Combine output_by_name and output_by_identifier
This combines `output_by_name` and `output_by_identifier` into a single
function called `output_by_name_or_id`. This allows for output
identifiers to be used in all commands, simplifies the logic of the
callers, and is more efficient since worst case is a single pass through
the output list.
Diffstat (limited to 'sway/commands')
-rw-r--r-- | sway/commands/focus.c | 2 | ||||
-rw-r--r-- | sway/commands/move.c | 2 | ||||
-rw-r--r-- | sway/commands/output/transform.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/sway/commands/focus.c b/sway/commands/focus.c index 689edfec..97ffe91c 100644 --- a/sway/commands/focus.c +++ b/sway/commands/focus.c | |||
@@ -193,7 +193,7 @@ static struct cmd_results *focus_output(struct sway_seat *seat, | |||
193 | "Expected 'focus output <direction|name>'"); | 193 | "Expected 'focus output <direction|name>'"); |
194 | } | 194 | } |
195 | char *identifier = join_args(argv, argc); | 195 | char *identifier = join_args(argv, argc); |
196 | struct sway_output *output = output_by_name(identifier); | 196 | struct sway_output *output = output_by_name_or_id(identifier); |
197 | 197 | ||
198 | if (!output) { | 198 | if (!output) { |
199 | enum wlr_direction direction; | 199 | enum wlr_direction direction; |
diff --git a/sway/commands/move.c b/sway/commands/move.c index 4dc547db..09f19c3f 100644 --- a/sway/commands/move.c +++ b/sway/commands/move.c | |||
@@ -64,7 +64,7 @@ static struct sway_output *output_in_direction(const char *direction_string, | |||
64 | } | 64 | } |
65 | } | 65 | } |
66 | 66 | ||
67 | return output_by_name(direction_string); | 67 | return output_by_name_or_id(direction_string); |
68 | } | 68 | } |
69 | 69 | ||
70 | static bool is_parallel(enum sway_container_layout layout, | 70 | static bool is_parallel(enum sway_container_layout layout, |
diff --git a/sway/commands/output/transform.c b/sway/commands/output/transform.c index c1555323..ca6f73a4 100644 --- a/sway/commands/output/transform.c +++ b/sway/commands/output/transform.c | |||
@@ -45,7 +45,7 @@ struct cmd_results *output_cmd_transform(int argc, char **argv) { | |||
45 | return cmd_results_new(CMD_INVALID, "output", | 45 | return cmd_results_new(CMD_INVALID, "output", |
46 | "Cannot apply relative transform to all outputs."); | 46 | "Cannot apply relative transform to all outputs."); |
47 | } | 47 | } |
48 | struct sway_output *s_output = output_by_name(output->name); | 48 | struct sway_output *s_output = output_by_name_or_id(output->name); |
49 | if (s_output == NULL) { | 49 | if (s_output == NULL) { |
50 | return cmd_results_new(CMD_INVALID, "output", | 50 | return cmd_results_new(CMD_INVALID, "output", |
51 | "Cannot apply relative transform to unknown output %s", output->name); | 51 | "Cannot apply relative transform to unknown output %s", output->name); |