diff options
author | Joan Bruguera <joanbrugueram@gmail.com> | 2021-09-18 22:21:22 +0200 |
---|---|---|
committer | Simon Ser <contact@emersion.fr> | 2022-11-26 10:17:53 +0100 |
commit | 94b69acf0d7b26ee5af2172300cb18473508da76 (patch) | |
tree | 1b26242344968929fc2698b49b12478eb9fe4fae /include/swaybar/input.h | |
parent | swaybar: Prioritize hotspot events to bar bindings (diff) | |
download | sway-94b69acf0d7b26ee5af2172300cb18473508da76.tar.gz sway-94b69acf0d7b26ee5af2172300cb18473508da76.tar.zst sway-94b69acf0d7b26ee5af2172300cb18473508da76.zip |
swaybar: Make hotspots block bar release bindings
The previous commit prioritized hotspots before bar bindings for press events,
which matches i3's behaviour. However, since hotspots don't need to do any
processing on release events, those were not handled, and simply fell through
to `bindsym --release` bar bindings (if any).
This is counter-intuitive, and doesn't match i3's behaviour. Instead in case
a hotspot handles the press event, it should also handle the release event,
doing nothing, but blocking the event from triggering a --release bar binding.
E.g., in Sway, without this commit, this config. shows a text on tray clicks:
bar {
# ...
bindsym --release button1 exec swaynag -m I_got_the_release_event.
}
But the same configuration in i3 (with i3-nagbar) doesn't show the text.
Signed-off-by: Joan Bruguera <joanbrugueram@gmail.com>
Diffstat (limited to 'include/swaybar/input.h')
-rw-r--r-- | include/swaybar/input.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/swaybar/input.h b/include/swaybar/input.h index e8735d88..8ea88a69 100644 --- a/include/swaybar/input.h +++ b/include/swaybar/input.h | |||
@@ -49,7 +49,7 @@ struct swaybar_hotspot { | |||
49 | int x, y, width, height; | 49 | int x, y, width, height; |
50 | enum hotspot_event_handling (*callback)(struct swaybar_output *output, | 50 | enum hotspot_event_handling (*callback)(struct swaybar_output *output, |
51 | struct swaybar_hotspot *hotspot, double x, double y, uint32_t button, | 51 | struct swaybar_hotspot *hotspot, double x, double y, uint32_t button, |
52 | void *data); | 52 | bool released, void *data); |
53 | void (*destroy)(void *data); | 53 | void (*destroy)(void *data); |
54 | void *data; | 54 | void *data; |
55 | }; | 55 | }; |