aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar Kenny Levinsen <kl@kl.wtf>2022-12-18 23:39:02 +0100
committerLibravatar Simon Ser <contact@emersion.fr>2022-12-19 10:39:53 +0100
commit6b900bab60794b1f4143fbe17a686e67a40b715e (patch)
tree7c35c289779ac1bab3c6bba8d37b37c0ee1a454e
parentcommands/move: Warp cursor after moving workspace to another output (diff)
downloadsway-6b900bab60794b1f4143fbe17a686e67a40b715e.tar.gz
sway-6b900bab60794b1f4143fbe17a686e67a40b715e.tar.zst
sway-6b900bab60794b1f4143fbe17a686e67a40b715e.zip
seat: Set keyboard if seat keyboard is NULL
sway sends wl_keyboard.enter on seat focus change and when a keyboard active on a seat is configured. If all keyboards are removed and a keyboard is added back without changing the focused client, no new notify event would be sent despite having keyboard focus. This could lead to key events without notify, which is a protocol violation. As a quick fix, when configuring a keyboard on a seat where no keyboard is currently active, activate the keyboard so that a focused surface will receive a notify event. Regressed by: e1b268af98edeb09e570e8855ef64f0719cbafe2 Closes: https://github.com/swaywm/sway/issues/7330 (cherry picked from commit 1ade0ce753dc5f588584f444ce80d27c3b1e4300)
-rw-r--r--sway/input/keyboard.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/sway/input/keyboard.c b/sway/input/keyboard.c
index aedf3ae6..c5a646c4 100644
--- a/sway/input/keyboard.c
+++ b/sway/input/keyboard.c
@@ -1068,6 +1068,13 @@ void sway_keyboard_configure(struct sway_keyboard *keyboard) {
1068 } 1068 }
1069 } 1069 }
1070 1070
1071 // If the seat has no active keyboard, set this one
1072 struct wlr_seat *seat = keyboard->seat_device->sway_seat->wlr_seat;
1073 struct wlr_keyboard *current_keyboard = seat->keyboard_state.keyboard;
1074 if (current_keyboard == NULL) {
1075 wlr_seat_set_keyboard(seat, keyboard->wlr);
1076 }
1077
1071 wl_list_remove(&keyboard->keyboard_key.link); 1078 wl_list_remove(&keyboard->keyboard_key.link);
1072 wl_signal_add(&keyboard->wlr->events.key, &keyboard->keyboard_key); 1079 wl_signal_add(&keyboard->wlr->events.key, &keyboard->keyboard_key);
1073 keyboard->keyboard_key.notify = handle_keyboard_key; 1080 keyboard->keyboard_key.notify = handle_keyboard_key;