diff options
author | Ryan Dwyer <RyanDwyer@users.noreply.github.com> | 2018-07-04 23:21:41 +1000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-07-04 23:21:41 +1000 |
commit | 7efeacf16c088f45feae3190d1f33fa3273eb6ea (patch) | |
tree | 75dd1aba08ea3351523d3db33b74eba85cc9419e | |
parent | Merge pull request #2200 from mucamaca/fix_transparency (diff) | |
parent | Fix use after free in transaction code (diff) | |
download | sway-7efeacf16c088f45feae3190d1f33fa3273eb6ea.tar.gz sway-7efeacf16c088f45feae3190d1f33fa3273eb6ea.tar.zst sway-7efeacf16c088f45feae3190d1f33fa3273eb6ea.zip |
Merge pull request #2208 from RyanDwyer/instruction-use-after-free
Fix use after free in transaction code
-rw-r--r-- | sway/desktop/transaction.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sway/desktop/transaction.c b/sway/desktop/transaction.c index 7b670aec..b4d796cb 100644 --- a/sway/desktop/transaction.c +++ b/sway/desktop/transaction.c | |||
@@ -377,7 +377,9 @@ static void set_instructions_ready(struct sway_view *view, int index) { | |||
377 | for (int i = 0; i <= index; ++i) { | 377 | for (int i = 0; i <= index; ++i) { |
378 | struct sway_transaction_instruction *instruction = | 378 | struct sway_transaction_instruction *instruction = |
379 | view->swayc->instructions->items[i]; | 379 | view->swayc->instructions->items[i]; |
380 | set_instruction_ready(instruction); | 380 | if (!instruction->ready) { |
381 | set_instruction_ready(instruction); | ||
382 | } | ||
381 | } | 383 | } |
382 | } | 384 | } |
383 | 385 | ||