summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLibravatar Ryan Dwyer <ryandwyer1@gmail.com>2018-08-03 18:08:20 +1000
committerLibravatar Ryan Dwyer <ryandwyer1@gmail.com>2018-08-03 18:08:20 +1000
commitc17f0870ef1620e73b18f0b0ce8303c94027d19b (patch)
treeeb00ad1385d5632494b15e19a9c3afe9b16a8789
parentMerge pull request #2408 from ianyfan/exit-nag (diff)
downloadsway-c17f0870ef1620e73b18f0b0ce8303c94027d19b.tar.gz
sway-c17f0870ef1620e73b18f0b0ce8303c94027d19b.tar.zst
sway-c17f0870ef1620e73b18f0b0ce8303c94027d19b.zip
Fix crash when moving cursor over a fullscreen split container
Calling container_at_view fails an assertion if the container isn't a view. Calling tiling_container_at works correctly, as that function checks if the container is a view and calls container_at_view if so.
-rw-r--r--include/sway/tree/container.h6
-rw-r--r--sway/input/cursor.c2
-rw-r--r--sway/tree/container.c8
3 files changed, 6 insertions, 10 deletions
diff --git a/include/sway/tree/container.h b/include/sway/tree/container.h
index c3942e9e..44ff9f7d 100644
--- a/include/sway/tree/container.h
+++ b/include/sway/tree/container.h
@@ -234,9 +234,9 @@ struct sway_container *container_at(struct sway_container *workspace,
234 double lx, double ly, struct wlr_surface **surface, 234 double lx, double ly, struct wlr_surface **surface,
235 double *sx, double *sy); 235 double *sx, double *sy);
236 236
237struct sway_container *container_at_view(struct sway_container *view, 237struct sway_container *tiling_container_at(
238 double lx, double ly, struct wlr_surface **surface, 238 struct sway_container *con, double lx, double ly,
239 double *sx, double *sy); 239 struct wlr_surface **surface, double *sx, double *sy);
240 240
241/** 241/**
242 * Apply the function for each descendant of the container breadth first. 242 * Apply the function for each descendant of the container breadth first.
diff --git a/sway/input/cursor.c b/sway/input/cursor.c
index c2fc4e9e..80b4f9dc 100644
--- a/sway/input/cursor.c
+++ b/sway/input/cursor.c
@@ -99,7 +99,7 @@ static struct sway_container *container_at_coords(
99 return ws; 99 return ws;
100 } 100 }
101 if (ws->sway_workspace->fullscreen) { 101 if (ws->sway_workspace->fullscreen) {
102 return container_at_view(ws->sway_workspace->fullscreen, lx, ly, 102 return tiling_container_at(ws->sway_workspace->fullscreen, lx, ly,
103 surface, sx, sy); 103 surface, sx, sy);
104 } 104 }
105 if ((*surface = layer_surface_at(output, 105 if ((*surface = layer_surface_at(output,
diff --git a/sway/tree/container.c b/sway/tree/container.c
index 46c54e2d..4a503652 100644
--- a/sway/tree/container.c
+++ b/sway/tree/container.c
@@ -535,7 +535,7 @@ struct sway_container *container_parent(struct sway_container *container,
535 return container; 535 return container;
536} 536}
537 537
538struct sway_container *container_at_view(struct sway_container *swayc, 538static struct sway_container *container_at_view(struct sway_container *swayc,
539 double lx, double ly, 539 double lx, double ly,
540 struct wlr_surface **surface, double *sx, double *sy) { 540 struct wlr_surface **surface, double *sx, double *sy) {
541 if (!sway_assert(swayc->type == C_VIEW, "Expected a view")) { 541 if (!sway_assert(swayc->type == C_VIEW, "Expected a view")) {
@@ -574,10 +574,6 @@ struct sway_container *container_at_view(struct sway_container *swayc,
574 return NULL; 574 return NULL;
575} 575}
576 576
577static struct sway_container *tiling_container_at(
578 struct sway_container *con, double lx, double ly,
579 struct wlr_surface **surface, double *sx, double *sy);
580
581/** 577/**
582 * container_at for a container with layout L_TABBED. 578 * container_at for a container with layout L_TABBED.
583 */ 579 */
@@ -684,7 +680,7 @@ static struct sway_container *floating_container_at(double lx, double ly,
684 return NULL; 680 return NULL;
685} 681}
686 682
687static struct sway_container *tiling_container_at( 683struct sway_container *tiling_container_at(
688 struct sway_container *con, double lx, double ly, 684 struct sway_container *con, double lx, double ly,
689 struct wlr_surface **surface, double *sx, double *sy) { 685 struct wlr_surface **surface, double *sx, double *sy) {
690 if (con->type == C_VIEW) { 686 if (con->type == C_VIEW) {