diff options
author | S. Christoffer Eliesen <christoffer@eliesen.no> | 2015-12-20 12:49:11 +0100 |
---|---|---|
committer | S. Christoffer Eliesen <christoffer@eliesen.no> | 2015-12-20 12:54:34 +0100 |
commit | e45fd9b6c5dfb858c6f86277351bc216574d8200 (patch) | |
tree | 8d70e85b1e1f1dcca401429c95b9b8ee9bde8890 | |
parent | extensions: panel_config->resource => wl_surface_res. (diff) | |
download | sway-e45fd9b6c5dfb858c6f86277351bc216574d8200.tar.gz sway-e45fd9b6c5dfb858c6f86277351bc216574d8200.tar.zst sway-e45fd9b6c5dfb858c6f86277351bc216574d8200.zip |
extensions: Track panels by wl_resource, position per panel.
Track each panel separately via its wl_resource. `set_panel_position`
might be called before `set_panel`, so reuse panel config.
Place the position in panel_config so that each panel has its own
position.
-rw-r--r-- | include/extensions.h | 4 | ||||
-rw-r--r-- | sway/extensions.c | 25 | ||||
-rw-r--r-- | sway/handlers.c | 2 | ||||
-rw-r--r-- | sway/layout.c | 4 |
4 files changed, 26 insertions, 9 deletions
diff --git a/include/extensions.h b/include/extensions.h index 67c7d5fe..164688ee 100644 --- a/include/extensions.h +++ b/include/extensions.h | |||
@@ -14,10 +14,13 @@ struct background_config { | |||
14 | }; | 14 | }; |
15 | 15 | ||
16 | struct panel_config { | 16 | struct panel_config { |
17 | // wayland resource used in callbacks, is used to track this panel | ||
18 | struct wl_resource *wl_resource; | ||
17 | wlc_handle output; | 19 | wlc_handle output; |
18 | wlc_resource surface; | 20 | wlc_resource surface; |
19 | // we need the wl_resource of the surface in the destructor | 21 | // we need the wl_resource of the surface in the destructor |
20 | struct wl_resource *wl_surface_res; | 22 | struct wl_resource *wl_surface_res; |
23 | enum desktop_shell_panel_position panel_position; | ||
21 | }; | 24 | }; |
22 | 25 | ||
23 | struct desktop_shell_state { | 26 | struct desktop_shell_state { |
@@ -25,7 +28,6 @@ struct desktop_shell_state { | |||
25 | list_t *panels; | 28 | list_t *panels; |
26 | list_t *lock_surfaces; | 29 | list_t *lock_surfaces; |
27 | bool is_locked; | 30 | bool is_locked; |
28 | enum desktop_shell_panel_position panel_position; | ||
29 | struct wlc_size panel_size; | 31 | struct wlc_size panel_size; |
30 | }; | 32 | }; |
31 | 33 | ||
diff --git a/sway/extensions.c b/sway/extensions.c index d37eaddd..00a72a80 100644 --- a/sway/extensions.c +++ b/sway/extensions.c | |||
@@ -9,6 +9,21 @@ | |||
9 | 9 | ||
10 | struct desktop_shell_state desktop_shell; | 10 | struct desktop_shell_state desktop_shell; |
11 | 11 | ||
12 | static struct panel_config *find_or_create_panel_config(struct wl_resource *resource) { | ||
13 | for (int i = 0; i < desktop_shell.panels->length; i++) { | ||
14 | struct panel_config *conf = desktop_shell.panels->items[i]; | ||
15 | if (conf->wl_resource == resource) { | ||
16 | sway_log(L_DEBUG, "Found existing panel config for resource %p", resource); | ||
17 | return conf; | ||
18 | } | ||
19 | } | ||
20 | sway_log(L_DEBUG, "Creating panel config for resource %p", resource); | ||
21 | struct panel_config *config = calloc(1, sizeof(struct panel_config)); | ||
22 | list_add(desktop_shell.panels, config); | ||
23 | config->wl_resource = resource; | ||
24 | return config; | ||
25 | } | ||
26 | |||
12 | void background_surface_destructor(struct wl_resource *resource) { | 27 | void background_surface_destructor(struct wl_resource *resource) { |
13 | sway_log(L_DEBUG, "Background surface killed"); | 28 | sway_log(L_DEBUG, "Background surface killed"); |
14 | int i; | 29 | int i; |
@@ -69,12 +84,11 @@ static void set_panel(struct wl_client *client, struct wl_resource *resource, | |||
69 | if (!output) { | 84 | if (!output) { |
70 | return; | 85 | return; |
71 | } | 86 | } |
72 | sway_log(L_DEBUG, "Setting surface %p as panel for output %d", surface, (int)output); | 87 | sway_log(L_DEBUG, "Setting surface %p as panel for output %d (wl_resource: %p)", surface, (int)output, resource); |
73 | struct panel_config *config = malloc(sizeof(struct panel_config)); | 88 | struct panel_config *config = find_or_create_panel_config(resource); |
74 | config->output = output; | 89 | config->output = output; |
75 | config->surface = wlc_resource_from_wl_surface_resource(surface); | 90 | config->surface = wlc_resource_from_wl_surface_resource(surface); |
76 | config->wl_surface_res = surface; | 91 | config->wl_surface_res = surface; |
77 | list_add(desktop_shell.panels, config); | ||
78 | wl_resource_set_destructor(surface, panel_surface_destructor); | 92 | wl_resource_set_destructor(surface, panel_surface_destructor); |
79 | desktop_shell.panel_size = *wlc_surface_get_size(config->surface); | 93 | desktop_shell.panel_size = *wlc_surface_get_size(config->surface); |
80 | arrange_windows(&root_container, -1, -1); | 94 | arrange_windows(&root_container, -1, -1); |
@@ -121,7 +135,9 @@ static void desktop_ready(struct wl_client *client, struct wl_resource *resource | |||
121 | } | 135 | } |
122 | 136 | ||
123 | static void set_panel_position(struct wl_client *client, struct wl_resource *resource, uint32_t position) { | 137 | static void set_panel_position(struct wl_client *client, struct wl_resource *resource, uint32_t position) { |
124 | desktop_shell.panel_position = position; | 138 | struct panel_config *config = find_or_create_panel_config(resource); |
139 | sway_log(L_DEBUG, "Panel position for wl_resource %p changed %d => %d", resource, config->panel_position, position); | ||
140 | config->panel_position = position; | ||
125 | arrange_windows(&root_container, -1, -1); | 141 | arrange_windows(&root_container, -1, -1); |
126 | } | 142 | } |
127 | 143 | ||
@@ -174,7 +190,6 @@ void register_extensions(void) { | |||
174 | wl_global_create(wlc_get_wl_display(), &desktop_shell_interface, 3, NULL, desktop_shell_bind); | 190 | wl_global_create(wlc_get_wl_display(), &desktop_shell_interface, 3, NULL, desktop_shell_bind); |
175 | desktop_shell.backgrounds = create_list(); | 191 | desktop_shell.backgrounds = create_list(); |
176 | desktop_shell.panels = create_list(); | 192 | desktop_shell.panels = create_list(); |
177 | desktop_shell.panel_position = DESKTOP_SHELL_PANEL_POSITION_BOTTOM; | ||
178 | desktop_shell.lock_surfaces = create_list(); | 193 | desktop_shell.lock_surfaces = create_list(); |
179 | desktop_shell.is_locked = false; | 194 | desktop_shell.is_locked = false; |
180 | wl_global_create(wlc_get_wl_display(), &lock_interface, 1, NULL, swaylock_bind); | 195 | wl_global_create(wlc_get_wl_display(), &lock_interface, 1, NULL, swaylock_bind); |
diff --git a/sway/handlers.c b/sway/handlers.c index 3161c677..751e894c 100644 --- a/sway/handlers.c +++ b/sway/handlers.c | |||
@@ -90,7 +90,7 @@ static void handle_output_pre_render(wlc_handle output) { | |||
90 | struct wlc_geometry geo = { | 90 | struct wlc_geometry geo = { |
91 | .size = size | 91 | .size = size |
92 | }; | 92 | }; |
93 | switch (desktop_shell.panel_position) { | 93 | switch (config->panel_position) { |
94 | case DESKTOP_SHELL_PANEL_POSITION_TOP: | 94 | case DESKTOP_SHELL_PANEL_POSITION_TOP: |
95 | geo.origin = (struct wlc_point){ 0, 0 }; | 95 | geo.origin = (struct wlc_point){ 0, 0 }; |
96 | break; | 96 | break; |
diff --git a/sway/layout.c b/sway/layout.c index 5b7dc486..6d82921c 100644 --- a/sway/layout.c +++ b/sway/layout.c | |||
@@ -455,8 +455,8 @@ static void arrange_windows_r(swayc_t *container, double width, double height) { | |||
455 | struct panel_config *config = desktop_shell.panels->items[i]; | 455 | struct panel_config *config = desktop_shell.panels->items[i]; |
456 | if (config->output == output->handle) { | 456 | if (config->output == output->handle) { |
457 | struct wlc_size size = *wlc_surface_get_size(config->surface); | 457 | struct wlc_size size = *wlc_surface_get_size(config->surface); |
458 | sway_log(L_DEBUG, "-> Found panel for this workspace: %ux%u, position: %u", size.w, size.h, desktop_shell.panel_position); | 458 | sway_log(L_DEBUG, "-> Found panel for this workspace: %ux%u, position: %u", size.w, size.h, config->panel_position); |
459 | switch (desktop_shell.panel_position) { | 459 | switch (config->panel_position) { |
460 | case DESKTOP_SHELL_PANEL_POSITION_TOP: | 460 | case DESKTOP_SHELL_PANEL_POSITION_TOP: |
461 | y += size.h; height -= size.h; | 461 | y += size.h; height -= size.h; |
462 | break; | 462 | break; |