From fb7118ff1c8f0dcd61f15e51b193512283d83fa1 Mon Sep 17 00:00:00 2001
From: Kristóf Marussy <kristof@marussy.com>
Date: Sun, 9 Jan 2022 22:16:29 +0100
Subject: build: Add eslint-plugin-unicorn
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Kristóf Marussy <kristof@marussy.com>
---
 packages/renderer/src/components/BrowserViewPlaceholder.tsx |  6 +++---
 packages/renderer/src/components/StoreProvider.tsx          |  5 +++--
 packages/renderer/src/index.tsx                             |  4 ++--
 packages/renderer/src/stores/RendererStore.ts               |  4 ++--
 packages/renderer/vite.config.js                            | 10 +++++-----
 5 files changed, 15 insertions(+), 14 deletions(-)

(limited to 'packages/renderer')

diff --git a/packages/renderer/src/components/BrowserViewPlaceholder.tsx b/packages/renderer/src/components/BrowserViewPlaceholder.tsx
index 8f055e7..58407ee 100644
--- a/packages/renderer/src/components/BrowserViewPlaceholder.tsx
+++ b/packages/renderer/src/components/BrowserViewPlaceholder.tsx
@@ -44,15 +44,15 @@ export default observer(() => {
     [store],
   );
 
-  const resizeObserverRef = useRef<ResizeObserver | null>(null);
+  const resizeObserverRef = useRef<ResizeObserver | undefined>();
 
   const ref = useCallback(
     (element: HTMLElement | null) => {
-      if (resizeObserverRef.current !== null) {
+      if (resizeObserverRef.current !== undefined) {
         resizeObserverRef.current.disconnect();
       }
       if (element === null) {
-        resizeObserverRef.current = null;
+        resizeObserverRef.current = undefined;
         return;
       }
       resizeObserverRef.current = new ResizeObserver(onResize);
diff --git a/packages/renderer/src/components/StoreProvider.tsx b/packages/renderer/src/components/StoreProvider.tsx
index bb8495c..3360a43 100644
--- a/packages/renderer/src/components/StoreProvider.tsx
+++ b/packages/renderer/src/components/StoreProvider.tsx
@@ -22,11 +22,12 @@ import React, { createContext, useContext } from 'react';
 
 import type { RendererStore } from '../stores/RendererStore';
 
-const StoreContext = createContext<RendererStore | null>(null);
+// eslint-disable-next-line unicorn/no-useless-undefined -- `createContext` expects 1 parameter.
+const StoreContext = createContext<RendererStore | undefined>(undefined);
 
 export function useStore(): RendererStore {
   const store = useContext(StoreContext);
-  if (store === null) {
+  if (store === undefined) {
     throw new Error('useStore can only be called inside of StoreProvider');
   }
   return store;
diff --git a/packages/renderer/src/index.tsx b/packages/renderer/src/index.tsx
index d900e50..a42a30c 100644
--- a/packages/renderer/src/index.tsx
+++ b/packages/renderer/src/index.tsx
@@ -45,8 +45,8 @@ if (isDevelopment) {
 const store = createAndConnectRendererStore(window.sophieRenderer);
 
 if (isDevelopment) {
-  exposeToReduxDevtools(store).catch((err) => {
-    log.error('Cannot initialize redux devtools', err);
+  exposeToReduxDevtools(store).catch((error) => {
+    log.error('Cannot initialize redux devtools', error);
   });
 }
 
diff --git a/packages/renderer/src/stores/RendererStore.ts b/packages/renderer/src/stores/RendererStore.ts
index 0b78ce1..4cc5163 100644
--- a/packages/renderer/src/stores/RendererStore.ts
+++ b/packages/renderer/src/stores/RendererStore.ts
@@ -86,8 +86,8 @@ export function createAndConnectRendererStore(
         applyPatch(store.shared, patch);
       },
     })
-    .catch((err) => {
-      log.error('Failed to connect to shared store', err);
+    .catch((error) => {
+      log.error('Failed to connect to shared store', error);
     });
 
   return store;
diff --git a/packages/renderer/vite.config.js b/packages/renderer/vite.config.js
index e20e0f1..cb0203c 100644
--- a/packages/renderer/vite.config.js
+++ b/packages/renderer/vite.config.js
@@ -1,15 +1,15 @@
 /* eslint-disable no-process-env */
 /* eslint-env node */
 
-import { builtinModules } from 'module';
-import { join } from 'path';
+import { builtinModules } from 'node:module';
+import path from 'node:path';
 
 import react from '@vitejs/plugin-react';
 
 import { banner, chrome } from '../../config/buildConstants.js';
-import fileURLToDirname from '../../config/fileURLToDirname.js';
+import fileUrlToDirname from '../../config/fileUrlToDirname.js';
 
-const thisDir = fileURLToDirname(import.meta.url);
+const thisDir = fileUrlToDirname(import.meta.url);
 
 const mode = process.env.MODE || 'development';
 
@@ -24,7 +24,7 @@ export default {
   logLevel: 'info',
   mode,
   root: thisDir,
-  cacheDir: join(thisDir, '../../.vite'),
+  cacheDir: path.join(thisDir, '../../.vite'),
   plugins: [
     react({
       babel: {
-- 
cgit v1.2.3-70-g09d2