From 044b2de8c7861504704468ba441d4a6a37eed8f7 Mon Sep 17 00:00:00 2001 From: Kristóf Marussy Date: Sun, 23 Jan 2022 17:12:47 +0100 Subject: refactor: Move runtime state into shared models MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Now the runtime state lives inside the model (instead of being associated to the static settings via a map), which simplifies state management. Static settings are now located inside the runtime models, so we must create tests to make sure that the settings are being persisted correctly. The contents of the config file are now generated as a view of store (instead of a snapshot), which adds flexibility. Signed-off-by: Kristóf Marussy --- .../main/src/stores/__tests__/SharedStore.spec.ts | 160 +++++++++++++++++++++ 1 file changed, 160 insertions(+) create mode 100644 packages/main/src/stores/__tests__/SharedStore.spec.ts (limited to 'packages/main/src/stores/__tests__/SharedStore.spec.ts') diff --git a/packages/main/src/stores/__tests__/SharedStore.spec.ts b/packages/main/src/stores/__tests__/SharedStore.spec.ts new file mode 100644 index 0000000..3ea187c --- /dev/null +++ b/packages/main/src/stores/__tests__/SharedStore.spec.ts @@ -0,0 +1,160 @@ +/* + * Copyright (C) 2021-2022 Kristóf Marussy + * + * This file is part of Sophie. + * + * Sophie is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as + * published by the Free Software Foundation, version 3. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + * + * SPDX-License-Identifier: AGPL-3.0-only + */ + +import type { ProfileConfig } from '../Profile'; +import type { ServiceConfig } from '../Service'; +import { Config, sharedStore, SharedStore } from '../SharedStore'; + +const profileProps: ProfileConfig = { + name: 'Test profile', +}; + +const serviceProps: ServiceConfig = { + name: 'Test service', + url: 'https://example.com', +}; + +let sut: SharedStore; + +beforeEach(() => { + sut = sharedStore.create(); +}); + +describe('loadConfig', () => { + it('should load profiles with an ID', () => { + sut.loadConfig({ + profiles: [ + { + id: 'someId', + ...profileProps, + }, + ], + }); + expect(sut.profiles[0].id).toBe('someId'); + }); + + it('should generate an ID for profiles without and ID', () => { + sut.loadConfig({ + profiles: [profileProps], + }); + expect(sut.profiles[0].id).toBeDefined(); + }); + + it('should load services with an ID and a profile', () => { + sut.loadConfig({ + profiles: [ + { + id: 'someProfileId', + ...profileProps, + }, + ], + services: [ + { + id: 'someServiceId', + profile: 'someProfileId', + ...serviceProps, + }, + ], + }); + expect(sut.services[0].id).toBe('someServiceId'); + expect(sut.services[0].settings.profile).toBe(sut.profiles[0]); + }); + + it('should refuse to load a profile without a name', () => { + expect(() => { + sut.loadConfig({ + profiles: [ + { + id: 'someProfileId', + ...profileProps, + name: undefined, + }, + ], + } as unknown as Config); + }).toThrow(); + expect(sut.profiles).toHaveLength(0); + }); + + it('should load services without an ID but with a profile', () => { + sut.loadConfig({ + profiles: [ + { + id: 'someProfileId', + ...profileProps, + }, + ], + services: [ + { + profile: 'someProfileId', + ...serviceProps, + }, + ], + }); + expect(sut.services[0].id).toBeDefined(); + expect(sut.services[0].settings.profile).toBe(sut.profiles[0]); + }); + + it('should create a profile for a service with an ID but no profile', () => { + sut.loadConfig({ + services: [ + { + id: 'someServiceId', + ...serviceProps, + }, + ], + }); + expect(sut.services[0].id).toBe('someServiceId'); + expect(sut.services[0].settings.profile).toBeDefined(); + expect(sut.services[0].settings.profile.settings.name).toBe( + serviceProps.name, + ); + }); + + it('should create a profile for a service without an ID or profile', () => { + sut.loadConfig({ + services: [ + { + ...serviceProps, + }, + ], + }); + expect(sut.services[0].id).toBeDefined(); + expect(sut.services[0].settings.profile).toBeDefined(); + expect(sut.services[0].settings.profile.settings.name).toBe( + serviceProps.name, + ); + }); + + it('should refuse to load a service without a name', () => { + expect(() => { + sut.loadConfig({ + services: [ + { + id: 'someServiceId', + ...serviceProps, + name: undefined, + }, + ], + } as unknown as Config); + }).toThrow(); + expect(sut.profiles).toHaveLength(0); + expect(sut.services).toHaveLength(0); + }); +}); -- cgit v1.2.3-70-g09d2