From 2a5f7e3fecc98debea2b3408662d402a1e1681a0 Mon Sep 17 00:00:00 2001 From: Kristóf Marussy Date: Mon, 28 Feb 2022 01:13:06 +0100 Subject: feat: Handle service load failures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds a "failed" state for services where the BrowserView and WebContents should be left around to keep history and allow people to navigate back. Access to the browser history otherwise doesn't seem possible (see https://github.com/electron/electron/issues/26727 and https://github.com/electron/electron/issues/7186), so destroying BrowserView and managing our own history is not possible. Also keep https://github.com/electron/electron/issues/24113 in mind. Signed-off-by: Kristóf Marussy --- packages/main/src/infrastructure/electron/types.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'packages/main/src/infrastructure/electron/types.ts') diff --git a/packages/main/src/infrastructure/electron/types.ts b/packages/main/src/infrastructure/electron/types.ts index 63974ce..7b04a6b 100644 --- a/packages/main/src/infrastructure/electron/types.ts +++ b/packages/main/src/infrastructure/electron/types.ts @@ -55,7 +55,7 @@ export interface ServiceView { readonly partitionId: string; - loadURL(url: string): Promise; + loadURL(url: string): void; goBack(): void; -- cgit v1.2.3-70-g09d2