From 523dddf8b13d85628c74bd13a7e2930a75314e7b Mon Sep 17 00:00:00 2001 From: Kristóf Marussy Date: Tue, 4 Jan 2022 01:27:02 +0100 Subject: fix: Make sure the BrowserView has integer coords MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Non-integer coordinates make electron throw the error and the reaction to synchronize the BrowserView position fail. Signed-off-by: Kristóf Marussy --- packages/renderer/src/components/BrowserViewPlaceholder.tsx | 8 ++++---- packages/shared/src/schemas.ts | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/renderer/src/components/BrowserViewPlaceholder.tsx b/packages/renderer/src/components/BrowserViewPlaceholder.tsx index 58407ee..f1b6d66 100644 --- a/packages/renderer/src/components/BrowserViewPlaceholder.tsx +++ b/packages/renderer/src/components/BrowserViewPlaceholder.tsx @@ -34,10 +34,10 @@ export default observer(() => { if (entry) { const { x, y, width, height } = entry.target.getBoundingClientRect(); store.setBrowserViewBounds({ - x, - y, - width, - height, + x: Math.round(x), + y: Math.round(y), + width: Math.round(width), + height: Math.round(height), }); } }, 100), diff --git a/packages/shared/src/schemas.ts b/packages/shared/src/schemas.ts index 9090486..2f108bd 100644 --- a/packages/shared/src/schemas.ts +++ b/packages/shared/src/schemas.ts @@ -21,10 +21,10 @@ import { z } from 'zod'; export const browserViewBounds = z.object({ - x: z.number().nonnegative(), - y: z.number().nonnegative(), - width: z.number().nonnegative(), - height: z.number().nonnegative(), + x: z.number().int().nonnegative(), + y: z.number().int().nonnegative(), + width: z.number().int().nonnegative(), + height: z.number().int().nonnegative(), }); export type BrowserViewBounds = z.infer; -- cgit v1.2.3-54-g00ecf