| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| | |
|
| |
|
|
|
|
| |
This would run as part of gitlab SAST (if it didn't time out).
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
|
| |
eslint will also enforce prettier rules, so there is no need to call
prettier separately in CI.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
|
|
|
| |
See https://github.com/typescript-eslint/typescript-eslint/issues/3851
Also upgrades dependencies and simplifies eslint config (used during
debugging this issue to eliminate other possible sources of errors.)
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| | |
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| |
|
|
| |
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
| |
Signed-off-by: Vijay A <vraravam@users.noreply.github.com>
|
| |
|
|
|
|
|
|
| |
- Remove unnecessary plugins array in esbuild config.
- Use vite linked deps for shared packages:
https://github.com/vitejs/vite/issues/195#issuecomment-637725505
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
| |
Test devDependencies in the main package were incorrect.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
On the first startup in dev mode, Electron must be able to download the
devtools extensions and wait for them to be installed.
Loosens the UI process request filter a bit, but the behavior should
match production mode in all cases except chrome webstore URLs.
Nevertheless, only production mode should be considered secure.
Fixes #6
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
| |
Fixes #5
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| |
|
|
|
|
| |
Also changes the default browserview contents to the gitlab repo.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
|
| | |
|
| |
|
|
| |
yarn typecheck still throw an unstable feature warning.
|
| | |
|
| |
|
|
|
| |
The renderer package still has to use node module resolution to be able
to find MUI packages.
|
| | |
|
| |
|
|
| |
Requires some workarounds for ts-jest to find the vendored dependencies.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
- Changed jest to run from the root package and reference the packages
as projects. This required moving the base jest config file away from
the project root.
- Module isolation seems to prevent ts-jest from loading the shared
package, so we disabled it for now.
- To better facilitate mocking, services should be split into interfaces
and implementation
- Had to downgrade to chald 4.1.2 as per
https://github.com/chalk/chalk/releases/tag/v5.0.0 at least until
https://github.com/microsoft/TypeScript/issues/46452 is resolved.
|
| |
|
|
|
|
| |
This doesn't seem to cause any race conditions (except for the warnings
that appear even if we install the extensions before initializing the
main window and are ignored by yarn watch).
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we can run with ESM at build and test time and transpile into
commonjs for electron. This greatly simplifies testing, since we treat
everything as ESM during build with esbuild anyways. Now the test
environment and the build scripts match the apparent (but not the actual
for the main, preload, and inject modules) runtime environment.
Caveats:
- We may use top-level async expressions in tests and script, but not in
code that gets transpiled into commonjs or scripts that get imported
by vite. The limitation w.r.t. commonjs seems fundamental.
- Jest only experimentally supports ESM and there are some limitations
with mocking. Most limitations (except the lack of automatic mocks)
can be worked around by async importing code that uses mocks.
- There are packages marked as modules (so that node reads any scripts
in them as ESM) that nevertheless get transpiled into commonjs
modules. However, these should be clearly marked by using a .cjs
extension as their bundle. The worst offender is the root package,
which has a .cjs as its main entry point that gets read by electron,
but is in fact marked as a module. This doesn't seem to bother electron
at all. The service-inject package is an IIFE with a .js extension,
but it outputs a fully self-contained bundle, so the choice of module
format should be irrelevant.
|
| |
|
|
|
| |
The rest of the packages aren't buld with vite, so we shouldn't use its
typings.
|
| |
|
|
|
|
|
|
|
|
| |
By running the build for the shared packages only once, errors in them
are reported only once in watch mode.
We still have to point jest to the original source files (and rebuild
the shared source files as part of the test), because it won't load the
"module" entry of the shared packages. However, as a benefit, jest can
now run even if the shared packages haven't been built yet.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
We will build all packages except the frontend (where vite remains in
use) with esbuild.
For some reason, the @yarnpkg/esbuild-plugin-pnp doesn't allow esbuild
to load esm modules and we fall back to commonjs for dependencies.
Hence we had to switch back to node_modules (but still rely on yarn
hardlinking for a more efficient install).
|
| |
|
|
| |
This reverts commit 5c38af061348ec604337280009775832edc66270.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
Depfu Bot
Kristóf Marussy
Vijay A
Vijay A