test: Add tests for main package

- Changed jest to run from the root package and reference the packages
  as projects. This required moving the base jest config file away from
  the project root.
- Module isolation seems to prevent ts-jest from loading the shared
  package, so we disabled it for now.
- To better facilitate mocking, services should be split into interfaces
  and implementation
- Had to downgrade to chald 4.1.2 as per
  https://github.com/chalk/chalk/releases/tag/v5.0.0 at least until
  https://github.com/microsoft/TypeScript/issues/46452 is resolved.

5 files changed, 27 insertions, 22 deletions

diff --git a/packages/preload/esbuild.config.js b/packages/preload/esbuild.config.js
index de51fc5..b73a071 100644
--- a/packages/preload/esbuild.config.js
+++ b/packages/preload/esbuild.config.js
@@ -1,5 +1,6 @@
-import { chrome, fileURLToDirname } from '../../config/build-common.js';
-import { getConfig } from '../../config/esbuild-config.js';
+import { chrome } from '../../config/buildConstants.js';
+import { getConfig } from '../../config/esbuildConfig.js';
+import { fileURLToDirname } from '../../config/utils.js';
 
 export default getConfig({
   absWorkingDir: fileURLToDirname(import.meta.url),
diff --git a/packages/preload/jest.config.js b/packages/preload/jest.config.js
index faecf9a..e474c4c 100644
--- a/packages/preload/jest.config.js
+++ b/packages/preload/jest.config.js
@@ -1,4 +1,4 @@
-import rootConfig from '../../jest.config.js';
+import rootConfig from '../../config/jest.config.base.js';
 
 /** @type {import('ts-jest').InitialOptionsTsJest} */
 export default {
diff --git a/packages/preload/package.json b/packages/preload/package.json
index e6dd0ee..9818ba8 100644
--- a/packages/preload/package.json
+++ b/packages/preload/package.json
@@ -6,7 +6,6 @@
   "type": "module",
   "types": "dist-types/index.d.ts",
   "scripts": {
-    "test": "node --experimental-vm-modules ../../node_modules/jest/bin/jest.js",
     "typecheck": "tsc"
   },
   "dependencies": {
@@ -16,7 +15,7 @@
     "mobx-state-tree": "^5.1.0"
   },
   "devDependencies": {
-    "@types/jest": "^27.0.3",
+    "@types/jest": "^27.4.0",
     "jest": "^27.4.5",
     "jest-mock": "^27.4.2",
     "jsdom": "^19.0.0",
diff --git a/packages/preload/src/contextBridge/__tests__/SophieRendererImpl.spec.ts b/packages/preload/src/contextBridge/__tests__/SophieRendererImpl.spec.ts
index 41937c2..fdd1cc5 100644
--- a/packages/preload/src/contextBridge/__tests__/SophieRendererImpl.spec.ts
+++ b/packages/preload/src/contextBridge/__tests__/SophieRendererImpl.spec.ts
@@ -18,7 +18,7 @@
  * SPDX-License-Identifier: AGPL-3.0-only
  */
 
-import { describe, it, jest } from '@jest/globals';
+import { jest } from '@jest/globals';
 import { mocked } from 'jest-mock';
 import log from 'loglevel';
 import type { IJsonPatch } from 'mobx-state-tree';
@@ -67,7 +67,9 @@ const invalidAction = {
   action: 'not-a-valid-action',
 } as unknown as Action;
 
-log.disableAll();
+beforeAll(() => {
+  log.disableAll();
+});
 
 describe('createSophieRenderer', () => {
   it('registers a shared store patch listener', () => {
@@ -95,59 +97,59 @@ describe('SophieRendererImpl', () => {
   });
 
   describe('onSharedStoreChange', () => {
-    it('requests a snapshot from the main process', async () => {
+    it('should request a snapshot from the main process', async () => {
       mocked(ipcRenderer.invoke).mockResolvedValueOnce(snapshot);
       await sut.onSharedStoreChange(listener);
       expect(ipcRenderer.invoke).toBeCalledWith(RendererToMainIpcMessage.GetSharedStoreSnapshot);
       expect(listener.onSnapshot).toBeCalledWith(snapshot);
     });
 
-    it('catches IPC errors without exposing them', async () => {
+    it('should catch IPC errors without exposing them', async () => {
       mocked(ipcRenderer.invoke).mockRejectedValue(new Error('s3cr3t'));
       await expect(sut.onSharedStoreChange(listener)).rejects.not.toHaveProperty(
         'message',
         expect.stringMatching(/s3cr3t/),
       );
-      expect(listener.onSnapshot).toBeCalledTimes(0);
+      expect(listener.onSnapshot).not.toBeCalled();
     });
 
-    it('does not pass on invalid snapshots', async () => {
+    it('should not pass on invalid snapshots', async () => {
       mocked(ipcRenderer.invoke).mockResolvedValueOnce(invalidSnapshot);
       await expect(sut.onSharedStoreChange(listener)).rejects.toBeInstanceOf(Error);
-      expect(listener.onSnapshot).toBeCalledTimes(0);
+      expect(listener.onSnapshot).not.toBeCalled();
     });
   });
 
   describe('dispatchAction', () => {
-    it('dispatched valid actions', () => {
+    it('should dispatch valid actions', () => {
       sut.dispatchAction(action);
       expect(ipcRenderer.send).toBeCalledWith(RendererToMainIpcMessage.DispatchAction, action);
     });
 
-    it('does not dispatch invalid actions', () => {
+    it('should not dispatch invalid actions', () => {
       expect(() => sut.dispatchAction(invalidAction)).toThrowError();
-      expect(ipcRenderer.send).toBeCalledTimes(0);
+      expect(ipcRenderer.send).not.toBeCalled();
     });
   });
 
   describe('when no listener is registered', () => {
-    it('discards the received patch without any error', () => {
+    it('should discard the received patch without any error', () => {
       onSharedStorePatch(event, patch);
     });
   });
 
   function itRefusesToRegisterAnotherListener() {
-    it('refuses to register another listener', async () => {
+    it('should refuse to register another listener', async () => {
       await expect(sut.onSharedStoreChange(listener)).rejects.toBeInstanceOf(Error);
     });
   }
 
   function itDoesNotPassPatchesToTheListener(
-    name: string = 'does not pass patches to the listener',
+    name: string = 'should not pass patches to the listener',
   ) {
     it(name, () => {
       onSharedStorePatch(event, patch);
-      expect(listener.onPatch).toBeCalledTimes(0);
+      expect(listener.onPatch).not.toBeCalled();
     });
   }
 
@@ -157,12 +159,12 @@ describe('SophieRendererImpl', () => {
       await sut.onSharedStoreChange(listener);
     });
 
-    it('passes patches to the listener', () => {
+    it('should pass patches to the listener', () => {
       onSharedStorePatch(event, patch);
       expect(listener.onPatch).toBeCalledWith(patch);
     });
 
-    it('catches listener errors', () => {
+    it('should catch listener errors', () => {
       mocked(listener.onPatch).mockImplementation(() => { throw new Error(); });
       onSharedStorePatch(event, patch);
     });
@@ -176,7 +178,7 @@ describe('SophieRendererImpl', () => {
         listener.onPatch.mockRestore();
       });
 
-      itDoesNotPassPatchesToTheListener('does not pass on patches any more');
+      itDoesNotPassPatchesToTheListener('should not pass on patches any more');
     });
   });
 
diff --git a/packages/preload/tsconfig.json b/packages/preload/tsconfig.json
index 0f27305..741d435 100644
--- a/packages/preload/tsconfig.json
+++ b/packages/preload/tsconfig.json
@@ -6,6 +6,9 @@
       "dom",
       "dom.iterable",
       "esnext"
+    ],
+    "types": [
+      "@types/jest"
     ]
   },
   "references": [