diff options
author | Kristóf Marussy <kristof@marussy.com> | 2022-04-24 20:11:21 +0200 |
---|---|---|
committer | Kristóf Marussy <kristof@marussy.com> | 2022-05-16 00:55:02 +0200 |
commit | 5725cebec015b90a33c17a8f684bd345dc239934 (patch) | |
tree | 7d248757bc43c25240c59c9cdb0da7bf527e3990 /packages/main/src | |
parent | refactor: reduce service switcher tearing (diff) | |
download | sophie-5725cebec015b90a33c17a8f684bd345dc239934.tar.gz sophie-5725cebec015b90a33c17a8f684bd345dc239934.tar.zst sophie-5725cebec015b90a33c17a8f684bd345dc239934.zip |
chore(deps): remove ms to reduce dependency count
We can trivially do what it does, and removing it reduces the amount
of external dependencies running in the security-sensitive context of
the main process.
Signed-off-by: Kristóf Marussy <kristof@marussy.com>
Diffstat (limited to 'packages/main/src')
-rw-r--r-- | packages/main/src/i18n/RepositoryBasedI18nBackend.ts | 5 | ||||
-rw-r--r-- | packages/main/src/reactions/__tests__/synchronizeConfig.spec.ts | 5 | ||||
-rw-r--r-- | packages/main/src/reactions/synchronizeConfig.ts | 5 |
3 files changed, 6 insertions, 9 deletions
diff --git a/packages/main/src/i18n/RepositoryBasedI18nBackend.ts b/packages/main/src/i18n/RepositoryBasedI18nBackend.ts index 4d87ce9..1f7bf5d 100644 --- a/packages/main/src/i18n/RepositoryBasedI18nBackend.ts +++ b/packages/main/src/i18n/RepositoryBasedI18nBackend.ts | |||
@@ -25,13 +25,12 @@ import type { | |||
25 | Services, | 25 | Services, |
26 | } from 'i18next'; | 26 | } from 'i18next'; |
27 | import { debounce } from 'lodash-es'; | 27 | import { debounce } from 'lodash-es'; |
28 | import ms from 'ms'; | ||
29 | 28 | ||
30 | import { getLogger } from '../utils/log'; | 29 | import { getLogger } from '../utils/log'; |
31 | 30 | ||
32 | import type LocatlizationRepository from './LocalizationRepository'; | 31 | import type LocatlizationRepository from './LocalizationRepository'; |
33 | 32 | ||
34 | const MISSING_ENTRIES_DEBOUNCE_TIME = ms('1s'); | 33 | const MISSING_ENTRIES_DEBOUNCE_TIME_MS = 1000; |
35 | 34 | ||
36 | const log = getLogger('RepositoryBasedI18nBackend'); | 35 | const log = getLogger('RepositoryBasedI18nBackend'); |
37 | 36 | ||
@@ -72,7 +71,7 @@ export default class RepositoryBasedI18nBackend | |||
72 | 71 | ||
73 | private readonly flushWriteQueue = debounce( | 72 | private readonly flushWriteQueue = debounce( |
74 | this.flushWriteQueueImmediately, | 73 | this.flushWriteQueueImmediately, |
75 | MISSING_ENTRIES_DEBOUNCE_TIME, | 74 | MISSING_ENTRIES_DEBOUNCE_TIME_MS, |
76 | ); | 75 | ); |
77 | 76 | ||
78 | constructor( | 77 | constructor( |
diff --git a/packages/main/src/reactions/__tests__/synchronizeConfig.spec.ts b/packages/main/src/reactions/__tests__/synchronizeConfig.spec.ts index c145bf3..b5013ea 100644 --- a/packages/main/src/reactions/__tests__/synchronizeConfig.spec.ts +++ b/packages/main/src/reactions/__tests__/synchronizeConfig.spec.ts | |||
@@ -20,7 +20,6 @@ | |||
20 | 20 | ||
21 | import { jest } from '@jest/globals'; | 21 | import { jest } from '@jest/globals'; |
22 | import { mocked } from 'jest-mock'; | 22 | import { mocked } from 'jest-mock'; |
23 | import ms from 'ms'; | ||
24 | 23 | ||
25 | import type ConfigRepository from '../../infrastructure/config/ConfigRepository'; | 24 | import type ConfigRepository from '../../infrastructure/config/ConfigRepository'; |
26 | import SharedStore from '../../stores/SharedStore'; | 25 | import SharedStore from '../../stores/SharedStore'; |
@@ -34,8 +33,8 @@ const repository: ConfigRepository = { | |||
34 | writeConfig: jest.fn(), | 33 | writeConfig: jest.fn(), |
35 | watchConfig: jest.fn(), | 34 | watchConfig: jest.fn(), |
36 | }; | 35 | }; |
37 | const lessThanThrottleMs = ms('0.1s'); | 36 | const lessThanThrottleMs = 100; |
38 | const throttleMs = ms('1s'); | 37 | const throttleMs = 1000; |
39 | 38 | ||
40 | beforeAll(() => { | 39 | beforeAll(() => { |
41 | jest.useFakeTimers(); | 40 | jest.useFakeTimers(); |
diff --git a/packages/main/src/reactions/synchronizeConfig.ts b/packages/main/src/reactions/synchronizeConfig.ts index 9436c16..adbe712 100644 --- a/packages/main/src/reactions/synchronizeConfig.ts +++ b/packages/main/src/reactions/synchronizeConfig.ts | |||
@@ -21,7 +21,6 @@ | |||
21 | import deepEqual from 'deep-equal'; | 21 | import deepEqual from 'deep-equal'; |
22 | import { debounce } from 'lodash-es'; | 22 | import { debounce } from 'lodash-es'; |
23 | import { reaction } from 'mobx'; | 23 | import { reaction } from 'mobx'; |
24 | import ms from 'ms'; | ||
25 | 24 | ||
26 | import type ConfigRepository from '../infrastructure/config/ConfigRepository'; | 25 | import type ConfigRepository from '../infrastructure/config/ConfigRepository'; |
27 | import type SharedStore from '../stores/SharedStore'; | 26 | import type SharedStore from '../stores/SharedStore'; |
@@ -29,14 +28,14 @@ import type Config from '../stores/config/Config'; | |||
29 | import type Disposer from '../utils/Disposer'; | 28 | import type Disposer from '../utils/Disposer'; |
30 | import { getLogger } from '../utils/log'; | 29 | import { getLogger } from '../utils/log'; |
31 | 30 | ||
32 | const DEFAULT_CONFIG_DEBOUNCE_TIME = ms('1s'); | 31 | const DEFAULT_CONFIG_DEBOUNCE_TIME_MS = 1000; |
33 | 32 | ||
34 | const log = getLogger('synchronizeConfig'); | 33 | const log = getLogger('synchronizeConfig'); |
35 | 34 | ||
36 | export default async function synchronizeConfig( | 35 | export default async function synchronizeConfig( |
37 | sharedStore: SharedStore, | 36 | sharedStore: SharedStore, |
38 | repository: ConfigRepository, | 37 | repository: ConfigRepository, |
39 | debounceTime: number = DEFAULT_CONFIG_DEBOUNCE_TIME, | 38 | debounceTime: number = DEFAULT_CONFIG_DEBOUNCE_TIME_MS, |
40 | ): Promise<Disposer> { | 39 | ): Promise<Disposer> { |
41 | let lastConfigOnDisk: Config | undefined; | 40 | let lastConfigOnDisk: Config | undefined; |
42 | 41 | ||