refactor: more direct access to VIATRA result set

Accessing VIATRA result sets through IQueryResultProvider requires a lot
of indirection, allocations, and locking.

We use reflection instead to have direct access to the underlying
Indexer instead.

Unfortunately, projection to arbitrary tuple masks (with wildcard
entries in a tuple) is completely broken in VIATRA when RETE update
propagation is delayed. While a new, ad-hoc projection indexer gets
added to the RETE net immediately, it is not populated with the
projection results until updates are flushed in the query engine.
Therefore, when encountering an ad-hoc projection for the first time,
the projection results will always be empty (thus usually out of date).

While declaring the desired projections ahead of time would be a
possible solution, for now, we completely remove ad-hoc projection
support. If projections are needed on the ModelQuery level, we should
create an API for declaring projections for each registered Dnf.

1 files changed, 5 insertions, 2 deletions

diff --git a/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/QueryTest.java b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/QueryTest.java
index 54ae70c3..3dd517c4 100644
--- a/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/QueryTest.java
+++ b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/QueryTest.java
@@ -16,8 +16,7 @@ import java.util.HashSet;
 import java.util.Set;
 import java.util.stream.Stream;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.*;
 import static tools.refinery.store.query.literal.Literals.not;
 
 class QueryTest {
@@ -97,10 +96,14 @@ class QueryTest {
                 friendInterpretation.put(Tuple.of(1, 2), TruthValue.TRUE);
 
                 assertEquals(0, predicateResultSet.countResults());
+                assertFalse(predicateResultSet.hasResult(Tuple.of(0, 1)));
+                assertFalse(predicateResultSet.hasResult(Tuple.of(0, 2)));
 
                 queryEngine.flushChanges();
                 assertEquals(3, predicateResultSet.countResults());
                 compareMatchSets(predicateResultSet.allResults(), Set.of(Tuple.of(0, 1), Tuple.of(1, 0), Tuple.of(1, 2)));
+                assertTrue(predicateResultSet.hasResult(Tuple.of(0, 1)));
+                assertFalse(predicateResultSet.hasResult(Tuple.of(0, 2)));
         }
 
         @Test