refactor: remove TupleLike

* Directly transform VIATRA tuples into Refinery tuples, since creating
  the additional wrapper object doesn't save any memory.
* Adds static arity Tuple3 and Tuple4 implementations to be more
  aligned with VIATRA internals and save memory for queries with up to
  4 parameters.
* Makes sure no new objects are allocated (for varargs handling) when a
  static arity tuple is hashed.

2 files changed, 235 insertions, 1 deletions

diff --git a/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/internal/matcher/MatcherUtilsTest.java b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/internal/matcher/MatcherUtilsTest.java
new file mode 100644
index 00000000..ea0b15ec
--- /dev/null
+++ b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/internal/matcher/MatcherUtilsTest.java
@@ -0,0 +1,234 @@
+package tools.refinery.store.query.viatra.internal.matcher;
+
+import org.eclipse.viatra.query.runtime.matchers.tuple.*;
+import org.junit.jupiter.api.Test;
+import tools.refinery.store.tuple.Tuple;
+import tools.refinery.store.tuple.*;
+
+import java.util.List;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.*;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+class MatcherUtilsTest {
+        @Test
+        void toViatra0Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of());
+                assertThat(viatraTuple.getSize(), is(0));
+                assertThat(viatraTuple, instanceOf(FlatTuple0.class));
+        }
+
+        @Test
+        void toViatra1Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of(2));
+                assertThat(viatraTuple.getSize(), is(1));
+                assertThat(viatraTuple.get(0), is(Tuple.of(2)));
+                assertThat(viatraTuple, instanceOf(FlatTuple1.class));
+        }
+
+        @Test
+        void toViatra2Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of(2, 3));
+                assertThat(viatraTuple.getSize(), is(2));
+                assertThat(viatraTuple.get(0), is(Tuple.of(2)));
+                assertThat(viatraTuple.get(1), is(Tuple.of(3)));
+                assertThat(viatraTuple, instanceOf(FlatTuple2.class));
+        }
+
+        @Test
+        void toViatra3Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of(2, 3, 5));
+                assertThat(viatraTuple.getSize(), is(3));
+                assertThat(viatraTuple.get(0), is(Tuple.of(2)));
+                assertThat(viatraTuple.get(1), is(Tuple.of(3)));
+                assertThat(viatraTuple.get(2), is(Tuple.of(5)));
+                assertThat(viatraTuple, instanceOf(FlatTuple3.class));
+        }
+
+        @Test
+        void toViatra4Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of(2, 3, 5, 8));
+                assertThat(viatraTuple.getSize(), is(4));
+                assertThat(viatraTuple.get(0), is(Tuple.of(2)));
+                assertThat(viatraTuple.get(1), is(Tuple.of(3)));
+                assertThat(viatraTuple.get(2), is(Tuple.of(5)));
+                assertThat(viatraTuple.get(3), is(Tuple.of(8)));
+                assertThat(viatraTuple, instanceOf(FlatTuple4.class));
+        }
+
+        @Test
+        void toViatra5Test() {
+                var viatraTuple = MatcherUtils.toViatraTuple(Tuple.of(2, 3, 5, 8, 13));
+                assertThat(viatraTuple.getSize(), is(5));
+                assertThat(viatraTuple.get(0), is(Tuple.of(2)));
+                assertThat(viatraTuple.get(1), is(Tuple.of(3)));
+                assertThat(viatraTuple.get(2), is(Tuple.of(5)));
+                assertThat(viatraTuple.get(3), is(Tuple.of(8)));
+                assertThat(viatraTuple.get(4), is(Tuple.of(13)));
+                assertThat(viatraTuple, instanceOf(FlatTuple.class));
+        }
+
+        @Test
+        void toRefinery0Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf());
+                assertThat(refineryTuple.getSize(), is(0));
+                assertThat(refineryTuple, instanceOf(Tuple0.class));
+        }
+
+        @Test
+        void toRefinery1Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf(Tuple.of(2)));
+                assertThat(refineryTuple.getSize(), is(1));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple, instanceOf(Tuple1.class));
+        }
+
+        @Test
+        void toRefinery2Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3)));
+                assertThat(refineryTuple.getSize(), is(2));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple, instanceOf(Tuple2.class));
+        }
+
+        @Test
+        void toRefinery3Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5)));
+                assertThat(refineryTuple.getSize(), is(3));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple, instanceOf(Tuple3.class));
+        }
+
+        @Test
+        void toRefinery4Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5),
+                                Tuple.of(8)));
+                assertThat(refineryTuple.getSize(), is(4));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple.get(3), is(8));
+                assertThat(refineryTuple, instanceOf(Tuple4.class));
+        }
+
+        @Test
+        void toRefinery5Test() {
+                var refineryTuple = MatcherUtils.toRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5),
+                                Tuple.of(8), Tuple.of(13)));
+                assertThat(refineryTuple.getSize(), is(5));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple.get(3), is(8));
+                assertThat(refineryTuple.get(4), is(13));
+                assertThat(refineryTuple, instanceOf(TupleN.class));
+        }
+
+        @Test
+        void toRefineryInvalidValueTest() {
+                var viatraTuple = Tuples.flatTupleOf(Tuple.of(2), -98);
+                assertThrows(IllegalArgumentException.class, () -> MatcherUtils.toRefineryTuple(viatraTuple));
+        }
+
+        @Test
+        void keyToRefinery0Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(-99));
+                assertThat(refineryTuple.getSize(), is(0));
+                assertThat(refineryTuple, instanceOf(Tuple0.class));
+        }
+
+        @Test
+        void keyToRefinery1Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), -99));
+                assertThat(refineryTuple.getSize(), is(1));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple, instanceOf(Tuple1.class));
+        }
+
+        @Test
+        void keyToRefinery2Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), -99));
+                assertThat(refineryTuple.getSize(), is(2));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple, instanceOf(Tuple2.class));
+        }
+
+        @Test
+        void keyToRefinery3Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5),
+                                -99));
+                assertThat(refineryTuple.getSize(), is(3));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple, instanceOf(Tuple3.class));
+        }
+
+        @Test
+        void keyToRefinery4Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5),
+                                Tuple.of(8), -99));
+                assertThat(refineryTuple.getSize(), is(4));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple.get(3), is(8));
+                assertThat(refineryTuple, instanceOf(Tuple4.class));
+        }
+
+        @Test
+        void keyToRefinery5Test() {
+                var refineryTuple = MatcherUtils.keyToRefineryTuple(Tuples.flatTupleOf(Tuple.of(2), Tuple.of(3), Tuple.of(5),
+                                Tuple.of(8), Tuple.of(13), -99));
+                assertThat(refineryTuple.getSize(), is(5));
+                assertThat(refineryTuple.get(0), is(2));
+                assertThat(refineryTuple.get(1), is(3));
+                assertThat(refineryTuple.get(2), is(5));
+                assertThat(refineryTuple.get(3), is(8));
+                assertThat(refineryTuple.get(4), is(13));
+                assertThat(refineryTuple, instanceOf(TupleN.class));
+        }
+
+        @Test
+        void keyToRefineryTooShortTest() {
+                var viatraTuple = Tuples.flatTupleOf();
+                assertThrows(IllegalArgumentException.class, () -> MatcherUtils.keyToRefineryTuple(viatraTuple));
+        }
+
+        @Test
+        void keyToRefineryInvalidValueTest() {
+                var viatraTuple = Tuples.flatTupleOf(Tuple.of(2), -98, -99);
+                assertThrows(IllegalArgumentException.class, () -> MatcherUtils.keyToRefineryTuple(viatraTuple));
+        }
+
+        @Test
+        void getSingleValueTest() {
+                var value = MatcherUtils.getSingleValue(List.of(Tuples.flatTupleOf(Tuple.of(2), -99)));
+                assertThat(value, is(-99));
+        }
+
+        // Static analysis accurately determines that the result is always {@code null}, but we check anyways.
+        @SuppressWarnings("ConstantValue")
+        @Test
+        void getSingleValueNullTest() {
+                var value = MatcherUtils.getSingleValue((Iterable<? extends ITuple>) null);
+                assertThat(value, nullValue());
+        }
+
+        @Test
+        void getSingleValueEmptyTest() {
+                var value = MatcherUtils.getSingleValue(List.of());
+                assertThat(value, nullValue());
+        }
+
+        @Test
+        void getSingleValueMultipleTest() {
+                var viatraTuples = List.of(Tuples.flatTupleOf(Tuple.of(2), -98), Tuples.flatTupleOf(Tuple.of(2), -99));
+                assertThrows(IllegalStateException.class, () -> MatcherUtils.getSingleValue(viatraTuples));
+        }
+}
diff --git a/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/tests/QueryAssertions.java b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/tests/QueryAssertions.java
index 6f50ec73..2769621d 100644
--- a/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/tests/QueryAssertions.java
+++ b/subprojects/store-query-viatra/src/test/java/tools/refinery/store/query/viatra/tests/QueryAssertions.java
@@ -42,7 +42,7 @@ public final class QueryAssertions {
                 var cursor = resultSet.getAll();
                 while (cursor.move()) {
                         var key = cursor.getKey();
-                        var previous = actual.put(key.toTuple(), cursor.getValue());
+                        var previous = actual.put(key, cursor.getValue());
                         assertThat("duplicate value for key " + key, previous, nullValue());
                 }
                 executables.add(() -> assertThat("results cursor", actual, is(filteredExpected)));