refactor(semantics): simple name creation

Use a simpler data structure for constructing simple names.

1 files changed, 3 insertions, 4 deletions

diff --git a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/metadata/MetadataCreator.java b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/metadata/MetadataCreator.java
index cc262129..3694f5f4 100644
--- a/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/metadata/MetadataCreator.java
+++ b/subprojects/language-semantics/src/main/java/tools/refinery/language/semantics/metadata/MetadataCreator.java
@@ -171,16 +171,15 @@ public class MetadataCreator {
 
         private QualifiedName getSimpleName(EObject eObject, QualifiedName qualifiedName, IScope scope) {
                 var descriptions = scope.getElements(eObject);
-                var names = new HashSet<QualifiedName>();
+                var names = new ArrayList<QualifiedName>();
                 for (var description : descriptions) {
                         // {@code getQualifiedName()} will refer to the full name for objects that are loaded from the global
                         // scope, but {@code getName()} returns the qualified name that we set in
                         // {@code ProblemResourceDescriptionStrategy}.
                         names.add(description.getName());
                 }
-                var iterator = names.stream().sorted(Comparator.comparingInt(QualifiedName::getSegmentCount)).iterator();
-                while (iterator.hasNext()) {
-                        var simpleName = iterator.next();
+                names.sort(Comparator.comparingInt(QualifiedName::getSegmentCount));
+                for (var simpleName : names) {
                         if (names.contains(simpleName) && isUnique(scope, simpleName)) {
                                 return simpleName;
                         }