1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
|
/*
* Copyright (C) 2014-2016 Firejail Authors
*
* This file is part of firejail project
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include "firejail.h"
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <signal.h>
#include <stdlib.h>
#include <dirent.h>
#include <sys/mount.h>
#include <sys/wait.h>
#ifdef HAVE_X11
// return 1 if xpra is installed on the system
static int x11_check_xpra(void) {
struct stat s;
// check xpra
if (stat("/usr/bin/xpra", &s) == -1)
return 0;
return 1;
}
// return 1 if xephyr is installed on the system
static int x11_check_xephyr(void) {
struct stat s;
// check xephyr
if (stat("/usr/bin/Xephyr", &s) == -1)
return 0;
return 1;
}
// check for X11 abstract sockets
static int x11_abstract_sockets_present(void) {
char *path;
EUID_ROOT(); // grsecurity fix
FILE *fp = fopen("/proc/net/unix", "r");
EUID_USER();
if (!fp)
errExit("fopen");
while (fscanf(fp, "%*s %*s %*s %*s %*s %*s %*s %ms\n", &path) != EOF) {
if (path && strncmp(path, "@/tmp/.X11-unix/", 16) == 0) {
free(path);
fclose(fp);
return 1;
}
}
free(path);
fclose(fp);
return 0;
}
static int random_display_number(void) {
int i;
int found = 1;
int display;
for (i = 0; i < 100; i++) {
display = rand() % 1024;
if (display < 10)
continue;
char *fname;
if (asprintf(&fname, "/tmp/.X11-unix/X%d", display) == -1)
errExit("asprintf");
struct stat s;
if (stat(fname, &s) == -1) {
found = 1;
break;
}
}
if (!found) {
fprintf(stderr, "Error: cannot pick up a random X11 display number, exiting...\n");
exit(1);
}
return display;
}
#endif
// return display number, -1 if not configured
int x11_display(void) {
// extract display
char *d = getenv("DISPLAY");
if (!d)
return - 1;
int display;
int rv = sscanf(d, ":%d", &display);
if (rv != 1)
return -1;
if (arg_debug)
printf("DISPLAY %s, %d\n", d, display);
return display;
}
void fs_x11(void) {
#ifdef HAVE_X11
int display = x11_display();
if (display <= 0)
return;
char *x11file;
if (asprintf(&x11file, "/tmp/.X11-unix/X%d", display) == -1)
errExit("asprintf");
struct stat s;
if (stat(x11file, &s) == -1)
return;
// keep a copy of real /tmp/.X11-unix directory in WHITELIST_TMP_DIR
int rv = mkdir(RUN_WHITELIST_X11_DIR, 1777);
if (rv == -1)
errExit("mkdir");
if (chown(RUN_WHITELIST_X11_DIR, 0, 0) < 0)
errExit("chown");
if (chmod(RUN_WHITELIST_X11_DIR, 1777) < 0)
errExit("chmod");
if (mount("/tmp/.X11-unix", RUN_WHITELIST_X11_DIR, NULL, MS_BIND|MS_REC, NULL) < 0)
errExit("mount bind");
// mount tmpfs on /tmp/.X11-unix
if (arg_debug || arg_debug_whitelists)
printf("Mounting tmpfs on /tmp/.X11-unix directory\n");
if (mount("tmpfs", "/tmp/.X11-unix", "tmpfs", MS_NOSUID | MS_STRICTATIME | MS_REC, "mode=1777,gid=0") < 0)
errExit("mounting tmpfs on /tmp");
fs_logger("tmpfs /tmp/.X11-unix");
// create an empty file
FILE *fp = fopen(x11file, "w");
if (!fp) {
fprintf(stderr, "Error: cannot create empty file in x11 directory\n");
exit(1);
}
// set file properties
SET_PERMS_STREAM(fp, s.st_uid, s.st_gid, s.st_mode);
fclose(fp);
// mount
char *wx11file;
if (asprintf(&wx11file, "%s/X%d", RUN_WHITELIST_X11_DIR, display) == -1)
errExit("asprintf");
if (mount(wx11file, x11file, NULL, MS_BIND|MS_REC, NULL) < 0)
errExit("mount bind");
fs_logger2("whitelist", x11file);
free(x11file);
free(wx11file);
// block access to RUN_WHITELIST_X11_DIR
if (mount(RUN_RO_DIR, RUN_WHITELIST_X11_DIR, "none", MS_BIND, "mode=400,gid=0") == -1)
errExit("mount");
fs_logger2("blacklist", RUN_WHITELIST_X11_DIR);
#endif
}
#ifdef HAVE_X11
//$ Xephyr -ac -br -noreset -screen 800x600 :22 &
//$ DISPLAY=:22 firejail --net=eth0 --blacklist=/tmp/.X11-unix/x0 firefox
void x11_start_xephyr(int argc, char **argv) {
EUID_ASSERT();
int i;
struct stat s;
pid_t jail = 0;
pid_t server = 0;
setenv("FIREJAIL_X11", "yes", 1);
// unfortunately, xephyr does a number of weird things when started by root user!!!
if (getuid() == 0) {
fprintf(stderr, "Error: X11 sandboxing is not available when running as root\n");
exit(1);
}
drop_privs(0);
// check xephyr
if (x11_check_xephyr() == 0) {
fprintf(stderr, "\nError: Xephyr program was not found in /usr/bin directory, please install it:\n");
fprintf(stderr, " Debian/Ubuntu/Mint: sudo apt-get install xserver-xephyr\n");
fprintf(stderr, " Arch: sudo pacman -S xorg-server-xephyr\n");
exit(0);
}
int display = random_display_number();
char *display_str;
if (asprintf(&display_str, ":%d", display) == -1)
errExit("asprintf");
assert(xephyr_screen);
char *server_argv[256] = { "Xephyr", "-ac", "-br", "-noreset", "-screen", xephyr_screen }; // rest initialyzed to NULL
unsigned pos = 0;
while (server_argv[pos] != NULL) pos++;
if (checkcfg(CFG_XEPHYR_WINDOW_TITLE)) {
server_argv[pos++] = "-title";
server_argv[pos++] = "firejail x11 sandbox";
}
assert(xephyr_extra_params); // should be "" if empty
// parse xephyr_extra_params
// very basic quoting support
char *temp = strdup(xephyr_extra_params);
if (*xephyr_extra_params != '\0') {
if (!temp)
errExit("strdup");
bool dquote = false;
bool squote = false;
for (i = 0; i < (int) strlen(xephyr_extra_params); i++) {
if (temp[i] == '\"') {
dquote = !dquote;
if (dquote) temp[i] = '\0'; // replace closing quote by \0
}
if (temp[i] == '\'') {
squote = !squote;
if (squote) temp[i] = '\0'; // replace closing quote by \0
}
if (!dquote && !squote && temp[i] == ' ') temp[i] = '\0';
if (dquote && squote) {
fprintf(stderr, "Error: mixed quoting found while parsing xephyr_extra_params\n");
exit(1);
}
}
if (dquote) {
fprintf(stderr, "Error: unclosed quote found while parsing xephyr_extra_params\n");
exit(1);
}
for (i = 0; i < (int) strlen(xephyr_extra_params)-1; i++) {
if (pos >= (sizeof(server_argv)/sizeof(*server_argv))) {
fprintf(stderr, "Error: arg count limit exceeded while parsing xephyr_extra_params\n");
exit(1);
}
if (temp[i] == '\0' && (temp[i+1] == '\"' || temp[i+1] == '\'')) server_argv[pos++] = temp + i + 2;
else if (temp[i] == '\0' && temp[i+1] != '\0') server_argv[pos++] = temp + i + 1;
}
}
server_argv[pos++] = display_str;
server_argv[pos++] = NULL;
assert(pos < (sizeof(server_argv)/sizeof(*server_argv))); // no overrun
assert(server_argv[pos-1] == NULL); // last element is null
if (arg_debug) {
size_t i = 0;
printf("xephyr server:");
while (server_argv[i]!=NULL) {
printf(" \"%s\"", server_argv[i]);
i++;
}
putchar('\n');
}
// remove --x11 arg
char *jail_argv[argc+2];
int j = 0;
for (i = 0; i < argc; i++) {
if (strcmp(argv[i], "--x11") == 0)
continue;
if (strcmp(argv[i], "--x11=xpra") == 0)
continue;
if (strcmp(argv[i], "--x11=xephyr") == 0)
continue;
jail_argv[j] = argv[i];
j++;
}
jail_argv[j] = NULL;
assert(j < argc+2); // no overrun
if (arg_debug) {
size_t i = 0;
printf("xephyr client:");
while (jail_argv[i]!=NULL) {
printf(" \"%s\"", jail_argv[i]);
i++;
}
putchar('\n');
}
server = fork();
if (server < 0)
errExit("fork");
if (server == 0) {
if (arg_debug)
printf("Starting xephyr...\n");
execvp(server_argv[0], server_argv);
perror("execvp");
exit(1);
}
if (arg_debug)
printf("xephyr server pid %d\n", server);
// check X11 socket
char *fname;
if (asprintf(&fname, "/tmp/.X11-unix/X%d", display) == -1)
errExit("asprintf");
int n = 0;
// wait for x11 server to start
while (++n < 10) {
sleep(1);
if (stat(fname, &s) == 0)
break;
};
if (n == 10) {
fprintf(stderr, "Error: failed to start xephyr\n");
exit(1);
}
free(fname);
if (arg_debug) {
printf("X11 sockets: "); fflush(0);
int rv = system("ls /tmp/.X11-unix");
(void) rv;
}
setenv("DISPLAY", display_str, 1);
// run attach command
jail = fork();
if (jail < 0)
errExit("fork");
if (jail == 0) {
if (!arg_quiet)
printf("\n*** Attaching to Xephyr display %d ***\n\n", display);
execvp(jail_argv[0], jail_argv);
perror("execvp");
exit(1);
}
// cleanup
free(display_str);
free(temp);
// wait for either server or jail termination
pid_t pid = wait(NULL);
// see which process terminated and kill other
if (pid == server) {
kill(jail, SIGTERM);
} else if (pid == jail) {
kill(server, SIGTERM);
}
// without this closing Xephyr window may mess your terminal:
// "monitoring" process will release terminal before
// jail process ends and releases terminal
wait(NULL); // fulneral
exit(0);
}
void x11_start_xpra(int argc, char **argv) {
EUID_ASSERT();
int i;
struct stat s;
pid_t client = 0;
pid_t server = 0;
setenv("FIREJAIL_X11", "yes", 1);
// unfortunately, xpra does a number of weird things when started by root user!!!
if (getuid() == 0) {
fprintf(stderr, "Error: X11 sandboxing is not available when running as root\n");
exit(1);
}
drop_privs(0);
// check xpra
if (x11_check_xpra() == 0) {
fprintf(stderr, "\nError: Xpra program was not found in /usr/bin directory, please install it:\n");
fprintf(stderr, " Debian/Ubuntu/Mint: sudo apt-get install xpra\n");
exit(0);
}
int display = random_display_number();
char *display_str;
if (asprintf(&display_str, ":%d", display) == -1)
errExit("asprintf");
// build the start command
char *server_argv[] = { "xpra", "start", display_str, "--no-daemon", NULL };
int fd_null = -1;
if (arg_quiet) {
fd_null = open("/dev/null", O_RDWR);
if (fd_null == -1)
errExit("open");
}
// start
server = fork();
if (server < 0)
errExit("fork");
if (server == 0) {
if (arg_debug)
printf("Starting xpra...\n");
if (arg_quiet && fd_null != -1) {
dup2(fd_null,0);
dup2(fd_null,1);
dup2(fd_null,2);
}
execvp(server_argv[0], server_argv);
perror("execvp");
exit(1);
}
// check X11 socket
char *fname;
if (asprintf(&fname, "/tmp/.X11-unix/X%d", display) == -1)
errExit("asprintf");
int n = 0;
// wait for x11 server to start
while (++n < 10) {
sleep(1);
if (stat(fname, &s) == 0)
break;
}
if (n == 10) {
fprintf(stderr, "Error: failed to start xpra\n");
exit(1);
}
free(fname);
if (arg_debug) {
printf("X11 sockets: "); fflush(0);
int rv = system("ls /tmp/.X11-unix");
(void) rv;
}
// build attach command
char *attach_argv[] = { "xpra", "--title=\"firejail x11 sandbox\"", "attach", display_str, NULL };
// run attach command
client = fork();
if (client < 0)
errExit("fork");
if (client == 0) {
if (arg_quiet && fd_null != -1) {
dup2(fd_null,0);
dup2(fd_null,1);
dup2(fd_null,2);
}
if (!arg_quiet)
printf("\n*** Attaching to xpra display %d ***\n\n", display);
execvp(attach_argv[0], attach_argv);
perror("execvp");
exit(1);
}
setenv("DISPLAY", display_str, 1);
// build jail command
char *firejail_argv[argc+2];
int pos = 0;
for (i = 0; i < argc; i++) {
if (strcmp(argv[i], "--x11") == 0)
continue;
if (strcmp(argv[i], "--x11=xpra") == 0)
continue;
if (strcmp(argv[i], "--x11=xephyr") == 0)
continue;
firejail_argv[pos] = argv[i];
pos++;
}
firejail_argv[pos] = NULL;
assert(pos < (argc+2));
assert(!firejail_argv[pos]);
// start jail
pid_t jail = fork();
if (jail < 0)
errExit("fork");
if (jail == 0) {
if (firejail_argv[0]) // shut up llvm scan-build
execvp(firejail_argv[0], firejail_argv);
perror("execvp");
exit(1);
}
if (!arg_quiet)
printf("Xpra server pid %d, xpra client pid %d, jail %d\n", server, client, jail);
sleep(1); // let jail start
// wait for jail or server to end
while (1) {
pid_t pid = wait(NULL);
if (pid == jail) {
char *stop_argv[] = { "xpra", "stop", display_str, NULL };
pid_t stop = fork();
if (stop < 0)
errExit("fork");
if (stop == 0) {
if (arg_quiet && fd_null != -1) {
dup2(fd_null,0);
dup2(fd_null,1);
dup2(fd_null,2);
}
execvp(stop_argv[0], stop_argv);
perror("execvp");
exit(1);
}
// wait for xpra server to stop, 10 seconds limit
while (++n < 10) {
sleep(1);
pid = waitpid(server, NULL, WNOHANG);
if (pid == server)
break;
}
if (arg_debug) {
if (n == 10)
printf("failed to stop xpra server gratefully\n");
else
printf("xpra server successfully stopped in %d secs\n", n);
}
// kill xpra server and xpra client
kill(client, SIGTERM);
kill(server, SIGTERM);
exit(0);
}
else if (pid == server) {
// kill firejail process
kill(jail, SIGTERM);
// kill xpra client (should die with server, but...)
kill(client, SIGTERM);
exit(0);
}
}
}
void x11_start(int argc, char **argv) {
EUID_ASSERT();
// unfortunately, xpra does a number of weird things when started by root user!!!
if (getuid() == 0) {
fprintf(stderr, "Error: X11 sandboxing is not available when running as root\n");
exit(1);
}
// check xpra
if (x11_check_xpra() == 1)
x11_start_xpra(argc, argv);
else if (x11_check_xephyr() == 1)
x11_start_xephyr(argc, argv);
else {
fprintf(stderr, "\nError: Xpra or Xephyr not found in /usr/bin directory, please install one of them:\n");
fprintf(stderr, " Debian/Ubuntu/Mint: sudo apt-get install xpra\n");
fprintf(stderr, " Debian/Ubuntu/Mint: sudo apt-get install xserver-xephyr\n");
exit(0);
}
}
#endif
void x11_block(void) {
#ifdef HAVE_X11
// check abstract socket presence and network namespace options
if ((!arg_nonetwork && !cfg.bridge0.configured && !cfg.interface0.configured)
&& x11_abstract_sockets_present()) {
fprintf(stderr, "ERROR: --x11=block specified, but abstract X11 socket still accessible.\n"
"Additional setup required. To block abstract X11 socket you can either:\n"
" * use network namespace in firejail (--net=none, --net=...)\n"
" * add \"-nolisten local\" to xserver options\n"
" (eg. to your display manager config, or /etc/X11/xinit/xserverrc)\n");
exit(1);
}
// blacklist sockets
profile_check_line("blacklist /tmp/.X11-unix", 0, NULL);
profile_add(strdup("blacklist /tmp/.X11-unix"));
// blacklist .Xauthority
profile_check_line("blacklist ${HOME}/.Xauthority", 0, NULL);
profile_add(strdup("blacklist ${HOME}/.Xauthority"));
char *xauthority = getenv("XAUTHORITY");
if (xauthority) {
char *line;
if (asprintf(&line, "blacklist %s", xauthority) == -1)
errExit("asprintf");
profile_check_line(line, 0, NULL);
profile_add(line);
}
// clear enviroment
env_store("DISPLAY", RMENV);
env_store("XAUTHORITY", RMENV);
#endif
}
|