From ac78207f7c578cb1464bf7abcf9f605a675a7164 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Mon, 27 Sep 2021 23:42:43 -0300 Subject: Remove unnecessary linux/limits.h include None of the files affected use any macros from linux/limits.h: $ git grep -Fl 'NGROUPS_MAX ARG_MAX LINK_MAX MAX_CANON MAX_INPUT NAME_MAX PATH_MAX PIPE_BUF XATTR_NAME_MAX XATTR_SIZE_MAX XATTR_LIST_MAX RTSIG_MAX' -- src src/firejail/cmdline.c src/firejail/firejail.h src/libtrace/libtrace.c src/libtracelog/libtracelog.c Environment: $ grep '^NAME' /etc/os-release NAME="Artix Linux" $ pacman -Qo /usr/include/linux/limits.h /usr/include/linux/limits.h is owned by linux-api-headers 5.12.3-1 Note: This include has been present on all of the affected files since their inception. For restrict_users.c, that's on commit 4f003daec ("prevent leaking user information by modifying /home directory, /etc/passwd and /etc/group") and for every other file, it's on commit 137985136 ("Baseline firejail 0.9.28"). Relates to #4578. --- src/firejail/fs.c | 1 - src/firejail/fs_dev.c | 1 - src/firejail/fs_home.c | 1 - src/firejail/fs_hostname.c | 1 - src/firejail/fs_trace.c | 1 - src/firejail/fs_var.c | 1 - src/firejail/restrict_users.c | 1 - 7 files changed, 7 deletions(-) (limited to 'src') diff --git a/src/firejail/fs.c b/src/firejail/fs.c index dd4c2139d..7e0a6e347 100644 --- a/src/firejail/fs.c +++ b/src/firejail/fs.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include diff --git a/src/firejail/fs_dev.c b/src/firejail/fs_dev.c index 8cc3ecc62..d8bb1aded 100644 --- a/src/firejail/fs_dev.c +++ b/src/firejail/fs_dev.c @@ -20,7 +20,6 @@ #include "firejail.h" #include #include -#include #include #include #include diff --git a/src/firejail/fs_home.c b/src/firejail/fs_home.c index 0ed476063..45889b27f 100644 --- a/src/firejail/fs_home.c +++ b/src/firejail/fs_home.c @@ -19,7 +19,6 @@ */ #include "firejail.h" #include -#include #include #include #include diff --git a/src/firejail/fs_hostname.c b/src/firejail/fs_hostname.c index 7d320e90b..f7ce8c18f 100644 --- a/src/firejail/fs_hostname.c +++ b/src/firejail/fs_hostname.c @@ -20,7 +20,6 @@ #include "firejail.h" #include #include -#include #include #include #include diff --git a/src/firejail/fs_trace.c b/src/firejail/fs_trace.c index 475a391ec..9463fbcd0 100644 --- a/src/firejail/fs_trace.c +++ b/src/firejail/fs_trace.c @@ -20,7 +20,6 @@ #include "firejail.h" #include #include -#include #include #include #include diff --git a/src/firejail/fs_var.c b/src/firejail/fs_var.c index 20e262d80..5ba38d46c 100644 --- a/src/firejail/fs_var.c +++ b/src/firejail/fs_var.c @@ -20,7 +20,6 @@ #include "firejail.h" #include #include -#include #include #include #include diff --git a/src/firejail/restrict_users.c b/src/firejail/restrict_users.c index 6f17231a4..59077dada 100644 --- a/src/firejail/restrict_users.c +++ b/src/firejail/restrict_users.c @@ -21,7 +21,6 @@ #include "../include/firejail_user.h" #include #include -#include #include #include #include -- cgit v1.2.3-70-g09d2