From 4ec84fa66436a6e64bf54edd98f80398e40765cb Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Tue, 23 May 2017 21:43:42 +0200 Subject: minor bugfix: Correctly dereference "subdirname" variable cppcheck reported: [firejail/main.c:1335]: (warning) Char literal compared with pointer 'subdirname'. Did you intend to dereference it? --- src/firejail/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/firejail/main.c b/src/firejail/main.c index 012b2f230..95c325f9f 100644 --- a/src/firejail/main.c +++ b/src/firejail/main.c @@ -1332,7 +1332,7 @@ int main(int argc, char **argv) { arg_overlay_reuse = 1; char *subdirname = argv[i] + 16; - if (subdirname == '\0') { + if (*subdirname == '\0') { fprintf(stderr, "Error: invalid overlay option\n"); exit(1); } -- cgit v1.2.3-70-g09d2 From 9215296d34407e487187a0ef30bf623d2a417dc5 Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Tue, 23 May 2017 21:52:43 +0200 Subject: Fix another "subdirname" variable dereference issue --- src/firejail/profile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/firejail/profile.c b/src/firejail/profile.c index 11258892e..cabea05f3 100644 --- a/src/firejail/profile.c +++ b/src/firejail/profile.c @@ -852,7 +852,7 @@ int profile_check_line(char *ptr, int lineno, const char *fname) { arg_overlay_reuse = 1; char *subdirname = ptr + 14; - if (subdirname == '\0') { + if (*subdirname == '\0') { fprintf(stderr, "Error: invalid overlay option\n"); exit(1); } -- cgit v1.2.3-70-g09d2