From 2e9bb49dfac23b7605cb3be184bdd74ce74e77ea Mon Sep 17 00:00:00 2001 From: netblue30 Date: Sat, 28 Nov 2015 08:17:48 -0500 Subject: cleanup --- src/firejail/fs.c | 1 - src/firejail/main.c | 1 - src/firemon/netstats.c | 2 +- src/libtrace/libtrace.c | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/firejail/fs.c b/src/firejail/fs.c index 6572f657b..e93db9cff 100644 --- a/src/firejail/fs.c +++ b/src/firejail/fs.c @@ -385,7 +385,6 @@ void fs_blacklist(void) { ptr = new_name; // expand path macro - look for the file in /bin, /usr/bin, /sbin and /usr/sbin directories - // TODO: should we look for more bin paths? if (ptr) { if (strncmp(ptr, "${PATH}", 7) == 0) { char *fname = ptr + 7; diff --git a/src/firejail/main.c b/src/firejail/main.c index 0e0d685c4..41517877b 100644 --- a/src/firejail/main.c +++ b/src/firejail/main.c @@ -1201,7 +1201,6 @@ int main(int argc, char **argv) { } else { // calculate the length of the command - // TODO: escape the '"' characters, and possibly others like '\' and '!' if they can cause problems int i; int len = 0; int argcnt = argc - prog_index; diff --git a/src/firemon/netstats.c b/src/firemon/netstats.c index 3f1e00ee9..9a1487c62 100644 --- a/src/firemon/netstats.c +++ b/src/firemon/netstats.c @@ -172,7 +172,7 @@ void netstats(void) { // set pid table int i; int itv = 5; // 5 second interval - pid_read(0); // todo: preserve the last calculation if any, so we don't have to do get_stats() + pid_read(0); // start rx/tx measurements for (i = 0; i < max_pids; i++) { diff --git a/src/libtrace/libtrace.c b/src/libtrace/libtrace.c index 12a8c7f4a..b763213f6 100644 --- a/src/libtrace/libtrace.c +++ b/src/libtrace/libtrace.c @@ -511,7 +511,7 @@ int bind(int sockfd, const struct sockaddr *addr, socklen_t addrlen) { return rv; } -#if 0 //todo: fix compilation problems +#if 0 typedef int (*orig_accept_t)(int sockfd, const struct sockaddr *addr, socklen_t addrlen); static orig_accept_t orig_accept = NULL; int accept(int sockfd, struct sockaddr *addr, socklen_t addrlen) { -- cgit v1.2.3-54-g00ecf