From f70ffbe76cd06c03442132f06d503846a415f24c Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Thu, 1 Feb 2024 23:21:26 -0300 Subject: landlock: split .special into .makeipc and .makedev As discussed with @topimiettinen[1], it is unlikely that an unprivileged process would need to directly create block or character devices. Also, `landlock.special` is not very descriptive of what it allows. So split `landlock.special` into: * `landlock.makeipc`: allow creating named pipes and sockets (which are usually used for inter-process communication) * `landlock.makedev`: allow creating block and character devices Misc: The `makedev` name is based on `nodev` from mount(8), which makes mount not interpret block and character devices. `ipc` was suggested by @rusty-snake[2]. Relates to #6078. [1] https://github.com/netblue30/firejail/pull/6078#pullrequestreview-1740569786 [2] https://github.com/netblue30/firejail/pull/6187#issuecomment-1924107294 --- src/bash_completion/firejail.bash_completion.in | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/bash_completion') diff --git a/src/bash_completion/firejail.bash_completion.in b/src/bash_completion/firejail.bash_completion.in index 76667ca0c..6c985bc6e 100644 --- a/src/bash_completion/firejail.bash_completion.in +++ b/src/bash_completion/firejail.bash_completion.in @@ -53,7 +53,11 @@ _firejail() _filedir return 0 ;; - --landlock.special) + --landlock.makeipc) + _filedir + return 0 + ;; + --landlock.makedev) _filedir return 0 ;; -- cgit v1.2.3-54-g00ecf