From 0dc82f0bc334c529977a873bcc243f46379cfbc8 Mon Sep 17 00:00:00 2001 From: rusty-snake <41237666+rusty-snake@users.noreply.github.com> Date: Fri, 4 Jun 2021 07:59:09 +0200 Subject: Better error message for jail_prober.py cli usage Curerently sys.argv is accessed without checks, resulting in an IndexError: ``` Traceback (most recent call last): File "/home/rusty-snake/Projects/firejail/contrib/jail_prober.py", line 205, in main() File "/home/rusty-snake/Projects/firejail/contrib/jail_prober.py", line 170, in main profile_path = sys.argv[1] IndexError: list index out of range ``` This commit catches this IndexError and prints a more helpfull message instaed: ``` USAGE: jail_prober.py ``` --- contrib/jail_prober.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'contrib') diff --git a/contrib/jail_prober.py b/contrib/jail_prober.py index 95e299624..f89f97ac4 100755 --- a/contrib/jail_prober.py +++ b/contrib/jail_prober.py @@ -164,8 +164,12 @@ def run_firejail(program, all_args): def main(): - profile_path = sys.argv[1] - program = sys.argv[2] + try: + profile_path = sys.argv[1] + program = sys.argv[2] + except IndexError: + print('USAGE: jail_prober.py ') + sys.exit() # Quick error check and extract arguments check_params(profile_path) profile = get_args(profile_path) -- cgit v1.2.3-70-g09d2