From 245e4cca6271355bf6be0dcc5ffb3d9bc359a4e9 Mon Sep 17 00:00:00 2001 From: "Kelvin M. Klann" Date: Tue, 27 Sep 2022 05:17:12 -0300 Subject: configure*: wrap long shell command output lines Instead of binding them together with conditionals in a single line, split shell commands into multiple lines to make them more readable. Note that for the macro arguments in question, the content inside [] quotes is output literally into ./configure, so the commands can be written as if they were in a shell script directly (save for any special characters/tokens in Autoconf). Misc: Relates to commit 2c64d1fdd ("use AX_CHECK_COMPILE_FLAG to check for spectre flags", 2019-06-21). --- configure.ac | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) (limited to 'configure.ac') diff --git a/configure.ac b/configure.ac index a78688e09..9cc20d94a 100644 --- a/configure.ac +++ b/configure.ac @@ -21,22 +21,22 @@ AC_CONFIG_MACRO_DIR([m4]) AC_PROG_CC HAVE_SPECTRE="no" -AX_CHECK_COMPILE_FLAG( - [-mindirect-branch=thunk], - [HAVE_SPECTRE="yes" && EXTRA_CFLAGS="$EXTRA_CFLAGS -mindirect-branch=thunk"] -) -AX_CHECK_COMPILE_FLAG( - [-mretpoline], - [HAVE_SPECTRE="yes" && EXTRA_CFLAGS="$EXTRA_CFLAGS -mretpoline"] -) -AX_CHECK_COMPILE_FLAG( - [-fstack-clash-protection], - [HAVE_SPECTRE="yes" && EXTRA_CFLAGS="$EXTRA_CFLAGS -fstack-clash-protection"] -) -AX_CHECK_COMPILE_FLAG( - [-fstack-protector-strong], - [HAVE_SPECTRE="yes" && EXTRA_CFLAGS="$EXTRA_CFLAGS -fstack-protector-strong"] -) +AX_CHECK_COMPILE_FLAG([-mindirect-branch=thunk], [ + HAVE_SPECTRE="yes" + EXTRA_CFLAGS="$EXTRA_CFLAGS -mindirect-branch=thunk" +]) +AX_CHECK_COMPILE_FLAG([-mretpoline], [ + HAVE_SPECTRE="yes" + EXTRA_CFLAGS="$EXTRA_CFLAGS -mretpoline" +]) +AX_CHECK_COMPILE_FLAG([-fstack-clash-protection], [ + HAVE_SPECTRE="yes" + EXTRA_CFLAGS="$EXTRA_CFLAGS -fstack-clash-protection" +]) +AX_CHECK_COMPILE_FLAG([-fstack-protector-strong], [ + HAVE_SPECTRE="yes" + EXTRA_CFLAGS="$EXTRA_CFLAGS -fstack-protector-strong" +]) AC_ARG_ENABLE([analyzer], [AS_HELP_STRING([--enable-analyzer], [enable GCC static analyzer])]) @@ -68,8 +68,10 @@ AC_ARG_ENABLE([apparmor], [AS_HELP_STRING([--enable-apparmor], [enable apparmor])]) AS_IF([test "x$enable_apparmor" = "xyes"], [ HAVE_APPARMOR="-DHAVE_APPARMOR" - PKG_CHECK_MODULES([AA], [libapparmor], - [EXTRA_CFLAGS="$EXTRA_CFLAGS $AA_CFLAGS" && EXTRA_LDFLAGS="$EXTRA_LDFLAGS $AA_LIBS"]) + PKG_CHECK_MODULES([AA], [libapparmor], [ + EXTRA_CFLAGS="$EXTRA_CFLAGS $AA_CFLAGS" + EXTRA_LDFLAGS="$EXTRA_LDFLAGS $AA_LIBS" + ]) ]) HAVE_SELINUX="" -- cgit v1.2.3-54-g00ecf