From d1948ffc3b5453e58849bec8855de38bf19a9ba1 Mon Sep 17 00:00:00 2001
From: netblue30 <netblue30@yahoo.com>
Date: Fri, 6 Nov 2015 07:48:23 -0500
Subject: coverity

---
 src/firejail/env.c    | 2 ++
 src/firejail/fs.c     | 1 +
 src/firejail/fs_dev.c | 1 +
 src/firejail/fs_var.c | 1 +
 4 files changed, 5 insertions(+)

diff --git a/src/firejail/env.c b/src/firejail/env.c
index 2bbd2d226..99922aac3 100644
--- a/src/firejail/env.c
+++ b/src/firejail/env.c
@@ -47,6 +47,7 @@ void env_ibus_load(void) {
 		return;
 
 	// find the file
+	/* coverity[toctou] */
 	DIR *dir = opendir(dirname);
 	if (!dir) {
 		free(dirname);
@@ -92,6 +93,7 @@ void env_ibus_load(void) {
 	}
 
 	free(dirname);
+	closedir(dir);
 }
 
 
diff --git a/src/firejail/fs.c b/src/firejail/fs.c
index 42d31f567..ca44a2d5d 100644
--- a/src/firejail/fs.c
+++ b/src/firejail/fs.c
@@ -102,6 +102,7 @@ void fs_build_cp_command(void) {
 			fprintf(stderr, "Error: cannot access /bin/cp\n");
 			exit(1);
 		}
+		/* coverity[toctou] */
 		if (chmod(CP_COMMAND, 0755))
 			errExit("chmod");
 			
diff --git a/src/firejail/fs_dev.c b/src/firejail/fs_dev.c
index ee67a5696..ec7126ffd 100644
--- a/src/firejail/fs_dev.c
+++ b/src/firejail/fs_dev.c
@@ -96,6 +96,7 @@ void fs_private_dev(void){
 
 	// bring back the /dev/dri directory
 	if (have_dri) {
+		/* coverity[toctou] */
 		rv = mkdir("/dev/dri", 0755);
 		if (rv == -1)
 			errExit("mkdir");
diff --git a/src/firejail/fs_var.c b/src/firejail/fs_var.c
index 7e822f614..c6f989266 100644
--- a/src/firejail/fs_var.c
+++ b/src/firejail/fs_var.c
@@ -318,6 +318,7 @@ void fs_var_utmp(void) {
 	if (arg_debug)
 		printf("Create the new utmp file\n");
 
+	/* coverity[toctou] */
 	FILE *fp = fopen(UTMP_FILE, "w");
 	if (!fp)
 		errExit("fopen");
-- 
cgit v1.2.3-70-g09d2